Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
	"Luca Weiss" <luca.weiss@fairphone.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Alexander Koskovich" <AKoskovich@pm.me>
Cc: <~postmarketos/upstreaming@lists.sr.ht>,
	<phone-devel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/5] arm64: dts: qcom: milos-fairphone-fp6: Enable Bluetooth
Date: Fri, 13 Mar 2026 11:40:18 +0100	[thread overview]
Message-ID: <DH1L9UD68SKL.21KTH1XGR724Y@fairphone.com> (raw)
In-Reply-To: <52fffc84-2fb5-47aa-835c-b0dd8c110d59@oss.qualcomm.com>

On Wed Jan 21, 2026 at 12:52 PM CET, Konrad Dybcio wrote:
> On 1/16/26 3:50 PM, Luca Weiss wrote:
>> Add the nodes to describe the WCN6755 chip with its PMU and Bluetooth
>> parts.
>> 
>> Thanks to Alexander Koskovich for helping with the bringup, adding
>> 'clocks' to the PMU node to make Bluetooth work.
>> 
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>>  arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 174 +++++++++++++++++++++++
>>  1 file changed, 174 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> index 52895dd9e4fa..cbe1507b0aaa 100644
>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> @@ -24,6 +24,7 @@ / {
>>  
>>  	aliases {
>>  		serial0 = &uart5;
>> +		serial1 = &uart11;
>>  	};
>>  
>>  	gpio-keys {
>> @@ -215,6 +216,67 @@ trip1 {
>>  			};
>>  		};
>>  	};
>> +
>> +	wcn6750-pmu {
>> +		compatible = "qcom,wcn6750-pmu"; /* WCN6755 */
>
> I think a fallback compatible would be in order, if the data matches
> exactly

That'd give us these changes

milos.dtsi:

    -+                  compatible = "qcom,wcn6750-wifi";
    ++                  compatible = "qcom,wcn6755-wifi", "qcom,wcn6750-wifi";

milos-fairphone-fp6.dts:

    -+          compatible = "qcom,wcn6750-pmu"; /* WCN6755 */
    ++          compatible = "qcom,wcn6755-pmu", "qcom,wcn6750-pmu";

    -+          compatible = "qcom,wcn6750-bt"; /* WCN6755 */
    ++          compatible = "qcom,wcn6755-bt", "qcom,wcn6750-bt";

Plus 3 new patches for dt-bindings, with commit message something like

Document the WCN6755 WiFi using a fallback to WCN6750 since the two
chips seem to be completely pin and software compatible. In fact the
original downstream kernel just pretends the WCN6755 is a WCN6750.

Does this sound okay?

>
>> +	bluetooth_enable_default: bluetooth-enable-default-state {
>> +		pins = "gpio53";
>> +		function = "gpio";
>> +		output-low;
>> +		bias-disable;
>> +	};
>
> Not sure if we need to drive that pin.. perhaps a pull-down would
> suffice?

I'll give it a shot, this pinctrl is coming from downstream but perhaps
the downstream btpower.c driver is differing in behavior to the upstream
PMU driver.

Regards
Luca

>
> [...]
>
>> +	bluetooth {
>> +		compatible = "qcom,wcn6750-bt"; /* WCN6755 */
>
> Likewise
>
> Konrad


  reply	other threads:[~2026-03-13 10:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 14:50 [PATCH 0/5] Enable Bluetooth and WiFi on Fairphone (Gen. 6) Luca Weiss
2026-01-16 14:50 ` [PATCH 1/5] soc: qcom: pd-mapper: Add Milos compatible Luca Weiss
2026-01-16 16:13   ` Dmitry Baryshkov
2026-01-16 14:50 ` [PATCH 2/5] arm64: dts: qcom: milos: Split up uart11 pinctrl Luca Weiss
2026-01-20 14:12   ` Konrad Dybcio
2026-01-16 14:50 ` [PATCH 3/5] arm64: dts: qcom: milos: Add WCN6750 WiFi node Luca Weiss
2026-01-16 16:14   ` Dmitry Baryshkov
2026-01-20 14:39   ` Konrad Dybcio
2026-02-13 13:42     ` Luca Weiss
2026-02-17 11:01       ` Konrad Dybcio
2026-02-13 14:31     ` Dmitry Baryshkov
2026-02-17 10:59       ` Konrad Dybcio
2026-01-16 14:50 ` [PATCH 4/5] arm64: dts: qcom: milos-fairphone-fp6: Enable Bluetooth Luca Weiss
2026-01-16 16:15   ` Dmitry Baryshkov
2026-01-21 11:52   ` Konrad Dybcio
2026-03-13 10:40     ` Luca Weiss [this message]
2026-03-13 12:41       ` Konrad Dybcio
2026-03-13 14:00       ` Luca Weiss
2026-03-16 12:50         ` Konrad Dybcio
2026-01-16 14:50 ` [PATCH 5/5] arm64: dts: qcom: milos-fairphone-fp6: Enable WiFi Luca Weiss
2026-01-16 16:17   ` Dmitry Baryshkov
2026-01-21 11:50   ` Konrad Dybcio
2026-02-13 14:24     ` Luca Weiss
2026-02-17 10:56       ` Konrad Dybcio
2026-03-19  3:31 ` (subset) [PATCH 0/5] Enable Bluetooth and WiFi on Fairphone (Gen. 6) Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH1L9UD68SKL.21KTH1XGR724Y@fairphone.com \
    --to=luca.weiss@fairphone.com \
    --cc=AKoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox