* [PATCH] drm/msm/hdmi: remove unnecessary NULL check
@ 2022-11-15 13:03 Dan Carpenter
2022-11-17 4:04 ` Abhinav Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-11-15 13:03 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov
Cc: Abhinav Kumar, Sean Paul, David Airlie, Daniel Vetter,
Stephen Boyd, Johan Hovold, Kuogee Hsieh, linux-arm-msm,
dri-devel, freedreno, kernel-janitors
This code was refactored in commit 69a88d8633ec ("drm/msm/hdmi: move
resource allocation to probe function") and now the "hdmi" pointer can't
be NULL. Checking causes a Smatch warning:
drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init()
warn: variable dereferenced before check 'hdmi' (see line 119)
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index 7001fabd0977..4d3fdc806bef 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -138,8 +138,7 @@ static int msm_hdmi_init(struct hdmi *hdmi)
return 0;
fail:
- if (hdmi)
- msm_hdmi_destroy(hdmi);
+ msm_hdmi_destroy(hdmi);
return ret;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/msm/hdmi: remove unnecessary NULL check
2022-11-15 13:03 [PATCH] drm/msm/hdmi: remove unnecessary NULL check Dan Carpenter
@ 2022-11-17 4:04 ` Abhinav Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Abhinav Kumar @ 2022-11-17 4:04 UTC (permalink / raw)
To: Dan Carpenter, Rob Clark, Dmitry Baryshkov
Cc: Sean Paul, David Airlie, Daniel Vetter, Stephen Boyd,
Johan Hovold, Kuogee Hsieh, linux-arm-msm, dri-devel, freedreno,
kernel-janitors
On 11/15/2022 5:03 AM, Dan Carpenter wrote:
> This code was refactored in commit 69a88d8633ec ("drm/msm/hdmi: move
> resource allocation to probe function") and now the "hdmi" pointer can't
> be NULL. Checking causes a Smatch warning:
>
> drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init()
> warn: variable dereferenced before check 'hdmi' (see line 119)
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Can you please add the fixes tag to point to the commit you have
referenced in the commit message?
LTGM,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/hdmi/hdmi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 7001fabd0977..4d3fdc806bef 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -138,8 +138,7 @@ static int msm_hdmi_init(struct hdmi *hdmi)
> return 0;
>
> fail:
> - if (hdmi)
> - msm_hdmi_destroy(hdmi);
> + msm_hdmi_destroy(hdmi);
>
> return ret;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-17 4:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-15 13:03 [PATCH] drm/msm/hdmi: remove unnecessary NULL check Dan Carpenter
2022-11-17 4:04 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox