[PATCH] mfd: qcom-pm8xxx: Remove set but unused variable 'rev'

[PATCH] mfd: qcom-pm8xxx: Remove set but unused variable 'rev'

[Jiapeng Chong]

Variable rev is not effectively used in the function, so delete it.

drivers/mfd/qcom-pm8xxx.c:513:6: warning: variable 'rev' set but not used.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3558
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/mfd/qcom-pm8xxx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
index 601106580e2e..9a948df8c28d 100644
--- a/drivers/mfd/qcom-pm8xxx.c
+++ b/drivers/mfd/qcom-pm8xxx.c
@@ -510,7 +510,6 @@ static int pm8xxx_probe(struct platform_device *pdev)
 	struct regmap *regmap;
 	int irq, rc;
 	unsigned int val;
-	u32 rev;
 	struct pm_irq_chip *chip;
 
 	data = of_device_get_match_data(&pdev->dev);
@@ -535,7 +534,6 @@ static int pm8xxx_probe(struct platform_device *pdev)
 		return rc;
 	}
 	pr_info("PMIC revision 1: %02X\n", val);
-	rev = val;
 
 	/* Read PMIC chip revision 2 */
 	rc = regmap_read(regmap, REG_HWREV_2, &val);
@@ -545,7 +543,6 @@ static int pm8xxx_probe(struct platform_device *pdev)
 		return rc;
 	}
 	pr_info("PMIC revision 2: %02X\n", val);
-	rev |= val << BITS_PER_BYTE;
 
 	chip = devm_kzalloc(&pdev->dev,
 			    struct_size(chip, config, data->num_irqs),
-- 
2.20.1.7.g153144c

Re: [PATCH] mfd: qcom-pm8xxx: Remove set but unused variable 'rev'

[Lee Jones]

On Tue, 27 Dec 2022, Jiapeng Chong wrote:

> Variable rev is not effectively used in the function, so delete it.
> 
> drivers/mfd/qcom-pm8xxx.c:513:6: warning: variable 'rev' set but not used.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3558
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/mfd/qcom-pm8xxx.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]