* [PATCH] phy: qcom-qmp-combo: fix sc8280xp PCS_USB offset
@ 2022-09-19 9:57 Johan Hovold
2022-09-20 6:14 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2022-09-19 9:57 UTC (permalink / raw)
To: Vinod Koul
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, linux-arm-msm, linux-phy, linux-kernel,
Johan Hovold
The PCS_USB register block lives at an offset of 0x300 from the PCS
region on SC8280XP so add the missing offset to avoid corrupting
unrelated registers on runtime suspend.
Note that this region should probably be described separately in the
binding.
Fixes: a2e927b0e50d ("phy: qcom-qmp-combo: Add sc8280xp USB/DP combo phys")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 1 +
1 file changed, 1 insertion(+)
The corresponding DT fix is here:
https://lore.kernel.org/all/20220919094454.1574-4-johan+linaro@kernel.org/
Johan
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index d200cd5ca4fa..ed196d00815b 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -1261,6 +1261,7 @@ static const struct qmp_phy_cfg sc8280xp_usb43dp_usb_cfg = {
.vreg_list = qmp_phy_vreg_l,
.num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
.regs = qmp_v4_usb3phy_regs_layout,
+ .pcs_usb_offset = 0x300,
.start_ctrl = SERDES_START | PCS_START,
.pwrdn_ctrl = SW_PWRDN,
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] phy: qcom-qmp-combo: fix sc8280xp PCS_USB offset
2022-09-19 9:57 [PATCH] phy: qcom-qmp-combo: fix sc8280xp PCS_USB offset Johan Hovold
@ 2022-09-20 6:14 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-09-20 6:14 UTC (permalink / raw)
To: Johan Hovold
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, linux-arm-msm, linux-phy, linux-kernel
On 19-09-22, 11:57, Johan Hovold wrote:
> The PCS_USB register block lives at an offset of 0x300 from the PCS
> region on SC8280XP so add the missing offset to avoid corrupting
> unrelated registers on runtime suspend.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-20 6:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-19 9:57 [PATCH] phy: qcom-qmp-combo: fix sc8280xp PCS_USB offset Johan Hovold
2022-09-20 6:14 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox