From: Johan Hovold <johan@kernel.org>
To: maud_spierings@hotmail.com
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v5 1/3] arm64: dts: qcom: x1e80100-vivobook-s15: Use the samsung,atna33xc20 panel driver
Date: Tue, 3 Dec 2024 09:38:03 +0100 [thread overview]
Message-ID: <Z07Da9S-t_od-6Cd@hovoldconsulting.com> (raw)
In-Reply-To: <20241202-asus_qcom_display-v5-1-e0d3752ff71f@hotmail.com>
On Mon, Dec 02, 2024 at 07:18:11PM +0100, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maud_spierings@hotmail.com>
>
> The Asus vivobook s15 uses the ATNA56AC03 panel.
> This panel is controlled by the atna33xc20 driver instead of the generic
> edp-panel driver
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Maud Spierings <maud_spierings@hotmail.com>
> +&pmc8380_3_gpios {
> + edp_bl_en: edp-bl-en-state {
> + pins = "gpio4";
> + function = "normal";
> + power-source = <1>;
> + qcom,drive-strength = <2>;
Please use the Qualcomm drive strength defines from
dt-bindings/pinctrl/qcom,pmic-gpio.h here (e.g. PMIC_GPIO_STRENGTH_MED).
> + bias-pull-down;
> + input-disable;
> + output-enable;
> + };
> +};
Johan
next prev parent reply other threads:[~2024-12-03 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 18:18 [PATCH v5 0/3] Asus vivobook s15 improvements Maud Spierings via B4 Relay
2024-12-02 18:18 ` [PATCH v5 1/3] arm64: dts: qcom: x1e80100-vivobook-s15: Use the samsung,atna33xc20 panel driver Maud Spierings via B4 Relay
2024-12-03 8:38 ` Johan Hovold [this message]
2024-12-02 18:18 ` [PATCH v5 2/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add lid switch Maud Spierings via B4 Relay
2024-12-02 18:18 ` [PATCH v5 3/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add bluetooth Maud Spierings via B4 Relay
2024-12-03 8:52 ` Johan Hovold
2024-12-03 9:06 ` Maud Spierings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z07Da9S-t_od-6Cd@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maud_spierings@hotmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox