* [PATCH] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1
@ 2024-12-07 14:04 Konrad Dybcio
2024-12-11 13:48 ` Rajendra Nayak
2024-12-11 13:55 ` Johan Hovold
0 siblings, 2 replies; 4+ messages in thread
From: Konrad Dybcio @ 2024-12-07 14:04 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Sibi Sankar, Bryan O'Donoghue,
Rajendra Nayak
Cc: Marijn Suijten, linux-arm-msm, linux-kernel, Konrad Dybcio
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Do so in accordance with the internal recommendations.
Fixes: b3cf69a43502 ("soc: qcom: llcc: Add configuration data for X1E80100")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/soc/qcom/llcc-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 32c3bc887cefb87c296e3ba67a730c87fa2fa346..1560db00a01248197e5c2936e785a5ea77f74ad8 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -3004,6 +3004,7 @@ static const struct llcc_slice_config x1e80100_data[] = {
.fixed_size = true,
.bonus_ways = 0xfff,
.cache_mode = 0,
+ .activate_on_init = true,
}, {
.usecase_id = LLCC_CAMEXP0,
.slice_id = 4,
---
base-commit: ebe1b11614e079c5e366ce9bd3c8f44ca0fbcc1b
change-id: 20241207-topic-llcc_x1e_wrcache-647070e2d130
Best regards,
--
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1
2024-12-07 14:04 [PATCH] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1 Konrad Dybcio
@ 2024-12-11 13:48 ` Rajendra Nayak
2024-12-11 13:55 ` Johan Hovold
1 sibling, 0 replies; 4+ messages in thread
From: Rajendra Nayak @ 2024-12-11 13:48 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Sibi Sankar, Bryan O'Donoghue
Cc: Marijn Suijten, linux-arm-msm, linux-kernel, Konrad Dybcio
On 12/7/2024 7:34 PM, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Do so in accordance with the internal recommendations.
>
> Fixes: b3cf69a43502 ("soc: qcom: llcc: Add configuration data for X1E80100")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
Reviewed-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> drivers/soc/qcom/llcc-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 32c3bc887cefb87c296e3ba67a730c87fa2fa346..1560db00a01248197e5c2936e785a5ea77f74ad8 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -3004,6 +3004,7 @@ static const struct llcc_slice_config x1e80100_data[] = {
> .fixed_size = true,
> .bonus_ways = 0xfff,
> .cache_mode = 0,
> + .activate_on_init = true,
> }, {
> .usecase_id = LLCC_CAMEXP0,
> .slice_id = 4,
>
> ---
> base-commit: ebe1b11614e079c5e366ce9bd3c8f44ca0fbcc1b
> change-id: 20241207-topic-llcc_x1e_wrcache-647070e2d130
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1
2024-12-07 14:04 [PATCH] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1 Konrad Dybcio
2024-12-11 13:48 ` Rajendra Nayak
@ 2024-12-11 13:55 ` Johan Hovold
2024-12-12 15:33 ` Konrad Dybcio
1 sibling, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2024-12-11 13:55 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Sibi Sankar, Bryan O'Donoghue,
Rajendra Nayak, Marijn Suijten, linux-arm-msm, linux-kernel,
Konrad Dybcio
On Sat, Dec 07, 2024 at 03:04:26PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Do so in accordance with the internal recommendations.
Any hints about why this is needed? Should the fix be backported?
> Fixes: b3cf69a43502 ("soc: qcom: llcc: Add configuration data for X1E80100")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1
2024-12-11 13:55 ` Johan Hovold
@ 2024-12-12 15:33 ` Konrad Dybcio
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2024-12-12 15:33 UTC (permalink / raw)
To: Johan Hovold, Konrad Dybcio
Cc: Bjorn Andersson, Sibi Sankar, Bryan O'Donoghue,
Rajendra Nayak, Marijn Suijten, linux-arm-msm, linux-kernel,
Konrad Dybcio
On 11.12.2024 2:55 PM, Johan Hovold wrote:
> On Sat, Dec 07, 2024 at 03:04:26PM +0100, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> Do so in accordance with the internal recommendations.
>
> Any hints about why this is needed?
"it's good for your cache to be active" ;)
> Should the fix be backported?
Most certainly.. I'll resend with a CC stable and as per Rob
Clark's suggestion, with a larger amount of context to make
sure this doesn't get stuck in a random place in the file
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-12 15:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-07 14:04 [PATCH] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1 Konrad Dybcio
2024-12-11 13:48 ` Rajendra Nayak
2024-12-11 13:55 ` Johan Hovold
2024-12-12 15:33 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox