From: Johan Hovold <johan@kernel.org>
To: Mark Kettenis <kettenis@openbsd.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Abel Vesa <abel.vesa@linaro.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
Date: Fri, 10 Jan 2025 17:38:39 +0100 [thread overview]
Message-ID: <Z4FND-b-gEb6YJw6@hovoldconsulting.com> (raw)
In-Reply-To: <20250109205232.92336-1-kettenis@openbsd.org>
On Thu, Jan 09, 2025 at 09:52:31PM +0100, Mark Kettenis wrote:
> Make this USB controller consistent with the others on this platform.
>
> Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 4936fa5b98ff..aad1153a443d 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -4814,6 +4814,8 @@ usb_2_dwc3: usb@a200000 {
> snps,dis-u1-entry-quirk;
> snps,dis-u2-entry-quirk;
>
> + dma-coherent;
> +
Can someone from Qualcomm please confirm that this is correct, and that
it's not the other way round and this property should be removed from
the other controllers (e.g. if this was just some copy-pasta from sm8550
which is the only other Qualcomm platform that claims to have
dma-coherent USB controllers).
Johan
next prev parent reply other threads:[~2025-01-10 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 20:52 [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent Mark Kettenis
2025-01-10 0:36 ` Konrad Dybcio
2025-01-10 16:38 ` Johan Hovold [this message]
2025-01-10 19:22 ` Mark Kettenis
2025-02-25 18:18 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4FND-b-gEb6YJw6@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=kettenis@openbsd.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox