* [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
@ 2025-01-09 20:52 Mark Kettenis
2025-01-10 0:36 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Mark Kettenis @ 2025-01-09 20:52 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rajendra Nayak, Abel Vesa, Sibi Sankar
Cc: johan+linaro, Mark Kettenis, linux-arm-msm, devicetree,
linux-kernel
Make this USB controller consistent with the others on this platform.
Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
---
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 4936fa5b98ff..aad1153a443d 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -4814,6 +4814,8 @@ usb_2_dwc3: usb@a200000 {
snps,dis-u1-entry-quirk;
snps,dis-u2-entry-quirk;
+ dma-coherent;
+
ports {
#address-cells = <1>;
#size-cells = <0>;
--
2.47.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
2025-01-09 20:52 [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent Mark Kettenis
@ 2025-01-10 0:36 ` Konrad Dybcio
2025-01-10 16:38 ` Johan Hovold
2025-02-25 18:18 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2025-01-10 0:36 UTC (permalink / raw)
To: Mark Kettenis, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rajendra Nayak, Abel Vesa,
Sibi Sankar
Cc: johan+linaro, linux-arm-msm, devicetree, linux-kernel
On 9.01.2025 9:52 PM, Mark Kettenis wrote:
> Make this USB controller consistent with the others on this platform.
>
> Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
2025-01-09 20:52 [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent Mark Kettenis
2025-01-10 0:36 ` Konrad Dybcio
@ 2025-01-10 16:38 ` Johan Hovold
2025-01-10 19:22 ` Mark Kettenis
2025-02-25 18:18 ` Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Johan Hovold @ 2025-01-10 16:38 UTC (permalink / raw)
To: Mark Kettenis
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rajendra Nayak, Abel Vesa, Sibi Sankar,
johan+linaro, linux-arm-msm, devicetree, linux-kernel
On Thu, Jan 09, 2025 at 09:52:31PM +0100, Mark Kettenis wrote:
> Make this USB controller consistent with the others on this platform.
>
> Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 4936fa5b98ff..aad1153a443d 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -4814,6 +4814,8 @@ usb_2_dwc3: usb@a200000 {
> snps,dis-u1-entry-quirk;
> snps,dis-u2-entry-quirk;
>
> + dma-coherent;
> +
Can someone from Qualcomm please confirm that this is correct, and that
it's not the other way round and this property should be removed from
the other controllers (e.g. if this was just some copy-pasta from sm8550
which is the only other Qualcomm platform that claims to have
dma-coherent USB controllers).
Johan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
2025-01-10 16:38 ` Johan Hovold
@ 2025-01-10 19:22 ` Mark Kettenis
0 siblings, 0 replies; 5+ messages in thread
From: Mark Kettenis @ 2025-01-10 19:22 UTC (permalink / raw)
To: Johan Hovold
Cc: kettenis, andersson, konradybcio, robh, krzk+dt, conor+dt,
quic_rjendra, abel.vesa, quic_sibis, johan+linaro, linux-arm-msm,
devicetree, linux-kernel
> Date: Fri, 10 Jan 2025 17:38:39 +0100
> From: Johan Hovold <johan@kernel.org>
>
> On Thu, Jan 09, 2025 at 09:52:31PM +0100, Mark Kettenis wrote:
> > Make this USB controller consistent with the others on this platform.
> >
> > Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
> > Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> > ---
> > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > index 4936fa5b98ff..aad1153a443d 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > @@ -4814,6 +4814,8 @@ usb_2_dwc3: usb@a200000 {
> > snps,dis-u1-entry-quirk;
> > snps,dis-u2-entry-quirk;
> >
> > + dma-coherent;
> > +
>
> Can someone from Qualcomm please confirm that this is correct, and that
> it's not the other way round and this property should be removed from
> the other controllers (e.g. if this was just some copy-pasta from sm8550
> which is the only other Qualcomm platform that claims to have
> dma-coherent USB controllers).
It certainly wouldn't hurt to have confirmation from someone familliar
with the SoC design.
However treating the controllers as DMA coherent when they're not
would almost certainly resulted in reports of USB devices being
unreliable on these machines as the OS would skip necessary cache
flushes. I did test this patch on the ASUS Vivobook S 15 where the
microSD-card reader uses the usb_2 controller.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
2025-01-09 20:52 [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent Mark Kettenis
2025-01-10 0:36 ` Konrad Dybcio
2025-01-10 16:38 ` Johan Hovold
@ 2025-02-25 18:18 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2025-02-25 18:18 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rajendra Nayak, Abel Vesa, Sibi Sankar, Mark Kettenis
Cc: johan+linaro, linux-arm-msm, devicetree, linux-kernel
On Thu, 09 Jan 2025 21:52:31 +0100, Mark Kettenis wrote:
> Make this USB controller consistent with the others on this platform.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent
commit: 45bd6ff900cfe5038e2718a900f153ded3fa5392
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-25 18:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 20:52 [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent Mark Kettenis
2025-01-10 0:36 ` Konrad Dybcio
2025-01-10 16:38 ` Johan Hovold
2025-01-10 19:22 ` Mark Kettenis
2025-02-25 18:18 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox