Re: [PATCH 03/41] dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml

[Johan Hovold <johan@kernel.org>]

On Fri, Mar 24, 2023 at 05:24:36AM +0300, Dmitry Baryshkov wrote:
> Migrate legacy bindings (described in qcom,msm8996-qmp-ufs-phy.yaml)
> to qcom,sc8280xp-qmp-ufs-phy.yaml. This removes a need to declare
> the child PHY node or split resource regions.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../phy/qcom,msm8996-qmp-ufs-phy.yaml         | 244 ------------------
>  .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml        |  94 ++++++-
>  2 files changed, 89 insertions(+), 249 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-ufs-phy.yaml
 
>  examples:
> @@ -84,5 +150,23 @@ examples:
>          vdda-phy-supply = <&vreg_l6b>;
>          vdda-pll-supply = <&vreg_l3b>;
>  
> +        #phy-cells = <0>;
> +    };
> +  - |
> +    #include <dt-bindings/clock/qcom,rpmh.h>
> +
> +    phy@1d87000 {
> +        compatible = "qcom,sm8250-qmp-ufs-phy";
> +        reg = <0x01d87000 0x1c0>;
> +
> +        clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
> +        clock-names = "ref", "ref_aux";
> +
> +        resets = <&ufs_mem_hc 0>;
> +        reset-names = "ufsphy";
> +
> +        vdda-phy-supply = <&vreg_l6b>;
> +        vdda-pll-supply = <&vreg_l3b>;
> +
>          #phy-cells = <0>;
>      };

This example also looks unnecessary.

Johan