From: Johan Hovold <johan@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: andersson@kernel.org, yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] soundwire: qcom: update status correctly with mask
Date: Mon, 10 Jul 2023 10:17:39 +0200 [thread overview]
Message-ID: <ZKu-o0GQgh84cxZ0@hovoldconsulting.com> (raw)
In-Reply-To: <20230525133812.30841-2-srinivas.kandagatla@linaro.org>
On Thu, May 25, 2023 at 02:38:09PM +0100, Srinivas Kandagatla wrote:
> SoundWire device status can be incorrectly updated without
> proper mask, fix this by adding a mask before updating the status.
>
> Fixes: c7d49c76d1d5 ("soundwire: qcom: add support to new interrupts")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
When rebasing on 6.5-rc1, I noticed that this one was apparently never
merged along with the rest of the series.
Any idea how this could have happened?
And can we get this one into 6.5 as well?
> drivers/soundwire/qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index aad5942e5980..9440787e924b 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -515,7 +515,7 @@ static int qcom_swrm_get_alert_slave_dev_num(struct qcom_swrm_ctrl *ctrl)
> status = (val >> (dev_num * SWRM_MCP_SLV_STATUS_SZ));
>
> if ((status & SWRM_MCP_SLV_STATUS_MASK) == SDW_SLAVE_ALERT) {
> - ctrl->status[dev_num] = status;
> + ctrl->status[dev_num] = status & SWRM_MCP_SLV_STATUS_MASK;
> return dev_num;
> }
> }
Johan
next prev parent reply other threads:[~2023-07-10 8:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 13:38 [PATCH v2 0/4] soundwire: qcom: stablity fixes Srinivas Kandagatla
2023-05-25 13:38 ` [PATCH v2 1/4] soundwire: qcom: update status correctly with mask Srinivas Kandagatla
2023-07-10 8:17 ` Johan Hovold [this message]
2023-05-25 13:38 ` [PATCH v2 2/4] soundwire: qcom: wait for fifo to be empty before suspend Srinivas Kandagatla
2023-05-25 13:38 ` [PATCH v2 3/4] soundwire: qcom: add software workaround for bus clash interrupt assertion Srinivas Kandagatla
2023-05-25 13:38 ` [PATCH v2 4/4] soundwire: qcom: set clk stop need reset flag at runtime Srinivas Kandagatla
2023-05-29 5:13 ` [PATCH v2 0/4] soundwire: qcom: stablity fixes Vinod Koul
2023-06-05 9:08 ` Johan Hovold
2023-06-07 9:36 ` Srinivas Kandagatla
2023-06-08 10:11 ` Johan Hovold
2023-06-08 12:40 ` Johan Hovold
2023-06-08 12:45 ` Srinivas Kandagatla
2023-06-08 13:05 ` Johan Hovold
2023-06-08 14:23 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKu-o0GQgh84cxZ0@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox