From: Stephan Gerhold <stephan@gerhold.net>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: qcom: reset: Increase max reset delay
Date: Wed, 26 Jul 2023 20:35:01 +0200 [thread overview]
Message-ID: <ZMFmvp9UwCxpsLf7@gerhold.net> (raw)
In-Reply-To: <9ea4f4ed-8be0-859f-4f5d-d3bd0a727cb9@linaro.org>
On Wed, Jul 26, 2023 at 08:24:33PM +0200, Konrad Dybcio wrote:
> On 26.07.2023 20:21, Stephan Gerhold wrote:
> > On Wed, Jul 26, 2023 at 03:26:19PM +0200, Konrad Dybcio wrote:
> >> u8 limits us to 255 microseconds of delay. Promote the delay variable to
> >> u16 to hold bigger values.
> >>
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >
> > It would be clearer to change this together with an actual user that
> > needs > 255us. AFAICT atm MSM8909 is the only user of this and it has
> > just 15us.
> Some LPASS resets ask for 500, but I'm still working on that driver.
>
Maybe send it together with that driver then? This feels close to the
typical "no API changes without also adding the user" rule.
Thanks,
Stephan
next prev parent reply other threads:[~2023-07-26 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 13:26 [PATCH 0/2] Fix up qcom reset controller Konrad Dybcio
2023-07-26 13:26 ` [PATCH 1/2] clk: qcom: reset: Increase max reset delay Konrad Dybcio
2023-07-26 18:21 ` Stephan Gerhold
2023-07-26 18:24 ` Konrad Dybcio
2023-07-26 18:35 ` Stephan Gerhold [this message]
2023-07-26 13:26 ` [PATCH 2/2] clk: qcom: reset: Use the correct type of sleep/delay based on length Konrad Dybcio
2023-07-26 18:34 ` Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMFmvp9UwCxpsLf7@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox