From: "Otto Pflüger" <otto.pflueger@abscue.de>
To: Mark Brown <broonie@kernel.org>
Cc: "Otto Pflüger" <otto.pflueger@abscue.de>,
linux-arm-msm@vger.kernel.org,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Banajit Goswami" <bgoswami@quicinc.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/3] ASoC: qcom: q6core: expose ADSP core firmware version
Date: Mon, 16 Oct 2023 17:55:03 +0200 [thread overview]
Message-ID: <ZS1c14Z+NUmlyvFx@abscue> (raw)
In-Reply-To: <6ff78ead-fe41-496f-afdc-a83eee27f652@sirena.org.uk>
On Mon, Oct 16, 2023 at 01:47:28PM +0100, Mark Brown wrote:
> On Sat, Oct 14, 2023 at 07:26:22PM +0200, Otto Pflüger wrote:
>
> > + for (i = 0; i < g_core->svc_version->num_services; i++) {
> > + struct avcs_svc_info *info;
> > +
> > + info = &g_core->svc_version->svc_api_info[i];
> > + if (info->service_id != APR_SVC_ADSP_CORE)
> > + continue;
> > +
> > + switch (info->version) {
> > + case AVCS_CMDRSP_Q6_ID_2_6:
> > + core->adsp_version = Q6_ADSP_VERSION_2_6;
> > + break;
> > + case AVCS_CMDRSP_Q6_ID_2_7:
> > + core->adsp_version = Q6_ADSP_VERSION_2_7;
> > + break;
> > + case AVCS_CMDRSP_Q6_ID_2_8:
> > + core->adsp_version = Q6_ADSP_VERSION_2_8;
> > + break;
> > + }
>
> This doesn't handle unknown versions at all.
The adsp_version is initialized to Q6_ADSP_VERSION_UNKNOWN in
q6core_probe, so it should stay unknown if it doesn't match any of
these values. I don't see any big problems here, but I agree that some
additional handling such as a warning message could be useful.
next prev parent reply other threads:[~2023-10-16 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 17:26 [PATCH 0/3] ASoC: qcom: check ADSP version when setting clocks Otto Pflüger
2023-10-14 17:26 ` [PATCH 1/3] ASoC: qcom: q6core: expose ADSP core firmware version Otto Pflüger
2023-10-16 12:47 ` Mark Brown
2023-10-16 15:55 ` Otto Pflüger [this message]
2023-10-14 17:26 ` [PATCH 2/3] ASoC: qcom: q6afe: check ADSP version when setting clocks Otto Pflüger
2023-10-17 13:08 ` Srinivas Kandagatla
2023-10-19 17:27 ` Otto Pflüger
2023-10-14 17:26 ` [PATCH 3/3] ASoC: qcom: q6afe: remove "port already open" error Otto Pflüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS1c14Z+NUmlyvFx@abscue \
--to=otto.pflueger@abscue.de \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox