[PATCH 0/3] arm64: dts: qcom: x1e80100: Fix the data-lanes and link-frequencies

[PATCH 0/3] arm64: dts: qcom: x1e80100: Fix the data-lanes and link-frequencies

[Abel Vesa]

Both the CRD and the QCP have the data-lanes and the link-frequencies
for the DP3 in the wrong place. Both are properties of the out remote
endpoint. So move them to the mdss_dp3_out for each board.

Without these fixes, the eDP is broken on both boards.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Abel Vesa (3):
      arm64: dts: qcom: x1e80100: Drop the link-frequencies from mdss_dp3_in
      arm64: dts: qcom: x1e80100-crd: Add data-lanes and link-frequencies to DP3
      arm64: dts: qcom: x1e80100-qcp: Add data-lanes and link-frequencies to DP3

 arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 5 +++--
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 5 +++--
 arch/arm64/boot/dts/qcom/x1e80100.dtsi    | 1 -
 3 files changed, 6 insertions(+), 5 deletions(-)
---
base-commit: 4eab358930711bbeb85bf5ee267d0d42d3394c2c
change-id: 20240418-x1e80100-dts-fix-mdss-dp3-c2345ee3ee2f

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>

[PATCH 1/3] arm64: dts: qcom: x1e80100: Drop the link-frequencies from mdss_dp3_in

[Abel Vesa]

The link-frequences belong in mdss_dp3_out. Display is broken because of
this. Drop them from mdss_dp3_in.

Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index f5a3b39ae70e..0642b5e88639 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -4096,7 +4096,6 @@ port@0 {
 						mdss_dp3_in: endpoint {
 							remote-endpoint = <&mdss_intf5_out>;
 
-							link-frequencies = /bits/ 64 <8100000000>;
 						};
 					};
 

-- 
2.34.1

Re: [PATCH 1/3] arm64: dts: qcom: x1e80100: Drop the link-frequencies from mdss_dp3_in

[Konrad Dybcio]

On 18.04.2024 12:22 PM, Abel Vesa wrote:
> The link-frequences belong in mdss_dp3_out. Display is broken because of
> this. Drop them from mdss_dp3_in.
> 
> Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index f5a3b39ae70e..0642b5e88639 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -4096,7 +4096,6 @@ port@0 {
>  						mdss_dp3_in: endpoint {
>  							remote-endpoint = <&mdss_intf5_out>;
>  
> -							link-frequencies = /bits/ 64 <8100000000>;

Could you also remove the stray blank line above?

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH 1/3] arm64: dts: qcom: x1e80100: Drop the link-frequencies from mdss_dp3_in

[Bjorn Andersson]

On Thu, Apr 18, 2024 at 01:22:18PM +0300, Abel Vesa wrote:
> The link-frequences belong in mdss_dp3_out. Display is broken because of
> this. Drop them from mdss_dp3_in.
> 

Why is display broken because you have this property in the wrong node?
Isn't it broken because you don't have it in &mdss_dp3_out and this is
just a cleanup of an invalid property?

Perhaps that's what you're trying to say? Would be nice to have that
clarified.

Regards,
Bjorn

> Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index f5a3b39ae70e..0642b5e88639 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -4096,7 +4096,6 @@ port@0 {
>  						mdss_dp3_in: endpoint {
>  							remote-endpoint = <&mdss_intf5_out>;
>  
> -							link-frequencies = /bits/ 64 <8100000000>;
>  						};
>  					};
>  
> 
> -- 
> 2.34.1
> 

Re: [PATCH 1/3] arm64: dts: qcom: x1e80100: Drop the link-frequencies from mdss_dp3_in

[Abel Vesa]

On 24-04-18 08:57:37, Bjorn Andersson wrote:
> On Thu, Apr 18, 2024 at 01:22:18PM +0300, Abel Vesa wrote:
> > The link-frequences belong in mdss_dp3_out. Display is broken because of
> > this. Drop them from mdss_dp3_in.
> > 
> 
> Why is display broken because you have this property in the wrong node?
> Isn't it broken because you don't have it in &mdss_dp3_out and this is
> just a cleanup of an invalid property?
> 
> Perhaps that's what you're trying to say? Would be nice to have that
> clarified.

Will drop the "Display is broken because of this." part.

Thanks.

> 
> Regards,
> Bjorn
> 
> > Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > index f5a3b39ae70e..0642b5e88639 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > @@ -4096,7 +4096,6 @@ port@0 {
> >  						mdss_dp3_in: endpoint {
> >  							remote-endpoint = <&mdss_intf5_out>;
> >  
> > -							link-frequencies = /bits/ 64 <8100000000>;
> >  						};
> >  					};
> >  
> > 
> > -- 
> > 2.34.1
> > 

[PATCH 2/3] arm64: dts: qcom: x1e80100-crd: Add data-lanes and link-frequencies to DP3

[Abel Vesa]

The data-lanes are a property of the out remote endpoint, so move them
from mdss_dp3 to the mdss_dp3_out. Also add the link-frequencies to
mdss_dp3_out and make sure to include all frequencies.

Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
index d4198fa204fd..c5c2895b37c7 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
@@ -599,8 +599,6 @@ &mdss_dp3 {
 	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
-	data-lanes = <0 1 2 3>;
-
 	status = "okay";
 
 	aux-bus {
@@ -620,6 +618,9 @@ ports {
 		port@1 {
 			reg = <1>;
 			mdss_dp3_out: endpoint {
+				data-lanes = <0 1 2 3>;
+				link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+
 				remote-endpoint = <&edp_panel_in>;
 			};
 		};

-- 
2.34.1

Re: [PATCH 2/3] arm64: dts: qcom: x1e80100-crd: Add data-lanes and link-frequencies to DP3

[Konrad Dybcio]

On 18.04.2024 12:22 PM, Abel Vesa wrote:
> The data-lanes are a property of the out remote endpoint, so move them
> from mdss_dp3 to the mdss_dp3_out. Also add the link-frequencies to
> mdss_dp3_out and make sure to include all frequencies.
> 
> Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

[PATCH 3/3] arm64: dts: qcom: x1e80100-qcp: Add data-lanes and link-frequencies to DP3

[Abel Vesa]

The data-lanes are a property of the out remote endpoint, so move them
from mdss_dp3 to the mdss_dp3_out. Also add the link-frequencies to
mdss_dp3_out and make sure to include all frequencies.

Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 35580ac3430d..2061fbe7b75a 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -410,8 +410,6 @@ &mdss_dp3 {
 	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
-	data-lanes = <0 1 2 3>;
-
 	status = "okay";
 
 	aux-bus {
@@ -431,6 +429,9 @@ ports {
 		port@1 {
 			reg = <1>;
 			mdss_dp3_out: endpoint {
+				data-lanes = <0 1 2 3>;
+				link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+
 				remote-endpoint = <&edp_panel_in>;
 			};
 		};

-- 
2.34.1

Re: [PATCH 3/3] arm64: dts: qcom: x1e80100-qcp: Add data-lanes and link-frequencies to DP3

[Konrad Dybcio]

On 18.04.2024 12:22 PM, Abel Vesa wrote:
> The data-lanes are a property of the out remote endpoint, so move them
> from mdss_dp3 to the mdss_dp3_out. Also add the link-frequencies to
> mdss_dp3_out and make sure to include all frequencies.
> 
> Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad