From: Johan Hovold <johan@kernel.org>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com,
ulf.hansson@linaro.org, jassisinghbrar@gmail.com,
linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, konradybcio@kernel.org,
linux-pm@vger.kernel.org, tstrudel@google.com, rafael@kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH V3 1/4] firmware: arm_scmi: Ensure that the message-id supports fastchannel
Date: Thu, 10 Oct 2024 16:55:48 +0200 [thread overview]
Message-ID: <Zwfq9KYi04QkZBp1@hovoldconsulting.com> (raw)
In-Reply-To: <20241007060642.1978049-2-quic_sibis@quicinc.com>
On Mon, Oct 07, 2024 at 11:36:39AM +0530, Sibi Sankar wrote:
> Currently the perf and powercap protocol relies on the protocol domain
> attributes, which just ensures that one fastchannel per domain, before
> instantiating fastchannels for all possible message-ids. Fix this by
> ensuring that each message-id supports fastchannel before initialization.
Perhaps you could include the error message I reported here so that
anyone searching for that error will find this fix more easily.
> Reported-by: Johan Hovold <johan+linaro@kernel.org>
> Closes: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/
> Fixes: 6f9ea4dabd2d ("firmware: arm_scmi: Generalize the fast channel support")
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Do we want this to be backported as well so that you should add a
CC-stable tag?
Either way, this does seem to address the FC errors I reported:
Tested-by: Johan Hovold <johan+linaro@kernel.org>
Johan
next prev parent reply other threads:[~2024-10-10 14:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 6:06 [PATCH V3 0/4] firmware: arm_scmi: Misc Fixes Sibi Sankar
2024-10-07 6:06 ` [PATCH V3 1/4] firmware: arm_scmi: Ensure that the message-id supports fastchannel Sibi Sankar
2024-10-09 13:46 ` Sudeep Holla
2024-10-10 14:55 ` Johan Hovold [this message]
2024-10-07 6:06 ` [PATCH V3 2/4] firmware: arm_scmi: Skip adding bad duplicates Sibi Sankar
2024-10-07 6:06 ` [PATCH V3 3/4] pmdomain: core: Fix debugfs node creation failure Sibi Sankar
2024-10-07 17:33 ` Dmitry Baryshkov
2024-10-09 11:11 ` Ulf Hansson
2024-10-10 12:47 ` Dmitry Baryshkov
2024-10-07 6:06 ` [PATCH V3 4/4] mailbox: qcom-cpucp: Mark the irq with IRQF_NO_SUSPEND flag Sibi Sankar
2024-10-07 13:14 ` Konrad Dybcio
2024-10-10 14:58 ` Johan Hovold
2024-10-09 11:14 ` [PATCH V3 0/4] firmware: arm_scmi: Misc Fixes Ulf Hansson
2024-10-10 15:02 ` Johan Hovold
2024-10-23 7:46 ` Sibi Sankar
2024-10-23 16:26 ` Johan Hovold
2024-10-25 6:08 ` Sibi Sankar
2024-10-25 6:14 ` Dmitry Baryshkov
2024-10-25 6:45 ` Sibi Sankar
2024-10-25 8:28 ` Cristian Marussi
2024-10-25 10:11 ` Dmitry Baryshkov
2024-10-25 10:29 ` Cristian Marussi
2024-10-25 11:37 ` Dmitry Baryshkov
2024-10-25 13:32 ` Johan Hovold
2024-10-25 13:48 ` Cristian Marussi
2024-10-25 13:23 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zwfq9KYi04QkZBp1@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tstrudel@google.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox