From: Johan Hovold <johan@kernel.org>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
sudeep.holla@arm.com, ulf.hansson@linaro.org,
jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, konradybcio@kernel.org,
linux-pm@vger.kernel.org, tstrudel@google.com, rafael@kernel.org
Subject: Re: [PATCH V3 0/4] firmware: arm_scmi: Misc Fixes
Date: Fri, 25 Oct 2024 15:32:53 +0200 [thread overview]
Message-ID: <ZxueBWB9nJ9Mt7bW@hovoldconsulting.com> (raw)
In-Reply-To: <Zxty8VaMPrU3fJAN@pluto>
On Fri, Oct 25, 2024 at 11:29:05AM +0100, Cristian Marussi wrote:
> > > >>> [ 8.098452] arm-scmi arm-scmi.0.auto: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16
> > > >>> [ 8.109647] arm-scmi arm-scmi.0.auto: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16
> > > >>> [ 8.128970] arm-scmi arm-scmi.0.auto: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16
> > > >>> [ 8.142455] arm-scmi arm-scmi.0.auto: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16
> I think dev_info could be an option from the SCMI perspective (as per my
> other mail), the important thing in these regards is to NOT go
> completely silent against fw anomalies...to avoid the the risk of being
> silently ignored .... I'll see what Sudeep thinks about...
I agree.
But could the error handling be improved to look less scary for an end
user by saying something about duplicate entries being ignored instead
perhaps?
Printing something at info level and with a FW_BUG ("[Firmware Bug]: ")
prefix as was done here:
https://lore.kernel.org/all/20230414084619.31524-1-johan+linaro@kernel.org/
should make it clear that this is not something for end users to worry
(too much) about.
Johan
next prev parent reply other threads:[~2024-10-25 13:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 6:06 [PATCH V3 0/4] firmware: arm_scmi: Misc Fixes Sibi Sankar
2024-10-07 6:06 ` [PATCH V3 1/4] firmware: arm_scmi: Ensure that the message-id supports fastchannel Sibi Sankar
2024-10-09 13:46 ` Sudeep Holla
2024-10-10 14:55 ` Johan Hovold
2024-10-07 6:06 ` [PATCH V3 2/4] firmware: arm_scmi: Skip adding bad duplicates Sibi Sankar
2024-10-07 6:06 ` [PATCH V3 3/4] pmdomain: core: Fix debugfs node creation failure Sibi Sankar
2024-10-07 17:33 ` Dmitry Baryshkov
2024-10-09 11:11 ` Ulf Hansson
2024-10-10 12:47 ` Dmitry Baryshkov
2024-10-07 6:06 ` [PATCH V3 4/4] mailbox: qcom-cpucp: Mark the irq with IRQF_NO_SUSPEND flag Sibi Sankar
2024-10-07 13:14 ` Konrad Dybcio
2024-10-10 14:58 ` Johan Hovold
2024-10-09 11:14 ` [PATCH V3 0/4] firmware: arm_scmi: Misc Fixes Ulf Hansson
2024-10-10 15:02 ` Johan Hovold
2024-10-23 7:46 ` Sibi Sankar
2024-10-23 16:26 ` Johan Hovold
2024-10-25 6:08 ` Sibi Sankar
2024-10-25 6:14 ` Dmitry Baryshkov
2024-10-25 6:45 ` Sibi Sankar
2024-10-25 8:28 ` Cristian Marussi
2024-10-25 10:11 ` Dmitry Baryshkov
2024-10-25 10:29 ` Cristian Marussi
2024-10-25 11:37 ` Dmitry Baryshkov
2024-10-25 13:32 ` Johan Hovold [this message]
2024-10-25 13:48 ` Cristian Marussi
2024-10-25 13:23 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxueBWB9nJ9Mt7bW@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tstrudel@google.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox