Re: [PATCH 4/5] arm64: dts: qcom: Add support for QCS9075 RB8

[Wasim Nazir <quic_wasimn@quicinc.com>]

On Fri, Nov 15, 2024 at 06:05:20PM +0200, Dmitry Baryshkov wrote:
> On Sun, Nov 10, 2024 at 08:23:38PM +0530, Wasim Nazir wrote:
> > Add device tree support for the QCS9075-RB8 board.
> > 
> > Basic changes are supported for boot to shell.
> > 
> > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile        |   1 +
> >  arch/arm64/boot/dts/qcom/qcs9075-rb8.dts | 287 +++++++++++++++++++++++
> >  2 files changed, 288 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-rb8.dts
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 9bb8b191aeb5..5d9847119f2e 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -115,6 +115,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= qcs404-evb-1000.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= qcs404-evb-4000.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= qcs6490-rb3gen2.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= qcs8550-aim300-aiot.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)	+= qcs9075-rb8.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= qcs9100-ride.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= qcs9100-ride-r3.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= qdu1000-idp.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-rb8.dts b/arch/arm64/boot/dts/qcom/qcs9075-rb8.dts
> > new file mode 100644
> > index 000000000000..8d4a27a8f371
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/qcs9075-rb8.dts
> > +
> > +&tlmm {
> > +	/* FIXME: mdss0_dp0 is dependent on this so adding a dummy node for now */
> > +	dp_hot_plug_det: dp-hot-plug-det-state {};
> > +
> > +	/* FIXME: mdss0_dp1 is dependent on this so adding a dummy node for now */
> > +	dp1_hot_plug_det: dp1-hot-plug-det-state {};
> 
> I don't see these two being used in the MDSS node. Please drop.
Thanks for pointing it out, will drop in next series.
> 
> LGTM otherwise.
> 
> > +
> > +	qup_uart10_default: qup-uart10-state {
> > +		pins = "gpio46", "gpio47";
> > +		function = "qup1_se3";
> > +	};
> > +};
> 
> -- 
> With best wishes
> Dmitry

Regards,
Wasim