From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, benl@squareup.com,
shawn.guo@linaro.org, fabien.parent@linaro.org,
leo.yan@linaro.org, dmitry.baryshkov@linaro.org,
Jun Nie <jun.nie@linaro.org>,
James Willcox <jwillcox@squareup.com>,
Joseph Gates <jgates@squareup.com>, Max Chen <mchen@squareup.com>,
Zac Crosby <zac@squareup.com>,
Vincent Knecht <vincent.knecht@mailoo.org>
Subject: Re: [PATCH v7 2/5] arm64: dts: qcom: Add msm8939 SoC
Date: Mon, 6 Mar 2023 15:25:50 +0000 [thread overview]
Message-ID: <a041186e-fd7d-0bd2-eb67-8e6000b50c32@linaro.org> (raw)
In-Reply-To: <ZAYA4cdlpIfjdqt2@gerhold.net>
On 06/03/2023 15:04, Stephan Gerhold wrote:
> Hi Bryan,
>
> Thanks for making the changes. I only have some minor nitpicks now:
>> +
>> + tsens_base1: base1@a0 {
>> + reg = <0xa0 0x1>;
>> + bits = <0 8>;
>> + };
>> +
>> + tsens_s5_p1: s5-p1@a1 {
>> + reg = <0xa1 0x1>;
>> + bits = <0 6>;
>> + };
>> [...]
>> + tsens: thermal-sensor@4a9000 {
>> + compatible = "qcom,msm8939-tsens", "qcom,tsens-v0_1";
>> + reg = <0x004a9000 0x1000>, /* TM */
>> + <0x004a8000 0x1000>; /* SROT */
>> + nvmem-cells = <&tsens_mode>,
>> + <&tsens_base1>, <&tsens_base2>,
>> + <&tsens_s0_p1>, <&tsens_s0_p2>,
>> + <&tsens_s1_p1>, <&tsens_s1_p2>,
>> + <&tsens_s2_p1>, <&tsens_s2_p2>,
>> + <&tsens_s3_p1>, <&tsens_s3_p2>,
>> + <&tsens_s4_p1>, <&tsens_s4_p2>,
>> + <&tsens_s4_p1>, <&tsens_s4_p2>,
>> + <&tsens_s5_p1>, <&tsens_s5_p2>,
>> + <&tsens_s6_p1>, <&tsens_s6_p2>,
>> + <&tsens_s7_p1>, <&tsens_s7_p2>,
>> + <&tsens_s8_p1>, <&tsens_s8_p2>;
>> + nvmem-cell-names = "mode",
>> + "base1", "base2",
>> + "s0_p1", "s0_p2",
>> + "s1_p1", "s1_p2",
>> + "s2_p1", "s2_p2",
>> + "s3_p1", "s3_p2",
>> + "s4_p1", "s4_p2",
>> + "s4_p1", "s4_p2",
>
> s4_p1/p2 are specified twice, is this on purpose or accidental?
On purpose I believe.
@Dmitry ?
>
>> + "s5_p1", "s5_p2",
>> + "s6_p1", "s6_p2",
>> + "s7_p1", "s7_p2",
>> + "s8_p1", "s8_p2";
>> + #qcom,sensors = <9>;
>> + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "uplow";
>> + #thermal-sensor-cells = <1>;
>> + };
>> [...]
>> + usb: usb@78d9000 {
>> + compatible = "qcom,ci-hdrc";
>> + reg = <0x078d9000 0x200>,
>> + <0x078d9200 0x200>;
>> + interrupts = <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&gcc GCC_USB_HS_AHB_CLK>,
>> + <&gcc GCC_USB_HS_SYSTEM_CLK>;
>> + clock-names = "iface", "core";
>> + assigned-clocks = <&gcc GCC_USB_HS_SYSTEM_CLK>;
>> + assigned-clock-rates = <80000000>;
>> + resets = <&gcc GCC_USB_HS_BCR>;
>> + reset-names = "core";
>> + #reset-cells = <1>;
>> + phy_type = "ulpi";
>> + dr_mode = "otg";
>
> Please add
>
> hnp-disable;
> srp-disable;
> adp-disable;
>
> here for consistency with msm8916.dtsi. These are needed for correct
> behavior if you enable CONFIG_USB_OTG_FSM, see commit bfd5d21abcd5c
> ("arm64: dts: qcom: msm8916: Move common USB properties to msm8916.dtsi")
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bfd5d21abcd5c7941ad79b594f5f42e27496eb28
>
Hmm, I haven't noticed any problems with OTG - then again, I'm looking
at my kernel config and +# CONFIG_USB_OTG_FSM is not set
next prev parent reply other threads:[~2023-03-06 15:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 15:36 [PATCH v7 0/5] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-02-23 15:36 ` [PATCH v7 1/5] dt-bindings: vendor-prefixes: Add Square Bryan O'Donoghue
2023-02-23 15:36 ` [PATCH v7 2/5] arm64: dts: qcom: Add msm8939 SoC Bryan O'Donoghue
2023-02-23 15:43 ` Konrad Dybcio
2023-03-06 15:04 ` Stephan Gerhold
2023-03-06 15:25 ` Bryan O'Donoghue [this message]
2023-02-23 15:36 ` [PATCH v7 3/5] arm64: dts: qcom: Add msm8939-pm8916.dtsi include Bryan O'Donoghue
2023-02-23 15:36 ` [PATCH v7 4/5] arm64: dts: qcom: Add Square apq8039-t2 board Bryan O'Donoghue
2023-03-06 15:47 ` Stephan Gerhold
2023-02-23 15:36 ` [PATCH v7 5/5] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
2023-03-06 16:14 ` Stephan Gerhold
2023-03-06 22:56 ` Bryan O'Donoghue
2023-06-15 20:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a041186e-fd7d-0bd2-eb67-8e6000b50c32@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benl@squareup.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabien.parent@linaro.org \
--cc=jgates@squareup.com \
--cc=jun.nie@linaro.org \
--cc=jwillcox@squareup.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchen@squareup.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stephan@gerhold.net \
--cc=vincent.knecht@mailoo.org \
--cc=zac@squareup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox