From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, benl@squareup.com,
shawn.guo@linaro.org, fabien.parent@linaro.org,
leo.yan@linaro.org, dmitry.baryshkov@linaro.org
Subject: Re: [PATCH v7 5/5] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua
Date: Mon, 6 Mar 2023 22:56:26 +0000 [thread overview]
Message-ID: <f4b3d8b1-bbe5-2c47-46a9-a33ebec2492f@linaro.org> (raw)
In-Reply-To: <ZAYRUIg0SwKOnBGx@gerhold.net>
On 06/03/2023 16:14, Stephan Gerhold wrote:
> There are*a lot* of unused pinctrl entries here. If you don't reference
> them anywhere (by referencing them via label) they just waste space in
> the device tree. The GPIOs will still remain unconfigured.
>
> Please save them locally for later usage and only keep the used entries.
> This will ease review of upcoming patches since these are better
> understandable together with the actual device node making use of them.
TBH, I really would have rather received this comment @ version 1,
before doing all the work to sanitise the incoming downstream DTS.
But sure, no problem, I'll drop.
---
bod
next prev parent reply other threads:[~2023-03-06 22:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 15:36 [PATCH v7 0/5] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-02-23 15:36 ` [PATCH v7 1/5] dt-bindings: vendor-prefixes: Add Square Bryan O'Donoghue
2023-02-23 15:36 ` [PATCH v7 2/5] arm64: dts: qcom: Add msm8939 SoC Bryan O'Donoghue
2023-02-23 15:43 ` Konrad Dybcio
2023-03-06 15:04 ` Stephan Gerhold
2023-03-06 15:25 ` Bryan O'Donoghue
2023-02-23 15:36 ` [PATCH v7 3/5] arm64: dts: qcom: Add msm8939-pm8916.dtsi include Bryan O'Donoghue
2023-02-23 15:36 ` [PATCH v7 4/5] arm64: dts: qcom: Add Square apq8039-t2 board Bryan O'Donoghue
2023-03-06 15:47 ` Stephan Gerhold
2023-02-23 15:36 ` [PATCH v7 5/5] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
2023-03-06 16:14 ` Stephan Gerhold
2023-03-06 22:56 ` Bryan O'Donoghue [this message]
2023-06-15 20:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4b3d8b1-bbe5-2c47-46a9-a33ebec2492f@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benl@squareup.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabien.parent@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox