* [PATCH] phy: qcom-qmp: Fix register name in RX Lane config of SC8280XP
@ 2024-11-12 9:28 Krishna Kurapati
2024-11-12 11:11 ` Konrad Dybcio
2024-12-08 16:58 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Krishna Kurapati @ 2024-11-12 9:28 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Bjorn Andersson,
Konrad Dybcio, Dmitry Baryshkov, Mantas Pucka, Abel Vesa,
Komal Bajaj
Cc: linux-kernel, linux-arm-msm, linux-phy, quic_ppratap, quic_jackp,
Krishna Kurapati, stable
In RX Lane configuration sequence of SC8280XP, the register
V5_RX_UCDR_FO_GAIN is incorrectly spelled as RX_UCDR_SO_GAIN and
hence the programming sequence is wrong. Fix the register sequence
accordingly to avoid any compliance failures. This has been tested
on SA8775P by checking device mode enumeration in SuperSpeed.
Cc: <stable@vger.kernel.org>
Fixes: c0c7769cdae2 ("phy: qcom-qmp: Add SC8280XP USB3 UNI phy")
Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
---
drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index acd6075bf6d9..c9c337840715 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
@@ -1052,7 +1052,7 @@ static const struct qmp_phy_init_tbl sc8280xp_usb3_uniphy_rx_tbl[] = {
QMP_PHY_INIT_CFG(QSERDES_V5_RX_UCDR_FASTLOCK_FO_GAIN, 0x2f),
QMP_PHY_INIT_CFG(QSERDES_V5_RX_UCDR_FASTLOCK_COUNT_LOW, 0xff),
QMP_PHY_INIT_CFG(QSERDES_V5_RX_UCDR_FASTLOCK_COUNT_HIGH, 0x0f),
- QMP_PHY_INIT_CFG(QSERDES_V5_RX_UCDR_SO_GAIN, 0x0a),
+ QMP_PHY_INIT_CFG(QSERDES_V5_RX_UCDR_FO_GAIN, 0x0a),
QMP_PHY_INIT_CFG(QSERDES_V5_RX_VGA_CAL_CNTRL1, 0x54),
QMP_PHY_INIT_CFG(QSERDES_V5_RX_VGA_CAL_CNTRL2, 0x0f),
QMP_PHY_INIT_CFG(QSERDES_V5_RX_RX_EQU_ADAPTOR_CNTRL2, 0x0f),
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] phy: qcom-qmp: Fix register name in RX Lane config of SC8280XP
2024-11-12 9:28 [PATCH] phy: qcom-qmp: Fix register name in RX Lane config of SC8280XP Krishna Kurapati
@ 2024-11-12 11:11 ` Konrad Dybcio
2024-12-08 16:58 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-11-12 11:11 UTC (permalink / raw)
To: Krishna Kurapati, Vinod Koul, Kishon Vijay Abraham I,
Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov, Mantas Pucka,
Abel Vesa, Komal Bajaj
Cc: linux-kernel, linux-arm-msm, linux-phy, quic_ppratap, quic_jackp,
stable
On 12-Nov-24 10:28, Krishna Kurapati wrote:
> In RX Lane configuration sequence of SC8280XP, the register
> V5_RX_UCDR_FO_GAIN is incorrectly spelled as RX_UCDR_SO_GAIN and
> hence the programming sequence is wrong. Fix the register sequence
> accordingly to avoid any compliance failures. This has been tested
> on SA8775P by checking device mode enumeration in SuperSpeed.
>
> Cc: <stable@vger.kernel.org>
> Fixes: c0c7769cdae2 ("phy: qcom-qmp: Add SC8280XP USB3 UNI phy")
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> ---
Good catch!
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] phy: qcom-qmp: Fix register name in RX Lane config of SC8280XP
2024-11-12 9:28 [PATCH] phy: qcom-qmp: Fix register name in RX Lane config of SC8280XP Krishna Kurapati
2024-11-12 11:11 ` Konrad Dybcio
@ 2024-12-08 16:58 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-12-08 16:58 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Bjorn Andersson, Konrad Dybcio,
Dmitry Baryshkov, Mantas Pucka, Abel Vesa, Komal Bajaj,
Krishna Kurapati
Cc: linux-kernel, linux-arm-msm, linux-phy, quic_ppratap, quic_jackp,
stable
On Tue, 12 Nov 2024 14:58:31 +0530, Krishna Kurapati wrote:
> In RX Lane configuration sequence of SC8280XP, the register
> V5_RX_UCDR_FO_GAIN is incorrectly spelled as RX_UCDR_SO_GAIN and
> hence the programming sequence is wrong. Fix the register sequence
> accordingly to avoid any compliance failures. This has been tested
> on SA8775P by checking device mode enumeration in SuperSpeed.
>
>
> [...]
Applied, thanks!
[1/1] phy: qcom-qmp: Fix register name in RX Lane config of SC8280XP
commit: 8886fb3240931a0afce82dea87edfe46bcb0a586
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-08 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 9:28 [PATCH] phy: qcom-qmp: Fix register name in RX Lane config of SC8280XP Krishna Kurapati
2024-11-12 11:11 ` Konrad Dybcio
2024-12-08 16:58 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox