Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Gokul Sriram P <quic_gokulsri@quicinc.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>,
	<manivannan.sadhasivam@linaro.org>, <mhi@lists.linux.dev>,
	<linux-arm-msm@vger.kernel.org>
Cc: <quic_srichara@quicinc.com>, <quic_viswanat@quicinc.com>,
	<quic_gokulsri@quiconc.com>
Subject: Re: [PATCH 6/6] bus: mhi: change IRQ_HANDLED to IRQ_NONE in mhi_irq_handler
Date: Sun, 28 Jul 2024 19:11:33 +0530	[thread overview]
Message-ID: <a339e951-173e-46ce-9227-75464958cbdd@quicinc.com> (raw)
In-Reply-To: <687ba571-b2ab-0205-fa12-e766e72dfb73@quicinc.com>


On 7/18/2024 9:59 PM, Jeffrey Hugo wrote:
> On 7/18/2024 12:13 AM, Gokul Sriram Palanisamy wrote:
>> From: Karthick Shanmugham <quic_kartshan@quicinc.com>
>>
>> When mhi_irq_handler is a shared interrupt handler. It is the shared
>> interrupt handlers responsibility to identify its own interrupt and exit
>> quickly if it is not. If there is no pending event in the event ring
>> handled, exit the interrupt context returning IRQ_NONE denoting the
>> interrupt either doesn't belong to this event ring or not handled.
>
> How was this found?

Internally, the proprietary cnss drivers shares the same msi interrupt 
for streaming certain debug information.

In that scenario, the interrupt didn't reach the corresponding shared 
handler since the mhi_irq_handler( ) returned IRQ_HANDLED when there is 
actually no pending mhi event.

This resulted in debug information not collected.

Regards,

Gokul


  reply	other threads:[~2024-07-28 13:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18  6:13 [PATCH 0/6] add improvements to mhi driver Gokul Sriram Palanisamy
2024-07-18  6:13 ` [PATCH 1/6] drivers: bus: mhi: Added shared-dma-pool support for mhi_dev Gokul Sriram Palanisamy
2024-07-18 16:17   ` Jeffrey Hugo
2024-07-28 13:41     ` Gokul Sriram P
2024-07-18  6:13 ` [PATCH 2/6] bus: mhi: add support to allocate rddm memory during crash time Gokul Sriram Palanisamy
2024-07-18 16:22   ` Jeffrey Hugo
2024-07-28 13:40     ` Gokul Sriram P
2024-07-28 20:21       ` Jeffrey Hugo
2024-07-18  6:13 ` [PATCH 3/6] bus: mhi: increase RDDM timeout Gokul Sriram Palanisamy
2024-07-18 16:23   ` Jeffrey Hugo
2024-07-28 13:41     ` Gokul Sriram P
2024-07-28 20:24       ` Jeffrey Hugo
2024-07-18  6:13 ` [PATCH 4/6] bus: mhi: dump debug registers in critical sections Gokul Sriram Palanisamy
2024-07-18 16:25   ` Jeffrey Hugo
2024-07-29  5:47     ` Gokul Sriram P
2024-07-29 14:13       ` Jeffrey Hugo
2024-07-18  6:13 ` [PATCH 5/6] bus: mhi: check for RDDM cookie set by device to indicate readiness Gokul Sriram Palanisamy
2024-07-18 16:25   ` Jeffrey Hugo
2024-07-28 13:41     ` Gokul Sriram P
2024-07-28 20:27       ` Jeffrey Hugo
2024-07-18  6:13 ` [PATCH 6/6] bus: mhi: change IRQ_HANDLED to IRQ_NONE in mhi_irq_handler Gokul Sriram Palanisamy
2024-07-18 16:29   ` Jeffrey Hugo
2024-07-28 13:41     ` Gokul Sriram P [this message]
2024-07-28 20:29       ` Jeffrey Hugo
2024-07-18 16:30 ` [PATCH 0/6] add improvements to mhi driver Jeffrey Hugo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a339e951-173e-46ce-9227-75464958cbdd@quicinc.com \
    --to=quic_gokulsri@quicinc.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mhi@lists.linux.dev \
    --cc=quic_gokulsri@quiconc.com \
    --cc=quic_jhugo@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_viswanat@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox