Re: [PATCH 4/6] bus: mhi: dump debug registers in critical sections

[Jeffrey Hugo <quic_jhugo@quicinc.com>]

On 7/28/2024 11:47 PM, Gokul Sriram P wrote:
> 
> On 7/18/2024 9:55 PM, Jeffrey Hugo wrote:
>> On 7/18/2024 12:13 AM, Gokul Sriram Palanisamy wrote:
>>> --- a/include/linux/mhi.h
>>> +++ b/include/linux/mhi.h
>>> @@ -834,4 +834,9 @@ bool mhi_queue_is_full(struct mhi_device 
>>> *mhi_dev, enum dma_data_direction dir);
>>>    */
>>>   int mhi_get_channel_doorbell_offset(struct mhi_controller 
>>> *mhi_cntrl, u32 *chdb_offset);
>>>   +/**
>>> + * mhi_debug_reg_dump - dump MHI registers for debug purpose
>>> + * @mhi_cntrl: MHI controller
>>> + */
>>> +void mhi_debug_reg_dump(struct mhi_controller *mhi_cntrl);
>>>   #endif /* _MHI_H_ */
>>
>> NACK.  This is not used.
> mhi_debug_reg_dump - this is added in 3 places, mhi_fw_load_bhi( ), 
> mhi_fw_load_bhie( ) and mhi_download_rddm_image( ) to print error codes 
> on failure scenarios.

You add this to the MHI API and export it as a symbol.  Nothing outside 
MHI uses this.