* [PATCH v4] media: dt-bindings: Correct camss supply description
@ 2025-12-22 14:16 David Heidelberg via B4 Relay
2025-12-22 15:35 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-12-22 14:16 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Vladimir Zapolskiy, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Vikram Sharma, Kapatrala Syed,
Hariram Purushothaman, Richard Acayan, Bryan O'Donoghue,
Hans Verkuil, Depeng Shao
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, phone-devel,
David Heidelberg
From: David Heidelberg <david@ixit.cz>
Usually, the supply is around 1.2 V, not 1.8 V, and also correct wording.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Eventually, if more changes would be requested, would make sense someone
from Qualcomm to follow-up on these, as I don't have schematics,
documentation or also no access to the internal resources.
Thank you
---
Changes in v4:
- Everything in one commit. (Krzysztof)
- Dropped Fixes tag. (Bryan)
- Updated rest of the files to make them in sync.
- Link to v3: https://lore.kernel.org/r/20251216-docs-camss-fixes-v3-0-c238b6810771@ixit.cz
Changes in v3:
- Add commit improving vdda-phy-supply description to match more recent
bindings.
- Double-checked and specified it's 1.2 V vdda-pll-supply. (Vladimir)
- Link to v2: https://lore.kernel.org/r/20251213-docs-camss-fixes-v2-1-a8a4d4d51c6c@ixit.cz
Changes in v2:
- Applied suggestion to clarify the description. (Krzysztof)
- Link to v1: https://lore.kernel.org/r/20251212-docs-camss-fixes-v1-1-5c011505ff59@ixit.cz
---
Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml | 4 ++--
Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml | 4 ++--
Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 4 ++--
Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml | 4 ++--
Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 4 ++--
Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml | 4 ++--
Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml | 4 ++--
Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml | 4 ++--
8 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
index 019caa2b09c32..48f280e998096 100644
--- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
@@ -126,11 +126,11 @@ properties:
vdda-phy-supply:
description:
- Phandle to a regulator supply to PHY core block.
+ 0.88V supply to CSIPHY IP blocks.
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ 1.2V supply to CSIPHY IP blocks.
ports:
$ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
index ee35e3bc97ffd..b1c54c5b01b28 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
@@ -125,11 +125,11 @@ properties:
vdda-phy-supply:
description:
- Phandle to a regulator supply to PHY core block.
+ 0.88V supply to CSIPHY IP blocks.
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ 1.2V supply to CSIPHY IP blocks.
ports:
$ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
index c99fe4106eee9..354130aba9fc9 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
@@ -264,11 +264,11 @@ properties:
vdda-phy-supply:
description:
- Phandle to a regulator supply to PHY core block.
+ 0.88V supply to CSIPHY IP blocks.
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ 1.2V supply to CSIPHY IP blocks.
required:
- clock-names
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
index 35c40fe223767..46cc7fff15992 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
@@ -91,11 +91,11 @@ properties:
vdda-phy-supply:
description:
- Phandle to a regulator supply to PHY core block.
+ 0.88V supply to CSIPHY IP blocks.
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ 1.2V supply to CSIPHY IP blocks.
ports:
$ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index 82bf4689d3300..be09cf3a3b3b8 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -207,11 +207,11 @@ properties:
vdda-phy-supply:
description:
- Phandle to a regulator supply to PHY core block.
+ 0.88V supply to CSIPHY IP blocks.
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ 1.2V supply to CSIPHY IP blocks.
required:
- clock-names
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
index ebf68ff4ab961..a509d4bbcb4aa 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
@@ -296,11 +296,11 @@ properties:
vdda-phy-supply:
description:
- Phandle to a regulator supply to PHY core block.
+ 0.88V supply to CSIPHY IP blocks.
vdda-pll-supply:
description:
- Phandle to 1.8V regulator supply to PHY refclk pll block.
+ 1.2V supply to CSIPHY IP blocks.
required:
- clock-names
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
index cd34f14916b42..4b9ab1352e914 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
@@ -134,11 +134,11 @@ properties:
vdda-phy-supply:
description:
- Phandle to a regulator supply to PHY core block.
+ 0.88V supply to CSIPHY IP blocks.
vdda-pll-supply:
description:
- Phandle to 1.2V regulator supply to PHY refclk pll block.
+ 1.2V supply to CSIPHY IP blocks.
ports:
$ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
index b87a13479a4bf..2d1662ef522b7 100644
--- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
@@ -120,11 +120,11 @@ properties:
vdd-csiphy-0p8-supply:
description:
- Phandle to a 0.8V regulator supply to a PHY.
+ 0.8V supply to a PHY.
vdd-csiphy-1p2-supply:
description:
- Phandle to 1.2V regulator supply to a PHY.
+ 1.2V supply to a PHY.
ports:
$ref: /schemas/graph.yaml#/properties/ports
---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20251212-docs-camss-fixes-0fa525271951
Best regards,
--
David Heidelberg <david@ixit.cz>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4] media: dt-bindings: Correct camss supply description
2025-12-22 14:16 [PATCH v4] media: dt-bindings: Correct camss supply description David Heidelberg via B4 Relay
@ 2025-12-22 15:35 ` Krzysztof Kozlowski
2025-12-22 15:46 ` Vladimir Zapolskiy
2025-12-22 15:50 ` Bryan O'Donoghue
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-22 15:35 UTC (permalink / raw)
To: david, Robert Foss, Todor Tomov, Bryan O'Donoghue,
Vladimir Zapolskiy, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Vikram Sharma, Kapatrala Syed,
Hariram Purushothaman, Richard Acayan, Bryan O'Donoghue,
Hans Verkuil, Depeng Shao
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, phone-devel
On 22/12/2025 15:16, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Usually, the supply is around 1.2 V, not 1.8 V, and also correct wording.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] media: dt-bindings: Correct camss supply description
2025-12-22 14:16 [PATCH v4] media: dt-bindings: Correct camss supply description David Heidelberg via B4 Relay
2025-12-22 15:35 ` Krzysztof Kozlowski
@ 2025-12-22 15:46 ` Vladimir Zapolskiy
2025-12-22 15:50 ` Bryan O'Donoghue
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2025-12-22 15:46 UTC (permalink / raw)
To: david, Robert Foss, Todor Tomov, Bryan O'Donoghue,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Vikram Sharma, Kapatrala Syed,
Hariram Purushothaman, Richard Acayan, Bryan O'Donoghue,
Hans Verkuil, Depeng Shao
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, phone-devel
On 12/22/25 16:16, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Usually, the supply is around 1.2 V, not 1.8 V, and also correct wording.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Eventually, if more changes would be requested, would make sense someone
> from Qualcomm to follow-up on these, as I don't have schematics,
> documentation or also no access to the internal resources.
>
> Thank you
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] media: dt-bindings: Correct camss supply description
2025-12-22 14:16 [PATCH v4] media: dt-bindings: Correct camss supply description David Heidelberg via B4 Relay
2025-12-22 15:35 ` Krzysztof Kozlowski
2025-12-22 15:46 ` Vladimir Zapolskiy
@ 2025-12-22 15:50 ` Bryan O'Donoghue
2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2025-12-22 15:50 UTC (permalink / raw)
To: david, Robert Foss, Todor Tomov, Vladimir Zapolskiy,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Vikram Sharma, Kapatrala Syed,
Hariram Purushothaman, Richard Acayan, Bryan O'Donoghue,
Hans Verkuil, Depeng Shao
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, phone-devel
On 22/12/2025 14:16, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Usually, the supply is around 1.2 V, not 1.8 V, and also correct wording.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Eventually, if more changes would be requested, would make sense someone
> from Qualcomm to follow-up on these, as I don't have schematics,
> documentation or also no access to the internal resources.
>
> Thank you
> ---
> Changes in v4:
> - Everything in one commit. (Krzysztof)
> - Dropped Fixes tag. (Bryan)
> - Updated rest of the files to make them in sync.
> - Link to v3: https://lore.kernel.org/r/20251216-docs-camss-fixes-v3-0-c238b6810771@ixit.cz
>
> Changes in v3:
> - Add commit improving vdda-phy-supply description to match more recent
> bindings.
> - Double-checked and specified it's 1.2 V vdda-pll-supply. (Vladimir)
> - Link to v2: https://lore.kernel.org/r/20251213-docs-camss-fixes-v2-1-a8a4d4d51c6c@ixit.cz
>
> Changes in v2:
> - Applied suggestion to clarify the description. (Krzysztof)
> - Link to v1: https://lore.kernel.org/r/20251212-docs-camss-fixes-v1-1-5c011505ff59@ixit.cz
> ---
> Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml | 4 ++--
> Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml | 4 ++--
> Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 4 ++--
> Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml | 4 ++--
> Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 4 ++--
> Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml | 4 ++--
> Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml | 4 ++--
> Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml | 4 ++--
> 8 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 019caa2b09c32..48f280e998096 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -126,11 +126,11 @@ properties:
>
> vdda-phy-supply:
> description:
> - Phandle to a regulator supply to PHY core block.
> + 0.88V supply to CSIPHY IP blocks.
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + 1.2V supply to CSIPHY IP blocks.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> index ee35e3bc97ffd..b1c54c5b01b28 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> @@ -125,11 +125,11 @@ properties:
>
> vdda-phy-supply:
> description:
> - Phandle to a regulator supply to PHY core block.
> + 0.88V supply to CSIPHY IP blocks.
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + 1.2V supply to CSIPHY IP blocks.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> index c99fe4106eee9..354130aba9fc9 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> @@ -264,11 +264,11 @@ properties:
>
> vdda-phy-supply:
> description:
> - Phandle to a regulator supply to PHY core block.
> + 0.88V supply to CSIPHY IP blocks.
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + 1.2V supply to CSIPHY IP blocks.
>
> required:
> - clock-names
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> index 35c40fe223767..46cc7fff15992 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> @@ -91,11 +91,11 @@ properties:
>
> vdda-phy-supply:
> description:
> - Phandle to a regulator supply to PHY core block.
> + 0.88V supply to CSIPHY IP blocks.
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + 1.2V supply to CSIPHY IP blocks.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> index 82bf4689d3300..be09cf3a3b3b8 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> @@ -207,11 +207,11 @@ properties:
>
> vdda-phy-supply:
> description:
> - Phandle to a regulator supply to PHY core block.
> + 0.88V supply to CSIPHY IP blocks.
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + 1.2V supply to CSIPHY IP blocks.
>
> required:
> - clock-names
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> index ebf68ff4ab961..a509d4bbcb4aa 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> @@ -296,11 +296,11 @@ properties:
>
> vdda-phy-supply:
> description:
> - Phandle to a regulator supply to PHY core block.
> + 0.88V supply to CSIPHY IP blocks.
>
> vdda-pll-supply:
> description:
> - Phandle to 1.8V regulator supply to PHY refclk pll block.
> + 1.2V supply to CSIPHY IP blocks.
>
> required:
> - clock-names
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
> index cd34f14916b42..4b9ab1352e914 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
> @@ -134,11 +134,11 @@ properties:
>
> vdda-phy-supply:
> description:
> - Phandle to a regulator supply to PHY core block.
> + 0.88V supply to CSIPHY IP blocks.
>
> vdda-pll-supply:
> description:
> - Phandle to 1.2V regulator supply to PHY refclk pll block.
> + 1.2V supply to CSIPHY IP blocks.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> index b87a13479a4bf..2d1662ef522b7 100644
> --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> @@ -120,11 +120,11 @@ properties:
>
> vdd-csiphy-0p8-supply:
> description:
> - Phandle to a 0.8V regulator supply to a PHY.
> + 0.8V supply to a PHY.
>
> vdd-csiphy-1p2-supply:
> description:
> - Phandle to 1.2V regulator supply to a PHY.
> + 1.2V supply to a PHY.
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
> ---
> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
> change-id: 20251212-docs-camss-fixes-0fa525271951
>
> Best regards,
I think the 'to a PHY' bit is redundant but sure, leave it as is.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-22 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-22 14:16 [PATCH v4] media: dt-bindings: Correct camss supply description David Heidelberg via B4 Relay
2025-12-22 15:35 ` Krzysztof Kozlowski
2025-12-22 15:46 ` Vladimir Zapolskiy
2025-12-22 15:50 ` Bryan O'Donoghue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox