[PATCH v1] dt-bindings: net: Add QCA2066 Bluetooth

[PATCH v1] dt-bindings: net: Add QCA2066 Bluetooth

[Tim Jiang]

Add bindings for the QCA2066 chipset.

Signed-off-by: Tim Jiang <quic_tjiang@quicinc.com>
---
 .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
index 68f78b90d23a..f51b0e8ad086 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
@@ -16,6 +16,7 @@ description:
 properties:
   compatible:
     enum:
+      - qcom,qca2066-bt
       - qcom,qca6174-bt
       - qcom,qca9377-bt
       - qcom,wcn3990-bt
-- 
2.17.1

Re: [PATCH v1] dt-bindings: net: Add QCA2066 Bluetooth

[Krzysztof Kozlowski]

On 18/05/2023 07:08, Tim Jiang wrote:
> Add bindings for the QCA2066 chipset.
> 
> Signed-off-by: Tim Jiang <quic_tjiang@quicinc.com>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested.
Please resend and include all necessary entries.


Beside that patch looks incomplete.

Best regards,
Krzysztof

RE: [PATCH v1] dt-bindings: net: Add QCA2066 Bluetooth

[Tim Jiang (QUIC)]

Krzysztof: 
Thanks for your reply, Inline comments

Regards.
Tim


-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org> 
Sent: Thursday, May 18, 2023 4:21 PM
To: Tim Jiang (QUIC) <quic_tjiang@quicinc.com>; marcel@holtmann.org
Cc: linux-kernel@vger.kernel.org; linux-bluetooth@vger.kernel.org; linux-arm-msm@vger.kernel.org; Balakrishna Godavarthi (QUIC) <quic_bgodavar@quicinc.com>; Hemant Gupta (QUIC) <quic_hemantg@quicinc.com>; mka@chromium.org
Subject: Re: [PATCH v1] dt-bindings: net: Add QCA2066 Bluetooth

On 18/05/2023 07:08, Tim Jiang wrote:
> Add bindings for the QCA2066 chipset.
> 
> Signed-off-by: Tim Jiang <quic_tjiang@quicinc.com>

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC.  It might happen, that command when run on an older kernel, gives you outdated entries.  Therefore please be sure you base your patches on recent Linux kernel.
[Tim] ok , I will update my linux kernel

You missed at least DT list (maybe more), so this won't be tested.
[Tim] do you mean email CC list ?
Please resend and include all necessary entries.


Beside that patch looks incomplete.

Best regards,
Krzysztof