From: Stephen Boyd <sboyd@codeaurora.org>
To: Rajendra Nayak <rnayak@codeaurora.org>, broonie@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-arm@lists.infradead.org
Subject: Re: [PATCH] regulator: qcom_spmi: Add support for pmi8994
Date: Thu, 2 Nov 2017 10:58:16 -0700 [thread overview]
Message-ID: <a5381e40-7ee4-6942-e38d-c18e2e8d8e26@codeaurora.org> (raw)
In-Reply-To: <1509614640-7291-1-git-send-email-rnayak@codeaurora.org>
On 11/02/2017 02:24 AM, Rajendra Nayak wrote:
> Document the regulators available on pmi8994 and add support for
> this PMIC to the SPMI PMIC regulator driver.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Tested-by: Stephen Boyd <sboyd@codeaurora.org>
> diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
> index 16c5f84..9f8eb5d 100644
> --- a/drivers/regulator/qcom_spmi-regulator.c
> +++ b/drivers/regulator/qcom_spmi-regulator.c
> @@ -1619,11 +1619,20 @@ static int spmi_regulator_of_parse(struct device_node *node,
> { }
> };
>
> +static const struct spmi_regulator_data pmi8994_regulators[] = {
> + { "s1", 0x1400, "vdd_s1", },
> + { "s2", 0x1700, "vdd_s2", },
> + { "s3", 0x1a00, "vdd_s3", },
> + { "l1", 0x4000, "vdd_l1", },
> + { }
Should be a tab instead of spaces?
> +};
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-11-02 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 9:24 [PATCH] regulator: qcom_spmi: Add support for pmi8994 Rajendra Nayak
2017-11-02 17:58 ` Stephen Boyd [this message]
2017-11-03 2:33 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5381e40-7ee4-6942-e38d-c18e2e8d8e26@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=broonie@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-arm@lists.infradead.org \
--cc=rnayak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox