From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com,
will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_nihalkum@quicinc.com,
Ravi Shankar <quic_rshankar@quicinc.com>,
Vishal Verma <quic_vishverm@quicinc.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Subject: Re: [PATCH v5 3/3] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
Date: Fri, 14 Nov 2025 23:19:35 +0100 [thread overview]
Message-ID: <a5ae933d-c5d1-4094-b4a1-de52060e0786@oss.qualcomm.com> (raw)
In-Reply-To: <20251114064541.446276-4-quic_vikramsa@quicinc.com>
On 11/14/25 7:45 AM, Vikram Sharma wrote:
> From: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
>
> Monaco EVK board does not include a camera sensor in its default hardware
> configuration. Introducing a device tree overlay to support optional
> integration of the IMX577 sensor via CSIPHY1.
>
> Camera reset is handled through an I2C expander, and power is enabled
> via TLMM GPIO74.
[...]
> +&{/} {
> + vreg_cam1_2p8: vreg-cam1-2p8 {
Where does this regulator lie physically? Is its presence dependent
on the connection of the sensor, is it part of the EVK carrier board,
or perhaps something else?
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_cam1_2p8";
> + startup-delay-us = <10000>;
> + enable-active-high;
> + gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&cam1_avdd_2v8_en_default>;
property-n
property-names
please
[...]
> +&tlmm {
> + /*
> + * gpio67, gpio68, gpio69 provide MCLK0, MCLK1, MCLK2 for
> + * CAM0, CAM1 and CAM2 respectively via the "cam_mclk" function.
> + * So, here it's MCLK1 pin for instance.
> + */
I don't really see the value in these comments..
Vladimir requested you to move the 'description' (meaning the node
describing the hardware, not a comment explaining the function of the
DT hunk in natural language) to monaco.dtsi too
Konrad
next prev parent reply other threads:[~2025-11-14 22:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 6:45 [PATCH v5 0/3] Add CCI and imx577 sensor support for monaco evk Vikram Sharma
2025-11-14 6:45 ` [PATCH v5 1/3] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible Vikram Sharma
2025-11-14 6:45 ` [PATCH v5 2/3] arm64: dts: qcom: qcs8300: Add CCI definitions Vikram Sharma
2025-11-14 22:16 ` Konrad Dybcio
2025-11-14 6:45 ` [PATCH v5 3/3] arm64: dts: qcom: monaco-evk-camera: Add DT overlay Vikram Sharma
2025-11-14 22:19 ` Konrad Dybcio [this message]
2025-11-15 5:53 ` Nihal Kumar Gupta
2025-11-17 12:37 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5ae933d-c5d1-4094-b4a1-de52060e0786@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_nihalkum@quicinc.com \
--cc=quic_rshankar@quicinc.com \
--cc=quic_svankada@quicinc.com \
--cc=quic_vikramsa@quicinc.com \
--cc=quic_vishverm@quicinc.com \
--cc=robh@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox