* [PATCH v2 1/2] arm64: dts: qcom: qcs615: add a PCIe port for WLAN
2025-06-25 7:55 [PATCH v2 0/2] Add WiFi/BT node for qcs615 ride board Yu Zhang(Yuriy)
@ 2025-06-25 7:55 ` Yu Zhang(Yuriy)
2025-06-27 0:27 ` Konrad Dybcio
2025-06-25 7:55 ` [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: add WiFi/BT nodes Yu Zhang(Yuriy)
2025-06-25 20:25 ` [PATCH v2 0/2] Add WiFi/BT node for qcs615 ride board Rob Herring (Arm)
2 siblings, 1 reply; 6+ messages in thread
From: Yu Zhang(Yuriy) @ 2025-06-25 7:55 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: linux-arm-msm, devicetree, linux-kernel, Yu Zhang (Yuriy)
Add an original PCIe port for WLAN. This port will be referenced and
supplemented by specific WLAN devices.
Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qcs615.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
index 7cec7f643a84bd59dadfc4f7b8d95f52fc81c7f2..c996d5a9e31ce283109d55fb61db8e09d7edbf02 100644
--- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
@@ -1181,6 +1181,15 @@ opp-8000000 {
opp-peak-kBps = <984500 1>;
};
};
+
+ pcieport0: pcie@0 {
+ device_type = "pci";
+ reg = <0x0 0x0 0x0 0x0 0x0>;
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
+ bus-range = <0x01 0xff>;
+ };
};
pcie_phy: phy@1c0e000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 1/2] arm64: dts: qcom: qcs615: add a PCIe port for WLAN
2025-06-25 7:55 ` [PATCH v2 1/2] arm64: dts: qcom: qcs615: add a PCIe port for WLAN Yu Zhang(Yuriy)
@ 2025-06-27 0:27 ` Konrad Dybcio
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2025-06-27 0:27 UTC (permalink / raw)
To: Yu Zhang(Yuriy), Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Dmitry Baryshkov
Cc: linux-arm-msm, devicetree, linux-kernel
On 6/25/25 9:55 AM, Yu Zhang(Yuriy) wrote:
> Add an original PCIe port for WLAN. This port will be referenced and
> supplemented by specific WLAN devices.
>
> Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qcs615.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> index 7cec7f643a84bd59dadfc4f7b8d95f52fc81c7f2..c996d5a9e31ce283109d55fb61db8e09d7edbf02 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> @@ -1181,6 +1181,15 @@ opp-8000000 {
> opp-peak-kBps = <984500 1>;
> };
> };
> +
> + pcieport0: pcie@0 {
If you're going to push another revision, please name it pcie_port0
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: add WiFi/BT nodes
2025-06-25 7:55 [PATCH v2 0/2] Add WiFi/BT node for qcs615 ride board Yu Zhang(Yuriy)
2025-06-25 7:55 ` [PATCH v2 1/2] arm64: dts: qcom: qcs615: add a PCIe port for WLAN Yu Zhang(Yuriy)
@ 2025-06-25 7:55 ` Yu Zhang(Yuriy)
2025-06-26 19:00 ` Konrad Dybcio
2025-06-25 20:25 ` [PATCH v2 0/2] Add WiFi/BT node for qcs615 ride board Rob Herring (Arm)
2 siblings, 1 reply; 6+ messages in thread
From: Yu Zhang(Yuriy) @ 2025-06-25 7:55 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: linux-arm-msm, devicetree, linux-kernel, Yu Zhang (Yuriy)
Add a node for the PMU module of the WCN6855 present on the qcs615 ride
board. Assign its LDO power outputs to the existing WiFi/BT module.
Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qcs615-ride.dts | 131 +++++++++++++++++++++++++++++++
1 file changed, 131 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
index 011f8ae077c256f079ce1b07720374a9bf721488..69597b6f9d0bccb294a6dcac3fe4eb0e21f2cf7a 100644
--- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
@@ -18,6 +18,7 @@ aliases {
mmc0 = &sdhc_1;
mmc1 = &sdhc_2;
serial0 = &uart0;
+ serial1 = &uart7;
};
chosen {
@@ -209,6 +210,83 @@ vreg_l17a: ldo17 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
};
+
+ vreg_conn_1p8: vreg_conn_1p8 {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_conn_1p8";
+ startup-delay-us = <4000>;
+ enable-active-high;
+ gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
+ };
+
+ vreg_conn_pa: vreg_conn_pa {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_conn_pa";
+ startup-delay-us = <4000>;
+ enable-active-high;
+ gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
+ };
+
+ wcn6855-pmu {
+ compatible = "qcom,wcn6855-pmu";
+
+ pinctrl-0 = <&bt_en_state>, <&wlan_en_state>;
+ pinctrl-names = "default";
+
+ bt-enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
+ wlan-enable-gpios = <&tlmm 98 GPIO_ACTIVE_HIGH>;
+
+ vddio-supply = <&vreg_conn_pa>;
+ vddaon-supply = <&vreg_s5a>;
+ vddpmu-supply = <&vreg_conn_1p8>;
+ vddrfa0p95-supply = <&vreg_s5a>;
+ vddrfa1p3-supply = <&vreg_s6a>;
+ vddrfa1p9-supply = <&vreg_l15a>;
+ vddpcie1p3-supply = <&vreg_s6a>;
+ vddpcie1p9-supply = <&vreg_l15a>;
+
+ regulators {
+ vreg_pmu_rfa_cmn: ldo0 {
+ regulator-name = "vreg_pmu_rfa_cmn";
+ };
+
+ vreg_pmu_aon_0p59: ldo1 {
+ regulator-name = "vreg_pmu_aon_0p59";
+ };
+
+ vreg_pmu_wlcx_0p8: ldo2 {
+ regulator-name = "vreg_pmu_wlcx_0p8";
+ };
+
+ vreg_pmu_wlmx_0p85: ldo3 {
+ regulator-name = "vreg_pmu_wlmx_0p85";
+ };
+
+ vreg_pmu_btcmx_0p85: ldo4 {
+ regulator-name = "vreg_pmu_btcmx_0p85";
+ };
+
+ vreg_pmu_rfa_0p8: ldo5 {
+ regulator-name = "vreg_pmu_rfa_0p8";
+ };
+
+ vreg_pmu_rfa_1p2: ldo6 {
+ regulator-name = "vreg_pmu_rfa_1p2";
+ };
+
+ vreg_pmu_rfa_1p7: ldo7 {
+ regulator-name = "vreg_pmu_rfa_1p7";
+ };
+
+ vreg_pmu_pcie_0p9: ldo8 {
+ regulator-name = "vreg_pmu_pcie_0p9";
+ };
+
+ vreg_pmu_pcie_1p8: ldo9 {
+ regulator-name = "vreg_pmu_pcie_1p8";
+ };
+ };
+ };
};
&gcc {
@@ -234,6 +312,25 @@ &pcie_phy {
status = "okay";
};
+&pcieport0 {
+ wifi@0 {
+ compatible = "pci17cb,1103";
+ reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+ qcom,ath11k-calibration-variant = "QC_QCS615_Ride";
+
+ vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+ vddaon-supply = <&vreg_pmu_aon_0p59>;
+ vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+ vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+ vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+ vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+ vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>;
+ vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
+ vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
+ };
+};
+
&pm8150_gpios {
usb2_en: usb2-en-state {
pins = "gpio10";
@@ -257,6 +354,10 @@ &qupv3_id_0 {
status = "okay";
};
+&qupv3_id_1 {
+ status = "okay";
+};
+
&remoteproc_adsp {
firmware-name = "qcom/qcs615/adsp.mbn";
@@ -274,6 +375,13 @@ &rpmhcc {
};
&tlmm {
+ bt_en_state: bt-en-state {
+ pins = "gpio85";
+ function = "gpio";
+ output-low;
+ bias-pull-down;
+ };
+
pcie_default_state: pcie-default-state {
clkreq-pins {
pins = "gpio90";
@@ -296,6 +404,13 @@ wake-pins {
bias-pull-up;
};
};
+
+ wlan_en_state: wlan-en-state {
+ pins = "gpio98";
+ function = "gpio";
+ output-low;
+ bias-pull-down;
+ };
};
&sdhc_1 {
@@ -336,6 +451,22 @@ &uart0 {
status = "okay";
};
+&uart7 {
+ status = "okay";
+
+ bluetooth {
+ compatible = "qcom,wcn6855-bt";
+ firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
+
+ vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+ vddaon-supply = <&vreg_pmu_aon_0p59>;
+ vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
+ vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+ vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+ vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>;
+ };
+};
+
&usb_1_hsphy {
vdd-supply = <&vreg_l5a>;
vdda-pll-supply = <&vreg_l12a>;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: add WiFi/BT nodes
2025-06-25 7:55 ` [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: add WiFi/BT nodes Yu Zhang(Yuriy)
@ 2025-06-26 19:00 ` Konrad Dybcio
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2025-06-26 19:00 UTC (permalink / raw)
To: Yu Zhang(Yuriy), Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Dmitry Baryshkov
Cc: linux-arm-msm, devicetree, linux-kernel
On 6/25/25 9:55 AM, Yu Zhang(Yuriy) wrote:
> Add a node for the PMU module of the WCN6855 present on the qcs615 ride
> board. Assign its LDO power outputs to the existing WiFi/BT module.
>
> Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
> ---
[...]
> + wcn6855-pmu {
> + compatible = "qcom,wcn6855-pmu";
> +
> + pinctrl-0 = <&bt_en_state>, <&wlan_en_state>;
> + pinctrl-names = "default";
> +
> + bt-enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
> + wlan-enable-gpios = <&tlmm 98 GPIO_ACTIVE_HIGH>;
> +
> + vddio-supply = <&vreg_conn_pa>;
> + vddaon-supply = <&vreg_s5a>;
> + vddpmu-supply = <&vreg_conn_1p8>;
> + vddrfa0p95-supply = <&vreg_s5a>;
> + vddrfa1p3-supply = <&vreg_s6a>;
> + vddrfa1p9-supply = <&vreg_l15a>;
> + vddpcie1p3-supply = <&vreg_s6a>;
> + vddpcie1p9-supply = <&vreg_l15a>;
You're missing some supplies (in a couple nodes), as the bot pointed out
[...]
> +&pcieport0 {
> + wifi@0 {
> + compatible = "pci17cb,1103";
> + reg = <0x10000 0x0 0x0 0x0 0x0>;
> +
> + qcom,ath11k-calibration-variant = "QC_QCS615_Ride";
Use 'qcom,calibration-variant' instead
[...]
> &tlmm {
> + bt_en_state: bt-en-state {
> + pins = "gpio85";
> + function = "gpio";
> + output-low;
> + bias-pull-down;
Please put output properties below bias (for consistency)
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] Add WiFi/BT node for qcs615 ride board.
2025-06-25 7:55 [PATCH v2 0/2] Add WiFi/BT node for qcs615 ride board Yu Zhang(Yuriy)
2025-06-25 7:55 ` [PATCH v2 1/2] arm64: dts: qcom: qcs615: add a PCIe port for WLAN Yu Zhang(Yuriy)
2025-06-25 7:55 ` [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: add WiFi/BT nodes Yu Zhang(Yuriy)
@ 2025-06-25 20:25 ` Rob Herring (Arm)
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-06-25 20:25 UTC (permalink / raw)
To: Yu Zhang(Yuriy)
Cc: Konrad Dybcio, Bjorn Andersson, Krzysztof Kozlowski, devicetree,
linux-kernel, Dmitry Baryshkov, linux-arm-msm, Conor Dooley
On Wed, 25 Jun 2025 15:55:05 +0800, Yu Zhang(Yuriy) wrote:
> This patch series depends on:
> - PCIe
> https://lore.kernel.org/all/20250527072036.3599076-1-quic_ziyuzhan@quicinc.com/
>
> Changes in V2:
> - Correct the version metadata of the previous patch.
> - Separate the modifications to the DTS and DTSI files into different
> commits.
> - Formatting: adjust layout based on reviewer feedback.
> - Updated the email address.
> - Link to v1:
> https://lore.kernel.org/all/20241203060318.1750927-1-quic_yuzha@quicinc.com/
>
> Signed-off-by: Yu Zhang (Yuriy) <yu.zhang@oss.qualcomm.com>
> ---
> Yu Zhang(Yuriy) (2):
> arm64: dts: qcom: qcs615: add a PCIe port for WLAN
> arm64: dts: qcom: qcs615-ride: add WiFi/BT nodes
>
> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 131 +++++++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/qcs615.dtsi | 9 +++
> 2 files changed, 140 insertions(+)
> ---
> base-commit: 025c0cda9c75d499b71b8e02123fea56a13b324d
> change-id: 20250625-qcs615-1ead9e48be1c
> prerequisite-message-id: <20250527072036.3599076-1-quic_ziyuzhan@quicinc.com>
> prerequisite-patch-id: 37d5ab98a6918dba98ef8fd7e6c91ab98aace170
> prerequisite-patch-id: 6d12fa7481ee4900276912d2a7071a9474e62404
> prerequisite-patch-id: 7f2e951982cabbae366b1ff516f4cfa233746427
> prerequisite-patch-id: efa688b2ddd5744df7aef40182787ee4ceb90c98
>
> Best regards,
> --
> Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: base-commit 025c0cda9c75d499b71b8e02123fea56a13b324d not known, ignoring
Base: attempting to guess base-commit...
Base: failed to guess base
Deps: looking for dependencies matching 4 patch-ids
Deps: Applying prerequisite patch: [PATCH v6 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Update pcie phy bindings for QCS615
Deps: Applying prerequisite patch: [PATCH v5 2/4] dt-bindings: PCI: qcom,pcie-sm8150: document qcs615
Deps: Applying prerequisite patch: [PATCH v5 3/4] arm64: dts: qcom: qcs615: enable pcie
Deps: Applying prerequisite patch: [PATCH v6 3/3] arm64: dts: qcom: qcs615-ride: Enable PCIe interface
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250625-qcs615-v2-0-0f1899647b36@oss.qualcomm.com:
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: bluetooth (qcom,wcn6855-bt): 'vddwlcx-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: bluetooth (qcom,wcn6855-bt): 'vddwlmx-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: bluetooth (qcom,wcn6855-bt): 'vddrfa1p8-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: wifi@0 (pci17cb,1103): 'vddrfa1p8-supply' is a required property
from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: rsc@18200000 (qcom,rpmh-rsc): 'vreg_conn_1p8', 'vreg_conn_pa', 'wcn6855-pmu' do not match any of the regexes: '^pinctrl-[0-9]+$', '^regulators(-[0-9])?$'
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpmumx-supply' is a required property
from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpmucx-supply' is a required property
from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml#
^ permalink raw reply [flat|nested] 6+ messages in thread