From: Lukas Wunner <lukas@wunner.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, cassel@kernel.org,
wilfred.mallawa@wdc.com
Subject: Re: [PATCH 2/2] PCI: Rename host_bridge::reset_slot() to host_bridge::reset_root_port()
Date: Sun, 25 May 2025 09:26:15 +0200 [thread overview]
Message-ID: <aDLGF8znWih9308o@wunner.de> (raw)
In-Reply-To: <20250524185304.26698-3-manivannan.sadhasivam@linaro.org>
Eight more occurrences where "Root Port" should be capitalized:
On Sun, May 25, 2025 at 12:23:04AM +0530, Manivannan Sadhasivam wrote:
> @@ -759,7 +759,7 @@ static int rockchip_pcie_rc_reset_slot(struct pci_host_bridge *bridge,
>
> /* Ignore errors, the link may come up later. */
> dw_pcie_wait_for_link(pci);
> - dev_dbg(dev, "slot reset completed\n");
> + dev_dbg(dev, "Root port reset completed\n");
> return ret;
>
> deinit_clk:
> @@ -1589,7 +1589,7 @@ static int qcom_pcie_reset_slot(struct pci_host_bridge *bridge,
>
> qcom_pcie_start_link(pci);
>
> - dev_dbg(dev, "Slot reset completed\n");
> + dev_dbg(dev, "Root port reset completed\n");
>
> return 0;
>
> @@ -99,22 +99,22 @@ void pci_host_common_remove(struct platform_device *pdev)
> ret = pci_bus_error_reset(dev);
> if (ret) {
> - pci_err(dev, "Failed to reset slot: %d\n", ret);
> + pci_err(dev, "Failed to reset root port: %d\n", ret);
> return PCI_ERS_RESULT_DISCONNECT;
> }
>
> - pci_info(dev, "Slot has been reset\n");
> + pci_info(dev, "Root port has been reset\n");
>
> return PCI_ERS_RESULT_RECOVERED;
> }
> @@ -140,17 +140,17 @@ static void pci_host_recover_slots(struct pci_host_bridge *host)
>
> ret = pci_bus_error_reset(dev);
> if (ret)
> - pci_err(dev, "Failed to reset slot: %d\n", ret);
> + pci_err(dev, "Failed to reset root port: %d\n", ret);
> else
> - pci_info(dev, "Slot has been reset\n");
> + pci_info(dev, "Root port has been reset\n");
> }
> }
> #endif
>
> void pci_host_handle_link_down(struct pci_host_bridge *bridge)
> {
> - dev_info(&bridge->dev, "Recovering slots due to Link Down\n");
> - pci_host_recover_slots(bridge);
> + dev_info(&bridge->dev, "Recovering root ports due to Link Down\n");
> + pci_host_reset_root_ports(bridge);
> }
> EXPORT_SYMBOL_GPL(pci_host_handle_link_down);
>
> @@ -4985,16 +4985,16 @@ void __weak pcibios_reset_secondary_bus(struct pci_dev *dev)
> + ret = host->reset_root_port(host, dev);
> if (ret)
> - pci_err(dev, "failed to reset slot: %d\n", ret);
> + pci_err(dev, "failed to reset root port: %d\n", ret);
> else
> /* Now restore it on success */
> pci_restore_state(dev);
next prev parent reply other threads:[~2025-05-25 7:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-24 18:53 [PATCH 0/2] PCI: Slot reset fixes Manivannan Sadhasivam
2025-05-24 18:53 ` [PATCH 1/2] PCI: Save and restore root port config space in pcibios_reset_secondary_bus() Manivannan Sadhasivam
2025-05-24 20:54 ` Niklas Cassel
2025-05-25 2:36 ` Wilfred Mallawa
2025-05-25 7:22 ` Lukas Wunner
2025-05-25 7:58 ` Manivannan Sadhasivam
2025-05-26 6:54 ` Lukas Wunner
2025-05-26 11:16 ` Manivannan Sadhasivam
2025-05-24 18:53 ` [PATCH 2/2] PCI: Rename host_bridge::reset_slot() to host_bridge::reset_root_port() Manivannan Sadhasivam
2025-05-24 20:57 ` Niklas Cassel
2025-05-25 2:38 ` Wilfred Mallawa
2025-05-25 8:00 ` Manivannan Sadhasivam
2025-05-24 21:51 ` kernel test robot
2025-05-25 7:26 ` Lukas Wunner [this message]
2025-05-26 0:47 ` [PATCH 0/2] PCI: Slot reset fixes Wilfred Mallawa
2025-05-26 5:53 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDLGF8znWih9308o@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=wilfred.mallawa@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox