* [PATCH v6 0/2] qcom: qcs8300: Add qcs8300 camss support
@ 2025-11-07 16:25 Vikram Sharma
2025-11-07 16:25 ` [PATCH v6 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies Vikram Sharma
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vikram Sharma @ 2025-11-07 16:25 UTC (permalink / raw)
To: bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson,
konradybcio, hverkuil-cisco, cros-qcom-dts-watchers,
catalin.marinas, will
Cc: linux-arm-kernel, quic_svankada, linux-media, linux-arm-msm,
devicetree, linux-kernel, quic_nihalkum, quic_vikramsa
QCS8300 is a Qualcomm SoC. This series adds bindings and devicetree
and driver changes to bring up CSIPHY, TPG, CSID, VFE/RDI interfaces
in QCS8300.
QCS8300 provides
- 2 x VFE, 3 RDI per VFE
- 5 x VFE Lite, 6 RDI per VFE
- 2 x CSID
- 5 x CSID Lite
- 3 x TPG
- 3 x CSIPHY
Changes in v6:
- Update commit text for bindings patch - Krzysztof
- Reverted back to v4 version of dt patch - Krzysztof
- Link to v5:
https://lore.kernel.org/all/20251107132154.436017-1-quic_vikramsa@quicinc.com
Changes in v5:
- Added Fixes: tag - Bryan
- Removed empty lines between single properties - Vladimir
- Modified binding phy supply description - Vladimir
- Link to v4:
https://lore.kernel.org/all/20251015130130.2790829-1-quic_vikramsa@quicinc.com
Changes in v4 compared to v3:
- Added supplies in bindings to enable camera sensor.
This change was earlier added as V3.1 of Binidings which was
reviewed by Krzysztof and Bryan. Link to this discussion:
https://lore.kernel.org/all/20250910104915.1444669-1-quic_vikramsa@quicinc.com
- Droped the zero-prefix from the size field un DT patch - Konrad
- Link to v3:
https://lore.kernel.org/all/20250813053724.232494-1-quic_vikramsa@quicinc.com
Changes in v3 compared to v2:
- Bindings and Device Tree: Reordered csid_wrapper to appear first in the
register list (as suggested by Bryan).
- CSIPHY Driver: Updated the commit message for the CSIPHY patch.
- VFE/CSID Resource Data: Reused the same resource data as sa8775p for VFE
and CSID.
- Patch Series Order: Rearranged the patch sequence and moved the DTSI
update to the final patch in the series.
- Code Cleanup: Removed duplicate data structures and reused existing
ones.
- Optimization: Simplified and optimized conditional checks.
- Link to v2:
https://lore.kernel.org/linux-arm-msm/20250711131134.215382-1-quic_vikramsa@quicinc.com/
Changes compared to v1:
- Changed the order for register entries in bindings - Krzysztof
- Changed the naming for interrupts for consistency - Krzysztof
- Combined separate series for driver and dtsi into one.
- Rebased on top of latest version of sa8775p camss patches.
- Link to v1:
Driver: https://lore.kernel.org/all/20250214095611.2498950-1-quic_vikramsa@quicinc.com
DTSI: https://lore.kernel.org/all/20250214094747.2483058-1-quic_vikramsa@quicinc.com
We have tested this on qcs8300-ride board with 'Test Pattern Generator'
https://lore.kernel.org/all/20250925-camss_tpg-v4-0-d2eb099902c8@oss.qualcomm.com/
Used following tools for the sanity check of these changes.
- make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=media/qcom,qcs8300-camss.yaml
qcom/qcs8300-ride.dtb
- make DT_CHECKER_FLAGS=-m W=1 DT_SCHEMA_FILES=media/qcom,qcs8300-camss.yaml
dt_binding_check
- make -j32 W=1
- checkpatch.pl
Vikram Sharma (2):
dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies
arm64: dts: qcom: qcs8300: Add support for camss
.../bindings/media/qcom,qcs8300-camss.yaml | 13 ++
arch/arm64/boot/dts/qcom/monaco.dtsi | 172 ++++++++++++++++++
2 files changed, 185 insertions(+)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v6 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies 2025-11-07 16:25 [PATCH v6 0/2] qcom: qcs8300: Add qcs8300 camss support Vikram Sharma @ 2025-11-07 16:25 ` Vikram Sharma 2025-11-08 11:43 ` Krzysztof Kozlowski 2025-11-07 16:25 ` [PATCH v6 2/2] arm64: dts: qcom: qcs8300: Add support for camss Vikram Sharma 2026-01-05 14:07 ` (subset) [PATCH v6 0/2] qcom: qcs8300: Add qcs8300 camss support Bjorn Andersson 2 siblings, 1 reply; 6+ messages in thread From: Vikram Sharma @ 2025-11-07 16:25 UTC (permalink / raw) To: bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, quic_svankada, linux-media, linux-arm-msm, devicetree, linux-kernel, quic_nihalkum, quic_vikramsa, stable Add missing vdda-phy-supply and vdda-pll-supply in the (monaco)qcs8300 camss binding. While enabling imx412 sensor for qcs8300 we see a need to add these supplies which were missing in initial submission. Fixes: 634a2958fae30 ("media: dt-bindings: Add qcom,qcs8300-camss compatible") Cc: <stable@vger.kernel.org> Co-developed-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> --- .../bindings/media/qcom,qcs8300-camss.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml index 80a4540a22dc..e5f170aa4d9e 100644 --- a/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml @@ -120,6 +120,14 @@ properties: items: - const: top + vdda-phy-supply: + description: + Phandle to a 0.88V regulator supply to CSI PHYs. + + vdda-pll-supply: + description: + Phandle to 1.2V regulator supply to CSI PHYs pll block. + ports: $ref: /schemas/graph.yaml#/properties/ports @@ -160,6 +168,8 @@ required: - power-domains - power-domain-names - ports + - vdda-phy-supply + - vdda-pll-supply additionalProperties: false @@ -328,6 +338,9 @@ examples: power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>; power-domain-names = "top"; + vdda-phy-supply = <&vreg_l4a_0p88>; + vdda-pll-supply = <&vreg_l1c_1p2>; + ports { #address-cells = <1>; #size-cells = <0>; -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v6 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies 2025-11-07 16:25 ` [PATCH v6 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies Vikram Sharma @ 2025-11-08 11:43 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2025-11-08 11:43 UTC (permalink / raw) To: Vikram Sharma Cc: bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will, linux-arm-kernel, quic_svankada, linux-media, linux-arm-msm, devicetree, linux-kernel, quic_nihalkum, stable On Fri, Nov 07, 2025 at 09:55:20PM +0530, Vikram Sharma wrote: > Add missing vdda-phy-supply and vdda-pll-supply in the (monaco)qcs8300 > camss binding. While enabling imx412 sensor for qcs8300 we see a need > to add these supplies which were missing in initial submission. > > Fixes: 634a2958fae30 ("media: dt-bindings: Add qcom,qcs8300-camss compatible") > Cc: <stable@vger.kernel.org> > Co-developed-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com> > Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com> > Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> > --- > .../bindings/media/qcom,qcs8300-camss.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v6 2/2] arm64: dts: qcom: qcs8300: Add support for camss 2025-11-07 16:25 [PATCH v6 0/2] qcom: qcs8300: Add qcs8300 camss support Vikram Sharma 2025-11-07 16:25 ` [PATCH v6 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies Vikram Sharma @ 2025-11-07 16:25 ` Vikram Sharma 2025-11-08 11:44 ` Krzysztof Kozlowski 2026-01-05 14:07 ` (subset) [PATCH v6 0/2] qcom: qcs8300: Add qcs8300 camss support Bjorn Andersson 2 siblings, 1 reply; 6+ messages in thread From: Vikram Sharma @ 2025-11-07 16:25 UTC (permalink / raw) To: bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, quic_svankada, linux-media, linux-arm-msm, devicetree, linux-kernel, quic_nihalkum, quic_vikramsa, Konrad Dybcio Add changes to support the camera subsystem on the QCS8300. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> --- arch/arm64/boot/dts/qcom/monaco.dtsi | 172 +++++++++++++++++++++++++++ 1 file changed, 172 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi index 816fa2af8a9a..774255c3f6fc 100644 --- a/arch/arm64/boot/dts/qcom/monaco.dtsi +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi @@ -4776,6 +4776,178 @@ videocc: clock-controller@abf0000 { #power-domain-cells = <1>; }; + camss: isp@ac78000 { + compatible = "qcom,qcs8300-camss"; + + reg = <0x0 0xac78000 0x0 0x1000>, + <0x0 0xac7a000 0x0 0xf00>, + <0x0 0xac7c000 0x0 0xf00>, + <0x0 0xac84000 0x0 0xf00>, + <0x0 0xac88000 0x0 0xf00>, + <0x0 0xac8c000 0x0 0xf00>, + <0x0 0xac90000 0x0 0xf00>, + <0x0 0xac94000 0x0 0xf00>, + <0x0 0xac9c000 0x0 0x2000>, + <0x0 0xac9e000 0x0 0x2000>, + <0x0 0xaca0000 0x0 0x2000>, + <0x0 0xacac000 0x0 0x400>, + <0x0 0xacad000 0x0 0x400>, + <0x0 0xacae000 0x0 0x400>, + <0x0 0xac4d000 0x0 0xf000>, + <0x0 0xac60000 0x0 0xf000>, + <0x0 0xac85000 0x0 0xd00>, + <0x0 0xac89000 0x0 0xd00>, + <0x0 0xac8d000 0x0 0xd00>, + <0x0 0xac91000 0x0 0xd00>, + <0x0 0xac95000 0x0 0xd00>; + reg-names = "csid_wrapper", + "csid0", + "csid1", + "csid_lite0", + "csid_lite1", + "csid_lite2", + "csid_lite3", + "csid_lite4", + "csiphy0", + "csiphy1", + "csiphy2", + "tpg0", + "tpg1", + "tpg2", + "vfe0", + "vfe1", + "vfe_lite0", + "vfe_lite1", + "vfe_lite2", + "vfe_lite3", + "vfe_lite4"; + + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, + <&camcc CAM_CC_CORE_AHB_CLK>, + <&camcc CAM_CC_CPAS_AHB_CLK>, + <&camcc CAM_CC_CPAS_FAST_AHB_CLK>, + <&camcc CAM_CC_CPAS_IFE_LITE_CLK>, + <&camcc CAM_CC_CPAS_IFE_0_CLK>, + <&camcc CAM_CC_CPAS_IFE_1_CLK>, + <&camcc CAM_CC_CSID_CLK>, + <&camcc CAM_CC_CSIPHY0_CLK>, + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, + <&camcc CAM_CC_CSIPHY1_CLK>, + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, + <&camcc CAM_CC_CSIPHY2_CLK>, + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, + <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>, + <&gcc GCC_CAMERA_HF_AXI_CLK>, + <&gcc GCC_CAMERA_SF_AXI_CLK>, + <&camcc CAM_CC_ICP_AHB_CLK>, + <&camcc CAM_CC_IFE_0_CLK>, + <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>, + <&camcc CAM_CC_IFE_1_CLK>, + <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>, + <&camcc CAM_CC_IFE_LITE_CLK>, + <&camcc CAM_CC_IFE_LITE_AHB_CLK>, + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, + <&camcc CAM_CC_IFE_LITE_CSID_CLK>; + clock-names = "camnoc_axi", + "core_ahb", + "cpas_ahb", + "cpas_fast_ahb_clk", + "cpas_vfe_lite", + "cpas_vfe0", + "cpas_vfe1", + "csid", + "csiphy0", + "csiphy0_timer", + "csiphy1", + "csiphy1_timer", + "csiphy2", + "csiphy2_timer", + "csiphy_rx", + "gcc_axi_hf", + "gcc_axi_sf", + "icp_ahb", + "vfe0", + "vfe0_fast_ahb", + "vfe1", + "vfe1_fast_ahb", + "vfe_lite", + "vfe_lite_ahb", + "vfe_lite_cphy_rx", + "vfe_lite_csid"; + + interrupts = <GIC_SPI 565 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 564 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 545 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 546 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 547 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 605 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "csid0", + "csid1", + "csid_lite0", + "csid_lite1", + "csid_lite2", + "csid_lite3", + "csid_lite4", + "csiphy0", + "csiphy1", + "csiphy2", + "tpg0", + "tpg1", + "tpg2", + "vfe0", + "vfe1", + "vfe_lite0", + "vfe_lite1", + "vfe_lite2", + "vfe_lite3", + "vfe_lite4"; + + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY + &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, + <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; + interconnect-names = "ahb", + "hf_0"; + + iommus = <&apps_smmu 0x2400 0x20>; + + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>; + power-domain-names = "top"; + + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + }; + + port@1 { + reg = <1>; + }; + + port@2 { + reg = <2>; + }; + }; + }; + camcc: clock-controller@ade0000 { compatible = "qcom,qcs8300-camcc"; reg = <0x0 0x0ade0000 0x0 0x20000>; -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v6 2/2] arm64: dts: qcom: qcs8300: Add support for camss 2025-11-07 16:25 ` [PATCH v6 2/2] arm64: dts: qcom: qcs8300: Add support for camss Vikram Sharma @ 2025-11-08 11:44 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2025-11-08 11:44 UTC (permalink / raw) To: Vikram Sharma, bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, quic_svankada, linux-media, linux-arm-msm, devicetree, linux-kernel, quic_nihalkum, Konrad Dybcio On 07/11/2025 17:25, Vikram Sharma wrote: > Add changes to support the camera subsystem on the QCS8300. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> > --- > arch/arm64/boot/dts/qcom/monaco.dtsi | 172 +++++++++++++++++++++++++++ > 1 file changed, 172 insertions(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH v6 0/2] qcom: qcs8300: Add qcs8300 camss support 2025-11-07 16:25 [PATCH v6 0/2] qcom: qcs8300: Add qcs8300 camss support Vikram Sharma 2025-11-07 16:25 ` [PATCH v6 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies Vikram Sharma 2025-11-07 16:25 ` [PATCH v6 2/2] arm64: dts: qcom: qcs8300: Add support for camss Vikram Sharma @ 2026-01-05 14:07 ` Bjorn Andersson 2 siblings, 0 replies; 6+ messages in thread From: Bjorn Andersson @ 2026-01-05 14:07 UTC (permalink / raw) To: bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, konradybcio, cros-qcom-dts-watchers, catalin.marinas, will, Hans Verkuil, Vikram Sharma Cc: linux-arm-kernel, quic_svankada, linux-media, linux-arm-msm, devicetree, linux-kernel, quic_nihalkum On Fri, 07 Nov 2025 21:55:19 +0530, Vikram Sharma wrote: > QCS8300 is a Qualcomm SoC. This series adds bindings and devicetree > and driver changes to bring up CSIPHY, TPG, CSID, VFE/RDI interfaces > in QCS8300. > > QCS8300 provides > - 2 x VFE, 3 RDI per VFE > - 5 x VFE Lite, 6 RDI per VFE > - 2 x CSID > - 5 x CSID Lite > - 3 x TPG > - 3 x CSIPHY > > [...] Applied, thanks! [2/2] arm64: dts: qcom: qcs8300: Add support for camss commit: ec593a86dfa1bbb5ef02165711f7ed8bb1046e29 Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-01-05 14:08 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-11-07 16:25 [PATCH v6 0/2] qcom: qcs8300: Add qcs8300 camss support Vikram Sharma 2025-11-07 16:25 ` [PATCH v6 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies Vikram Sharma 2025-11-08 11:43 ` Krzysztof Kozlowski 2025-11-07 16:25 ` [PATCH v6 2/2] arm64: dts: qcom: qcs8300: Add support for camss Vikram Sharma 2025-11-08 11:44 ` Krzysztof Kozlowski 2026-01-05 14:07 ` (subset) [PATCH v6 0/2] qcom: qcs8300: Add qcs8300 camss support Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox