* [PATCH] iommu/arm-smmu-qcom: Fix fastrpc compatible in ACTLR client match table
@ 2026-04-16 15:26 Shawn Guo
2026-04-17 13:19 ` Dmitry Baryshkov
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2026-04-16 15:26 UTC (permalink / raw)
To: Will Deacon
Cc: Rob Clark, Bibek Kumar Patro, Ninad Naik, Dmitry Baryshkov,
Bjorn Andersson, iommu, linux-arm-msm, linux-kernel, Shawn Guo
The qcom_smmu_actlr_client_of_match table used "qcom,fastrpc" as the
compatible to configure ACTLR for fastrpc SMMU clients. However, the
"qcom,fastrpc" compatible identifies the fastrpc transport (glink)
device, which does not have an iommus property and thus never attaches
to the SMMU directly.
The actual SMMU clients are the per-channel compute context bank (CB)
devices, which use the "qcom,fastrpc-compute-cb" compatible and each
carry their own iommus property. Replace the compatible string so that
ACTLR prefetch and caching settings are applied to the right devices.
Fixes: 3e35c3e725de ("iommu/arm-smmu: Add ACTLR data and support for qcom_smmu_500")
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
index edd41b5a3b6a..2d006049dd61 100644
--- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
@@ -39,7 +39,7 @@ static const struct of_device_id qcom_smmu_actlr_client_of_match[] = {
.data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
{ .compatible = "qcom,adreno-smmu",
.data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
- { .compatible = "qcom,fastrpc",
+ { .compatible = "qcom,fastrpc-compute-cb",
.data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
{ .compatible = "qcom,qcm2290-mdss",
.data = (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) },
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iommu/arm-smmu-qcom: Fix fastrpc compatible in ACTLR client match table
2026-04-16 15:26 [PATCH] iommu/arm-smmu-qcom: Fix fastrpc compatible in ACTLR client match table Shawn Guo
@ 2026-04-17 13:19 ` Dmitry Baryshkov
2026-04-17 14:04 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-04-17 13:19 UTC (permalink / raw)
To: Shawn Guo
Cc: Will Deacon, Rob Clark, Bibek Kumar Patro, Ninad Naik,
Dmitry Baryshkov, Bjorn Andersson, iommu, linux-arm-msm,
linux-kernel
On Thu, Apr 16, 2026 at 11:26:52PM +0800, Shawn Guo wrote:
> The qcom_smmu_actlr_client_of_match table used "qcom,fastrpc" as the
> compatible to configure ACTLR for fastrpc SMMU clients. However, the
> "qcom,fastrpc" compatible identifies the fastrpc transport (glink)
> device, which does not have an iommus property and thus never attaches
> to the SMMU directly.
>
> The actual SMMU clients are the per-channel compute context bank (CB)
> devices, which use the "qcom,fastrpc-compute-cb" compatible and each
> carry their own iommus property. Replace the compatible string so that
> ACTLR prefetch and caching settings are applied to the right devices.
>
> Fixes: 3e35c3e725de ("iommu/arm-smmu: Add ACTLR data and support for qcom_smmu_500")
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
https://lore.kernel.org/r/20260408130825.3268733-1-bibek.patro@oss.qualcomm.com
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> index edd41b5a3b6a..2d006049dd61 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> @@ -39,7 +39,7 @@ static const struct of_device_id qcom_smmu_actlr_client_of_match[] = {
> .data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
> { .compatible = "qcom,adreno-smmu",
> .data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
> - { .compatible = "qcom,fastrpc",
> + { .compatible = "qcom,fastrpc-compute-cb",
> .data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
> { .compatible = "qcom,qcm2290-mdss",
> .data = (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) },
> --
> 2.43.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iommu/arm-smmu-qcom: Fix fastrpc compatible in ACTLR client match table
2026-04-17 13:19 ` Dmitry Baryshkov
@ 2026-04-17 14:04 ` Shawn Guo
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2026-04-17 14:04 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Will Deacon, Rob Clark, Bibek Kumar Patro, Ninad Naik,
Dmitry Baryshkov, Bjorn Andersson, iommu, linux-arm-msm,
linux-kernel
On Fri, Apr 17, 2026 at 04:19:14PM +0300, Dmitry Baryshkov wrote:
> On Thu, Apr 16, 2026 at 11:26:52PM +0800, Shawn Guo wrote:
> > The qcom_smmu_actlr_client_of_match table used "qcom,fastrpc" as the
> > compatible to configure ACTLR for fastrpc SMMU clients. However, the
> > "qcom,fastrpc" compatible identifies the fastrpc transport (glink)
> > device, which does not have an iommus property and thus never attaches
> > to the SMMU directly.
> >
> > The actual SMMU clients are the per-channel compute context bank (CB)
> > devices, which use the "qcom,fastrpc-compute-cb" compatible and each
> > carry their own iommus property. Replace the compatible string so that
> > ACTLR prefetch and caching settings are applied to the right devices.
> >
> > Fixes: 3e35c3e725de ("iommu/arm-smmu: Add ACTLR data and support for qcom_smmu_500")
> > Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
>
> https://lore.kernel.org/r/20260408130825.3268733-1-bibek.patro@oss.qualcomm.com
Ah, thanks Dmitry! I should have searched the list first.
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-17 14:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-16 15:26 [PATCH] iommu/arm-smmu-qcom: Fix fastrpc compatible in ACTLR client match table Shawn Guo
2026-04-17 13:19 ` Dmitry Baryshkov
2026-04-17 14:04 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox