From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>
Cc: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/msm/dpu: tidy up some error checking
Date: Thu, 8 Jun 2023 02:26:14 +0300 [thread overview]
Message-ID: <b7762fab-ba49-3929-281d-ca57280e31fc@linaro.org> (raw)
In-Reply-To: <b27d016b-ff87-435b-8341-45a4369049fa@kadam.mountain>
On 07/06/2023 17:42, Dan Carpenter wrote:
> On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote:
>>> @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config(
>>> * frequency divided by the no. of rows (lines) in the LCDpanel.
>>> */
>>> vsync_hz = dpu_kms_get_clk_rate(dpu_kms, "vsync");
>>> - if (vsync_hz <= 0) {
>>> - DPU_DEBUG_CMDENC(cmd_enc, "invalid - vsync_hz %u\n",
>>> + if (!vsync_hz) {
>>> + DPU_DEBUG_CMDENC(cmd_enc, "invalid - vsync_hz %lu\n",
>>> vsync_hz);
>>
>> Nit: no need to print the value here, you know it's zero. Could be
>> clarified to just "no vsync clock".
>>
>
> Yeah. That's obviously not useful. Sorry, I will resend.
I'll fix while applying. Seems easier.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-06-07 23:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 8:33 [PATCH] drm/msm/dpu: tidy up some error checking Dan Carpenter
2023-06-06 20:18 ` Abhinav Kumar
2023-06-06 20:23 ` Marijn Suijten
2023-06-07 14:42 ` Dan Carpenter
2023-06-07 23:26 ` Dmitry Baryshkov [this message]
2023-06-08 11:14 ` Dan Carpenter
2023-06-07 23:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7762fab-ba49-3929-281d-ca57280e31fc@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox