Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Georgi Djakov <djakov@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] interconnect: qcom: sm8650: enable QoS configuration
Date: Mon, 14 Apr 2025 20:08:14 +0300	[thread overview]
Message-ID: <b9f90b0c-cae5-4dc3-817a-183b49f947b9@kernel.org> (raw)
In-Reply-To: <20250407-topic-sm8650-upstream-icc-qos-v1-1-93b33f99a455@linaro.org>

On 7.04.25 18:16, Neil Armstrong wrote:
> Enable QoS configuration for master ports with predefined values
> for priority and urgency forwarding.
> 

Hi Neil,

Thanks for the patch! It looks fine, but i noticed that there should be also
QoS configuration for the qnm_apss_noc node, but it's missing from the driver.
Do you know if skipping it was intentional?

Thanks,
Georgi


> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>   drivers/interconnect/qcom/sm8650.c | 327 +++++++++++++++++++++++++++++++++++++
>   1 file changed, 327 insertions(+)
> 


  reply	other threads:[~2025-04-14 17:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 15:16 [PATCH] interconnect: qcom: sm8650: enable QoS configuration Neil Armstrong
2025-04-14 17:08 ` Georgi Djakov [this message]
2025-04-15  8:17   ` Neil Armstrong
2025-04-15  8:42     ` Georgi Djakov
2025-05-19  8:23 ` Pengyu Luo
2025-05-19 13:30   ` neil.armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9f90b0c-cae5-4dc3-817a-183b49f947b9@kernel.org \
    --to=djakov@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox