From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_vbadigan@quicinc.com, quic_mrana@quicinc.com
Subject: Re: [PATCH v3 3/3] arm64: qcom: sc7280: Move phy, perst to root port node
Date: Mon, 2 Jun 2025 15:01:48 +0200 [thread overview]
Message-ID: <ba107a41-5520-47fa-9943-6e33946f50b1@kernel.org> (raw)
In-Reply-To: <2ce28fb9-1184-4503-8f16-878d1fcb94cd@oss.qualcomm.com>
On 08/05/2025 16:26, Konrad Dybcio wrote:
> On 4/23/25 5:37 PM, Rob Herring wrote:
>> On Sat, Apr 19, 2025 at 10:49:26AM +0530, Krishna Chaitanya Chundru wrote:
>>> There are many places we agreed to move the wake and perst gpio's
>>> and phy etc to the pcie root port node instead of bridge node[1].
>>>
>>> So move the phy, phy-names, wake-gpio's in the root port.
>>> There is already reset-gpio defined for PERST# in pci-bus-common.yaml,
>>> start using that property instead of perst-gpio.
>>
>> Moving the properties will break existing kernels. If that doesn't
>> matter for these platforms, say so in the commit msg.
>
> I don't think we generally guarantee *forward* dt compatibility though, no?
We do not guarantee, comment was not about this, but we expect. This DTS
is supposed and is used by other projects. There was entire complain
last DT BoF about kernel breaking DTS users all the time.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-02 13:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 5:19 [PATCH v3 0/3] PCI: qcom: Move PERST# GPIO & phy retrieval from controller to PCIe bridge node Krishna Chaitanya Chundru
2025-04-19 5:19 ` [PATCH v3 1/3] dt-bindings: PCI: qcom: Move phy, wake & reset gpio's to root port Krishna Chaitanya Chundru
2025-04-23 15:38 ` Rob Herring (Arm)
2025-06-01 5:14 ` Manivannan Sadhasivam
2025-04-19 5:19 ` [PATCH v3 2/3] PCI: qcom: Add support for multi-root port Krishna Chaitanya Chundru
2025-04-22 20:45 ` Konrad Dybcio
2025-04-23 3:10 ` Krishna Chaitanya Chundru
2025-06-01 7:02 ` Manivannan Sadhasivam
2025-04-19 5:19 ` [PATCH v3 3/3] arm64: qcom: sc7280: Move phy, perst to root port node Krishna Chaitanya Chundru
2025-04-23 15:37 ` Rob Herring
2025-05-08 14:26 ` Konrad Dybcio
2025-06-02 13:01 ` Krzysztof Kozlowski [this message]
2025-06-10 13:15 ` Konrad Dybcio
2025-06-11 6:36 ` Krzysztof Kozlowski
2025-06-11 15:17 ` Konrad Dybcio
2025-06-11 15:33 ` Krzysztof Kozlowski
2025-06-01 7:05 ` Manivannan Sadhasivam
2025-06-03 6:33 ` Krishna Chaitanya Chundru
2025-06-03 6:52 ` Manivannan Sadhasivam
2025-06-03 7:35 ` Krishna Chaitanya Chundru
2025-06-03 8:07 ` Manivannan Sadhasivam
2025-06-01 7:09 ` [PATCH v3 0/3] PCI: qcom: Move PERST# GPIO & phy retrieval from controller to PCIe bridge node Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba107a41-5520-47fa-9943-6e33946f50b1@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_mrana@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox