* [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
@ 2023-11-19 11:28 Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-19 20:28 ` [PATCH v3 RESEND 00/20] " Helge Deller
0 siblings, 2 replies; 7+ messages in thread
From: Heiner Kallweit @ 2023-11-19 11:28 UTC (permalink / raw)
To: Wolfram Sang, intel-gfx
Cc: linux-i2c, Heiner Kallweit, Jernej Skrabec, Jonas Karlman,
Laurent Pinchart, linux-fbdev, amd-gfx, linux-rockchip,
linux-arm-kernel, dri-devel, linux-kernel, Thomas Zimmermann,
Jocelyn Falempe, linux-sunxi, linux-mediatek, Sean Paul,
Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
v2:
- change tag in commit subject of patch 03
- add ack tags
v3:
- fix a compile error in patch 5
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
drivers/gpu/drm/ast/ast_i2c.c | 1 -
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
drivers/gpu/drm/display/drm_dp_helper.c | 1 -
drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
drivers/video/fbdev/core/fb_ddc.c | 1 -
drivers/video/fbdev/cyber2000fb.c | 1 -
drivers/video/fbdev/i740fb.c | 1 -
drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
drivers/video/fbdev/s3fb.c | 1 -
drivers/video/fbdev/tdfxfb.c | 1 -
drivers/video/fbdev/tridentfb.c | 1 -
drivers/video/fbdev/via/via_i2c.c | 1 -
include/linux/i2c.h | 1 -
31 files changed, 9 insertions(+), 47 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
@ 2023-11-19 11:28 ` Heiner Kallweit
2023-11-19 22:26 ` Dmitry Baryshkov
2023-11-19 20:28 ` [PATCH v3 RESEND 00/20] " Helge Deller
1 sibling, 1 reply; 7+ messages in thread
From: Heiner Kallweit @ 2023-11-19 11:28 UTC (permalink / raw)
To: Wolfram Sang, Rob Clark
Cc: linux-i2c, Heiner Kallweit, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, Marijn Suijten, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno, linux-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
index de182c004..7aa500d24 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
@@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi)
i2c->owner = THIS_MODULE;
- i2c->class = I2C_CLASS_DDC;
snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c");
i2c->dev.parent = &hdmi->pdev->dev;
i2c->algo = &msm_hdmi_i2c_algorithm;
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
@ 2023-11-19 20:28 ` Helge Deller
2023-11-19 20:48 ` Heiner Kallweit
1 sibling, 1 reply; 7+ messages in thread
From: Helge Deller @ 2023-11-19 20:28 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Thomas Zimmermann, Jocelyn Falempe, linux-sunxi,
linux-mediatek, Sean Paul, Marijn Suijten, linux-arm-msm,
freedreno, Xinwei Kong, Sumit Semwal, Yongqin Liu, John Stultz
On 11/19/23 12:28, Heiner Kallweit wrote:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
The fbdev changes look at least ok so far, so:
Acked-by: Helge Deller <deller@gmx.de> #fbdev
> v2:
> - change tag in commit subject of patch 03
> - add ack tags
> v3:
> - fix a compile error in patch 5
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> ---
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
> drivers/gpu/drm/ast/ast_i2c.c | 1 -
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
> drivers/video/fbdev/core/fb_ddc.c | 1 -
> drivers/video/fbdev/cyber2000fb.c | 1 -
> drivers/video/fbdev/i740fb.c | 1 -
> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
> drivers/video/fbdev/s3fb.c | 1 -
> drivers/video/fbdev/tdfxfb.c | 1 -
> drivers/video/fbdev/tridentfb.c | 1 -
> drivers/video/fbdev/via/via_i2c.c | 1 -
> include/linux/i2c.h | 1 -
> 31 files changed, 9 insertions(+), 47 deletions(-)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
2023-11-19 20:28 ` [PATCH v3 RESEND 00/20] " Helge Deller
@ 2023-11-19 20:48 ` Heiner Kallweit
2023-11-19 20:51 ` Heiner Kallweit
0 siblings, 1 reply; 7+ messages in thread
From: Heiner Kallweit @ 2023-11-19 20:48 UTC (permalink / raw)
To: Helge Deller, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Thomas Zimmermann, Jocelyn Falempe, linux-sunxi,
linux-mediatek, Sean Paul, Marijn Suijten, linux-arm-msm,
freedreno, Xinwei Kong, Sumit Semwal, Yongqin Liu, John Stultz
On 19.11.2023 21:28, Helge Deller wrote:
> On 11/19/23 12:28, Heiner Kallweit wrote:
>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>> Class-based device auto-detection is a legacy mechanism and shouldn't
>> be used in new code. So we can remove this class completely now.
>>
>> Preferably this series should be applied via the i2c tree.
>
> The fbdev changes look at least ok so far, so:
> Acked-by: Helge Deller <deller@gmx.de> #fbdev
>
I think this refers to patch 5 of the series. Could you please reply
to patch 5 instead of the cover letter with your acked-by so that
patchwork gets it right? Thanks!
>
>> v2:
>> - change tag in commit subject of patch 03
>> - add ack tags
>> v3:
>> - fix a compile error in patch 5
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>
>> ---
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>> drivers/video/fbdev/cyber2000fb.c | 1 -
>> drivers/video/fbdev/i740fb.c | 1 -
>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>> drivers/video/fbdev/s3fb.c | 1 -
>> drivers/video/fbdev/tdfxfb.c | 1 -
>> drivers/video/fbdev/tridentfb.c | 1 -
>> drivers/video/fbdev/via/via_i2c.c | 1 -
>> include/linux/i2c.h | 1 -
>> 31 files changed, 9 insertions(+), 47 deletions(-)
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
2023-11-19 20:48 ` Heiner Kallweit
@ 2023-11-19 20:51 ` Heiner Kallweit
2023-11-19 21:51 ` Helge Deller
0 siblings, 1 reply; 7+ messages in thread
From: Heiner Kallweit @ 2023-11-19 20:51 UTC (permalink / raw)
To: Helge Deller, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Thomas Zimmermann, Jocelyn Falempe, linux-sunxi,
linux-mediatek, Sean Paul, Marijn Suijten, linux-arm-msm,
freedreno, Xinwei Kong, Sumit Semwal, Yongqin Liu, John Stultz
On 19.11.2023 21:48, Heiner Kallweit wrote:
> On 19.11.2023 21:28, Helge Deller wrote:
>> On 11/19/23 12:28, Heiner Kallweit wrote:
>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>>> Class-based device auto-detection is a legacy mechanism and shouldn't
>>> be used in new code. So we can remove this class completely now.
>>>
>>> Preferably this series should be applied via the i2c tree.
>>
>> The fbdev changes look at least ok so far, so:
>> Acked-by: Helge Deller <deller@gmx.de> #fbdev
>>
> I think this refers to patch 5 of the series. Could you please reply
> to patch 5 instead of the cover letter with your acked-by so that
> patchwork gets it right? Thanks!
>
Sorry, just looked at where you are in To, not Cc.
So your ack includes patches 6, 9, 10, 13?
>>
>>> v2:
>>> - change tag in commit subject of patch 03
>>> - add ack tags
>>> v3:
>>> - fix a compile error in patch 5
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>
>>> ---
>>>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>>> drivers/video/fbdev/cyber2000fb.c | 1 -
>>> drivers/video/fbdev/i740fb.c | 1 -
>>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>>> drivers/video/fbdev/s3fb.c | 1 -
>>> drivers/video/fbdev/tdfxfb.c | 1 -
>>> drivers/video/fbdev/tridentfb.c | 1 -
>>> drivers/video/fbdev/via/via_i2c.c | 1 -
>>> include/linux/i2c.h | 1 -
>>> 31 files changed, 9 insertions(+), 47 deletions(-)
>>>
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support
2023-11-19 20:51 ` Heiner Kallweit
@ 2023-11-19 21:51 ` Helge Deller
0 siblings, 0 replies; 7+ messages in thread
From: Helge Deller @ 2023-11-19 21:51 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Thomas Zimmermann, Jocelyn Falempe, linux-sunxi,
linux-mediatek, Sean Paul, Marijn Suijten, linux-arm-msm,
freedreno, Xinwei Kong, Sumit Semwal, Yongqin Liu, John Stultz
On 11/19/23 21:51, Heiner Kallweit wrote:
> On 19.11.2023 21:48, Heiner Kallweit wrote:
>> On 19.11.2023 21:28, Helge Deller wrote:
>>> On 11/19/23 12:28, Heiner Kallweit wrote:
>>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>>>> Class-based device auto-detection is a legacy mechanism and shouldn't
>>>> be used in new code. So we can remove this class completely now.
>>>>
>>>> Preferably this series should be applied via the i2c tree.
>>>
>>> The fbdev changes look at least ok so far, so:
>>> Acked-by: Helge Deller <deller@gmx.de> #fbdev
>>>
>> I think this refers to patch 5 of the series. Could you please reply
>> to patch 5 instead of the cover letter with your acked-by so that
>> patchwork gets it right? Thanks!
>>
> Sorry, just looked at where you are in To, not Cc.
> So your ack includes patches 6, 9, 10, 13?
Yes.
Helge
>>>
>>>> v2:
>>>> - change tag in commit subject of patch 03
>>>> - add ack tags
>>>> v3:
>>>> - fix a compile error in patch 5
>>>>
>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>>
>>>> ---
>>>>
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>>>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>>>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>>>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>>>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>>>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>>>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>>>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>>>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>>>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>>>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>>>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>>>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>>>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>>>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>>>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>>>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>>>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>>>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>>>> drivers/video/fbdev/cyber2000fb.c | 1 -
>>>> drivers/video/fbdev/i740fb.c | 1 -
>>>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>>>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>>>> drivers/video/fbdev/s3fb.c | 1 -
>>>> drivers/video/fbdev/tdfxfb.c | 1 -
>>>> drivers/video/fbdev/tridentfb.c | 1 -
>>>> drivers/video/fbdev/via/via_i2c.c | 1 -
>>>> include/linux/i2c.h | 1 -
>>>> 31 files changed, 9 insertions(+), 47 deletions(-)
>>>>
>>>
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support
2023-11-19 11:28 ` [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
@ 2023-11-19 22:26 ` Dmitry Baryshkov
0 siblings, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2023-11-19 22:26 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Wolfram Sang, Rob Clark, linux-i2c, Abhinav Kumar, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, linux-arm-msm,
dri-devel, freedreno, linux-kernel
On Sun, 19 Nov 2023 at 13:28, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
I'm fine with merging this patch through any of the trees that picks
up the rest of the patches.
>
> ---
> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
> index de182c004..7aa500d24 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
> @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi)
>
>
> i2c->owner = THIS_MODULE;
> - i2c->class = I2C_CLASS_DDC;
> snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c");
> i2c->dev.parent = &hdmi->pdev->dev;
> i2c->algo = &msm_hdmi_i2c_algorithm;
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-11-19 22:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-19 22:26 ` Dmitry Baryshkov
2023-11-19 20:28 ` [PATCH v3 RESEND 00/20] " Helge Deller
2023-11-19 20:48 ` Heiner Kallweit
2023-11-19 20:51 ` Heiner Kallweit
2023-11-19 21:51 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox