From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name
Date: Tue, 7 Nov 2023 11:22:29 +0100 [thread overview]
Message-ID: <bd70fb6f-e84d-4abe-9930-5dbc687cbb80@linaro.org> (raw)
In-Reply-To: <20231107102111.16465-1-krzysztof.kozlowski@linaro.org>
On 07/11/2023 11:21, Krzysztof Kozlowski wrote:
> Soundwire Devicetree bindings expect the Soundwire controller device
> node to be named just "soundwire":
>
> sc8280xp-lenovo-thinkpad-x13s.dtb: soundwire-controller@3210000: $nodename:0: 'soundwire-controller@3210000' does not match '^soundwire(@.*)?$'
>
> Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index e5bc9c51ceff..3af3625dd5e6 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -2730,7 +2730,7 @@ rxmacro: rxmacro@3200000 {
> status = "disabled";
> };
>
> - swr1: soundwire-controller@3210000 {
> + swr1: soundwire@3210000 {
> compatible = "qcom,soundwire-v1.6.0";
> reg = <0 0x03210000 0 0x2000>;
> interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
> @@ -2806,7 +2806,7 @@ wsamacro: codec@3240000 {
> status = "disabled";
> };
>
> - swr0: soundwire-controller@3250000 {
> + swr0: soundwire@3250000 {
> reg = <0 0x03250000 0 0x2000>;
> compatible = "qcom,soundwire-v1.6.0";
> interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> @@ -2843,7 +2843,7 @@ lpass_audiocc: clock-controller@32a9000 {
> #reset-cells = <1>;
> };
>
> - swr2: soundwire-controller@3330000 {
> + swr2: soundwire@3330000 {
> compatible = "qcom,soundwire-v1.6.0";
> reg = <0 0x03330000 0 0x2000>;
> interrupts = <GIC_SPI 959 IRQ_TYPE_LEVEL_HIGH>,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-11-07 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 10:21 [PATCH 1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name Krzysztof Kozlowski
2023-11-07 10:21 ` [PATCH 2/2] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2023-11-07 10:22 ` Neil Armstrong
2023-11-07 10:22 ` Neil Armstrong [this message]
2023-12-08 2:57 ` (subset) [PATCH 1/2] arm64: dts: qcom: sc8280xp: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd70fb6f-e84d-4abe-9930-5dbc687cbb80@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox