* [PATCH 1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name
@ 2023-11-07 10:21 Krzysztof Kozlowski
2023-11-07 10:21 ` [PATCH 2/2] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-07 10:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski, Neil Armstrong
Soundwire Devicetree bindings expect the Soundwire controller device
node to be named just "soundwire":
sc8280xp-lenovo-thinkpad-x13s.dtb: soundwire-controller@3210000: $nodename:0: 'soundwire-controller@3210000' does not match '^soundwire(@.*)?$'
Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index e5bc9c51ceff..3af3625dd5e6 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -2730,7 +2730,7 @@ rxmacro: rxmacro@3200000 {
status = "disabled";
};
- swr1: soundwire-controller@3210000 {
+ swr1: soundwire@3210000 {
compatible = "qcom,soundwire-v1.6.0";
reg = <0 0x03210000 0 0x2000>;
interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
@@ -2806,7 +2806,7 @@ wsamacro: codec@3240000 {
status = "disabled";
};
- swr0: soundwire-controller@3250000 {
+ swr0: soundwire@3250000 {
reg = <0 0x03250000 0 0x2000>;
compatible = "qcom,soundwire-v1.6.0";
interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
@@ -2843,7 +2843,7 @@ lpass_audiocc: clock-controller@32a9000 {
#reset-cells = <1>;
};
- swr2: soundwire-controller@3330000 {
+ swr2: soundwire@3330000 {
compatible = "qcom,soundwire-v1.6.0";
reg = <0 0x03330000 0 0x2000>;
interrupts = <GIC_SPI 959 IRQ_TYPE_LEVEL_HIGH>,
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] arm64: dts: qcom: sm8250: correct Soundwire node name
2023-11-07 10:21 [PATCH 1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name Krzysztof Kozlowski
@ 2023-11-07 10:21 ` Krzysztof Kozlowski
2023-11-07 10:22 ` Neil Armstrong
2023-11-07 10:22 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp: " Neil Armstrong
2023-12-08 2:57 ` (subset) " Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-07 10:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski, Neil Armstrong
Soundwire Devicetree bindings expect the Soundwire controller device
node to be named just "soundwire":
sm8250-xiaomi-elish-boe.dtb: soundwire-controller@3250000: $nodename:0: 'soundwire-controller@3250000' does not match '^soundwire(@.*)?$'
Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index da71de5e1a80..e18a18a9e767 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2557,7 +2557,7 @@ wsamacro: codec@3240000 {
status = "disabled";
};
- swr0: soundwire-controller@3250000 {
+ swr0: soundwire@3250000 {
reg = <0 0x03250000 0 0x2000>;
compatible = "qcom,soundwire-v1.5.1";
interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>;
@@ -2623,7 +2623,7 @@ rxmacro: rxmacro@3200000 {
#sound-dai-cells = <1>;
};
- swr1: soundwire-controller@3210000 {
+ swr1: soundwire@3210000 {
reg = <0 0x03210000 0 0x2000>;
compatible = "qcom,soundwire-v1.5.1";
status = "disabled";
@@ -2670,7 +2670,7 @@ txmacro: txmacro@3220000 {
};
/* tx macro */
- swr2: soundwire-controller@3230000 {
+ swr2: soundwire@3230000 {
reg = <0 0x03230000 0 0x2000>;
compatible = "qcom,soundwire-v1.5.1";
interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sm8250: correct Soundwire node name
2023-11-07 10:21 ` [PATCH 2/2] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
@ 2023-11-07 10:22 ` Neil Armstrong
0 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2023-11-07 10:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel
On 07/11/2023 11:21, Krzysztof Kozlowski wrote:
> Soundwire Devicetree bindings expect the Soundwire controller device
> node to be named just "soundwire":
>
> sm8250-xiaomi-elish-boe.dtb: soundwire-controller@3250000: $nodename:0: 'soundwire-controller@3250000' does not match '^soundwire(@.*)?$'
>
> Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index da71de5e1a80..e18a18a9e767 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2557,7 +2557,7 @@ wsamacro: codec@3240000 {
> status = "disabled";
> };
>
> - swr0: soundwire-controller@3250000 {
> + swr0: soundwire@3250000 {
> reg = <0 0x03250000 0 0x2000>;
> compatible = "qcom,soundwire-v1.5.1";
> interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>;
> @@ -2623,7 +2623,7 @@ rxmacro: rxmacro@3200000 {
> #sound-dai-cells = <1>;
> };
>
> - swr1: soundwire-controller@3210000 {
> + swr1: soundwire@3210000 {
> reg = <0 0x03210000 0 0x2000>;
> compatible = "qcom,soundwire-v1.5.1";
> status = "disabled";
> @@ -2670,7 +2670,7 @@ txmacro: txmacro@3220000 {
> };
>
> /* tx macro */
> - swr2: soundwire-controller@3230000 {
> + swr2: soundwire@3230000 {
> reg = <0 0x03230000 0 0x2000>;
> compatible = "qcom,soundwire-v1.5.1";
> interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name
2023-11-07 10:21 [PATCH 1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name Krzysztof Kozlowski
2023-11-07 10:21 ` [PATCH 2/2] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
@ 2023-11-07 10:22 ` Neil Armstrong
2023-12-08 2:57 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2023-11-07 10:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel
On 07/11/2023 11:21, Krzysztof Kozlowski wrote:
> Soundwire Devicetree bindings expect the Soundwire controller device
> node to be named just "soundwire":
>
> sc8280xp-lenovo-thinkpad-x13s.dtb: soundwire-controller@3210000: $nodename:0: 'soundwire-controller@3210000' does not match '^soundwire(@.*)?$'
>
> Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index e5bc9c51ceff..3af3625dd5e6 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -2730,7 +2730,7 @@ rxmacro: rxmacro@3200000 {
> status = "disabled";
> };
>
> - swr1: soundwire-controller@3210000 {
> + swr1: soundwire@3210000 {
> compatible = "qcom,soundwire-v1.6.0";
> reg = <0 0x03210000 0 0x2000>;
> interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
> @@ -2806,7 +2806,7 @@ wsamacro: codec@3240000 {
> status = "disabled";
> };
>
> - swr0: soundwire-controller@3250000 {
> + swr0: soundwire@3250000 {
> reg = <0 0x03250000 0 0x2000>;
> compatible = "qcom,soundwire-v1.6.0";
> interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> @@ -2843,7 +2843,7 @@ lpass_audiocc: clock-controller@32a9000 {
> #reset-cells = <1>;
> };
>
> - swr2: soundwire-controller@3330000 {
> + swr2: soundwire@3330000 {
> compatible = "qcom,soundwire-v1.6.0";
> reg = <0 0x03330000 0 0x2000>;
> interrupts = <GIC_SPI 959 IRQ_TYPE_LEVEL_HIGH>,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: (subset) [PATCH 1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name
2023-11-07 10:21 [PATCH 1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name Krzysztof Kozlowski
2023-11-07 10:21 ` [PATCH 2/2] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2023-11-07 10:22 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp: " Neil Armstrong
@ 2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-12-08 2:57 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski
Cc: Neil Armstrong
On Tue, 07 Nov 2023 11:21:10 +0100, Krzysztof Kozlowski wrote:
> Soundwire Devicetree bindings expect the Soundwire controller device
> node to be named just "soundwire":
>
> sc8280xp-lenovo-thinkpad-x13s.dtb: soundwire-controller@3210000: $nodename:0: 'soundwire-controller@3210000' does not match '^soundwire(@.*)?$'
>
>
Applied, thanks!
[1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name
commit: 58e8fcf992831ef3642d90115ab119c19bfdd0c5
[2/2] arm64: dts: qcom: sm8250: correct Soundwire node name
commit: c1f52fb9a128771cfe2cae528c32b302e98398f3
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-08 2:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07 10:21 [PATCH 1/2] arm64: dts: qcom: sc8280xp: correct Soundwire node name Krzysztof Kozlowski
2023-11-07 10:21 ` [PATCH 2/2] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2023-11-07 10:22 ` Neil Armstrong
2023-11-07 10:22 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp: " Neil Armstrong
2023-12-08 2:57 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox