Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Ram Kumar Dwivedi <ram.dwivedi@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
	bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, anjana.hari@oss.qualcomm.com
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/3] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller
Date: Wed, 31 Dec 2025 10:27:28 +0530	[thread overview]
Message-ID: <c0e654d8-bb4a-4d4e-9d67-3664e6ea0aca@oss.qualcomm.com> (raw)
In-Reply-To: <3813487a-4618-4c14-9536-cc9f721b12d1@kernel.org>



On 11-Dec-25 12:04 PM, Krzysztof Kozlowski wrote:
> On 10/12/2025 16:50, Ram Kumar Dwivedi wrote:
>> +
>> +allOf:
>> +  - $ref: ufs-common.yaml
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> +    soc {
>> +        #address-cells = <2>;
>> +        #size-cells = <2>;
> 
> Not much improved... Same comments. And if you repeat "we plan" or
> "something else is something else" than answer will be the same - that
> something else does not matter and we do not care about plans.
> 
> By useless disagreements you just postpone the acceptance of this
> patchset. Especially about such nits... patch could have been reviewed
> already :/

Hi Krzysztof,

I have changed it to single-cell addressing in latest patchset.

Thanks,
Ram.




> 
>> +
>> +        ufshc@1d84000 {
>> +            compatible = "qcom,sa8255p-ufshc";
>> +            reg = <0x0 0x01d84000 0x0 0x3000>;
> 
> 
> Best regards,
> Krzysztof


  reply	other threads:[~2025-12-31  4:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 15:50 [PATCH V2 0/3] ufs: ufs-qcom: Add support firmware managed platforms Ram Kumar Dwivedi
2025-12-10 15:50 ` [PATCH V2 1/3] MAINTAINERS: broaden UFS Qualcomm binding file pattern Ram Kumar Dwivedi
2025-12-10 15:50 ` [PATCH V2 2/3] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller Ram Kumar Dwivedi
2025-12-11  6:34   ` Krzysztof Kozlowski
2025-12-31  4:57     ` Ram Kumar Dwivedi [this message]
2025-12-10 15:50 ` [PATCH V2 3/3] ufs: ufs-qcom: Add support for firmware-managed resource abstraction Ram Kumar Dwivedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0e654d8-bb4a-4d4e-9d67-3664e6ea0aca@oss.qualcomm.com \
    --to=ram.dwivedi@oss.qualcomm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=anjana.hari@oss.qualcomm.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox