* [PATCH] accel/qaic: Constify aic100_channels
@ 2024-02-23 1:06 Jeff Johnson
2024-02-23 15:13 ` Jeffrey Hugo
2024-02-23 16:08 ` Jeffrey Hugo
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-02-23 1:06 UTC (permalink / raw)
To: Jeffrey Hugo, Carl Vanderlip, Pranjal Ramajor Asha Kanojiya,
Oded Gabbay
Cc: Manivannan Sadhasivam, linux-arm-msm, dri-devel, linux-kernel,
kernel, Jeff Johnson
MHI allows the channel configs to be const, so constify
aic100_channels to prevent runtime modification.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/accel/qaic/mhi_controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/qaic/mhi_controller.c b/drivers/accel/qaic/mhi_controller.c
index cb77d048ed54..3f81d6396c85 100644
--- a/drivers/accel/qaic/mhi_controller.c
+++ b/drivers/accel/qaic/mhi_controller.c
@@ -20,7 +20,7 @@ static unsigned int mhi_timeout_ms = 2000; /* 2 sec default */
module_param(mhi_timeout_ms, uint, 0600);
MODULE_PARM_DESC(mhi_timeout_ms, "MHI controller timeout value");
-static struct mhi_channel_config aic100_channels[] = {
+static const struct mhi_channel_config aic100_channels[] = {
{
.name = "QAIC_LOOPBACK",
.num = 0,
---
base-commit: 3ab6aff5793c3c7bdf6535d9b0024544a4abbdd5
change-id: 20240222-mhi-const-accel-qaic-3889157be7ac
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/qaic: Constify aic100_channels
2024-02-23 1:06 [PATCH] accel/qaic: Constify aic100_channels Jeff Johnson
@ 2024-02-23 15:13 ` Jeffrey Hugo
2024-02-23 16:08 ` Jeffrey Hugo
1 sibling, 0 replies; 3+ messages in thread
From: Jeffrey Hugo @ 2024-02-23 15:13 UTC (permalink / raw)
To: Jeff Johnson, Carl Vanderlip, Pranjal Ramajor Asha Kanojiya,
Oded Gabbay
Cc: Manivannan Sadhasivam, linux-arm-msm, dri-devel, linux-kernel,
kernel
On 2/22/2024 6:06 PM, Jeff Johnson wrote:
> MHI allows the channel configs to be const, so constify
> aic100_channels to prevent runtime modification.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
I plan to apply to drm-misc-next before the rc6 freeze.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/qaic: Constify aic100_channels
2024-02-23 1:06 [PATCH] accel/qaic: Constify aic100_channels Jeff Johnson
2024-02-23 15:13 ` Jeffrey Hugo
@ 2024-02-23 16:08 ` Jeffrey Hugo
1 sibling, 0 replies; 3+ messages in thread
From: Jeffrey Hugo @ 2024-02-23 16:08 UTC (permalink / raw)
To: Jeff Johnson, Carl Vanderlip, Pranjal Ramajor Asha Kanojiya,
Oded Gabbay
Cc: Manivannan Sadhasivam, linux-arm-msm, dri-devel, linux-kernel,
kernel
On 2/22/2024 6:06 PM, Jeff Johnson wrote:
> MHI allows the channel configs to be const, so constify
> aic100_channels to prevent runtime modification.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Applied to drm-misc-next
-Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-23 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-23 1:06 [PATCH] accel/qaic: Constify aic100_channels Jeff Johnson
2024-02-23 15:13 ` Jeffrey Hugo
2024-02-23 16:08 ` Jeffrey Hugo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox