* [PATCH 02/11] arm64: dts: qcom: sm8250: drop incorrect Coresight funnel properties
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 13:49 ` Konrad Dybcio
2023-03-05 12:59 ` [PATCH 03/11] arm64: dts: qcom: qdu1000: drop incorrect serial properties Krzysztof Kozlowski
` (9 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
There is only one output port, thus out-ports should not have
'address/sice-cells' and unit addresses. 'reg-names' are also not
allowed by bindings.
qrb5165-rb5.dtb: funnel@6042000: out-ports: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+'
qrb5165-rb5.dtb: funnel@6b04000: Unevaluated properties are not allowed ('reg-names' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 2f0e460acccd..88870d9e3348 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2799,11 +2799,7 @@ funnel@6042000 {
clock-names = "apb_pclk";
out-ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@0 {
- reg = <0>;
+ port {
funnel_in1_out_funnel_merg: endpoint {
remote-endpoint = <&funnel_merg_in_funnel_in1>;
};
@@ -2904,7 +2900,6 @@ funnel@6b04000 {
arm,primecell-periphid = <0x000bb908>;
reg = <0 0x06b04000 0 0x1000>;
- reg-names = "funnel-base";
clocks = <&aoss_qmp>;
clock-names = "apb_pclk";
@@ -3220,9 +3215,6 @@ funnel@7810000 {
clock-names = "apb_pclk";
out-ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
port {
funnel_apss_merg_out_funnel_in1: endpoint {
remote-endpoint = <&funnel_in1_in_funnel_apss_merg>;
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 02/11] arm64: dts: qcom: sm8250: drop incorrect Coresight funnel properties
2023-03-05 12:59 ` [PATCH 02/11] arm64: dts: qcom: sm8250: drop incorrect Coresight funnel properties Krzysztof Kozlowski
@ 2023-03-06 13:49 ` Konrad Dybcio
0 siblings, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 13:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> There is only one output port, thus out-ports should not have
> 'address/sice-cells' and unit addresses. 'reg-names' are also not
s/sice/size
> allowed by bindings.
>
> qrb5165-rb5.dtb: funnel@6042000: out-ports: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+'
> qrb5165-rb5.dtb: funnel@6b04000: Unevaluated properties are not allowed ('reg-names' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 2f0e460acccd..88870d9e3348 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2799,11 +2799,7 @@ funnel@6042000 {
> clock-names = "apb_pclk";
>
> out-ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> + port {
> funnel_in1_out_funnel_merg: endpoint {
> remote-endpoint = <&funnel_merg_in_funnel_in1>;
> };
> @@ -2904,7 +2900,6 @@ funnel@6b04000 {
> arm,primecell-periphid = <0x000bb908>;
>
> reg = <0 0x06b04000 0 0x1000>;
> - reg-names = "funnel-base";
>
> clocks = <&aoss_qmp>;
> clock-names = "apb_pclk";
> @@ -3220,9 +3215,6 @@ funnel@7810000 {
> clock-names = "apb_pclk";
>
> out-ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> port {
> funnel_apss_merg_out_funnel_in1: endpoint {
> remote-endpoint = <&funnel_in1_in_funnel_apss_merg>;
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 03/11] arm64: dts: qcom: qdu1000: drop incorrect serial properties
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
2023-03-05 12:59 ` [PATCH 02/11] arm64: dts: qcom: sm8250: drop incorrect Coresight funnel properties Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 10:48 ` Konrad Dybcio
2023-03-05 12:59 ` [PATCH 04/11] arm64: dts: qcom: sdm845-db845c: drop SPI label Krzysztof Kozlowski
` (8 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The serial node does not use/allow address/size cells:
qdu1000-idp.dtb: geniqup@9c0000: serial@99c000: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
Fixes: 6bd20c54b589 ("arm64: dts: qcom: Add base QDU1000/QRU1000 DTSIs")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/qdu1000.dtsi | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
index f234159d2060..c72a51c32a30 100644
--- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
+++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
@@ -412,8 +412,6 @@ uart0: serial@980000 {
pinctrl-0 = <&qup_uart0_default>;
pinctrl-names = "default";
interrupts = <GIC_SPI 601 IRQ_TYPE_LEVEL_HIGH>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
@@ -581,8 +579,6 @@ uart7: serial@99c000 {
pinctrl-0 = <&qup_uart7_tx>, <&qup_uart7_rx>;
pinctrl-names = "default";
interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 03/11] arm64: dts: qcom: qdu1000: drop incorrect serial properties
2023-03-05 12:59 ` [PATCH 03/11] arm64: dts: qcom: qdu1000: drop incorrect serial properties Krzysztof Kozlowski
@ 2023-03-06 10:48 ` Konrad Dybcio
0 siblings, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 10:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The serial node does not use/allow address/size cells:
>
> qdu1000-idp.dtb: geniqup@9c0000: serial@99c000: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
>
> Fixes: 6bd20c54b589 ("arm64: dts: qcom: Add base QDU1000/QRU1000 DTSIs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/qdu1000.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> index f234159d2060..c72a51c32a30 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> @@ -412,8 +412,6 @@ uart0: serial@980000 {
> pinctrl-0 = <&qup_uart0_default>;
> pinctrl-names = "default";
> interrupts = <GIC_SPI 601 IRQ_TYPE_LEVEL_HIGH>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
> };
>
> @@ -581,8 +579,6 @@ uart7: serial@99c000 {
> pinctrl-0 = <&qup_uart7_tx>, <&qup_uart7_rx>;
> pinctrl-names = "default";
> interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
> };
> };
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 04/11] arm64: dts: qcom: sdm845-db845c: drop SPI label
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
2023-03-05 12:59 ` [PATCH 02/11] arm64: dts: qcom: sm8250: drop incorrect Coresight funnel properties Krzysztof Kozlowski
2023-03-05 12:59 ` [PATCH 03/11] arm64: dts: qcom: qdu1000: drop incorrect serial properties Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 10:56 ` Konrad Dybcio
2023-03-05 12:59 ` [PATCH 05/11] arm64: dts: qcom: apq8096-db820c: " Krzysztof Kozlowski
` (7 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The SPI controller nodes do not use/allow label property:
sdm845-db845c.dtb: spi@888000: Unevaluated properties are not allowed ('label' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index d4866feef2c4..acd4f9ca6c09 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -819,7 +819,6 @@ can@0 {
&spi2 {
/* On Low speed expansion */
- label = "LS-SPI0";
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 04/11] arm64: dts: qcom: sdm845-db845c: drop SPI label
2023-03-05 12:59 ` [PATCH 04/11] arm64: dts: qcom: sdm845-db845c: drop SPI label Krzysztof Kozlowski
@ 2023-03-06 10:56 ` Konrad Dybcio
0 siblings, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 10:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The SPI controller nodes do not use/allow label property:
>
> sdm845-db845c.dtb: spi@888000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Doesn't even seem to be used downstream, hm.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index d4866feef2c4..acd4f9ca6c09 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -819,7 +819,6 @@ can@0 {
>
> &spi2 {
> /* On Low speed expansion */
> - label = "LS-SPI0";
> status = "okay";
> };
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 05/11] arm64: dts: qcom: apq8096-db820c: drop SPI label
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-03-05 12:59 ` [PATCH 04/11] arm64: dts: qcom: sdm845-db845c: drop SPI label Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 10:57 ` Konrad Dybcio
2023-03-05 12:59 ` [PATCH 06/11] arm64: dts: qcom: ipq6018-cp01-c1: drop SPI cs-select Krzysztof Kozlowski
` (6 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The SPI controller nodes do not use/allow label property:
apq8096-db820c.dtb: spi@7575000: Unevaluated properties are not allowed ('label' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
index eb18811b2676..842836ed680a 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -146,7 +146,6 @@ &blsp1_i2c3 {
&blsp1_spi1 {
/* On Low speed expansion */
- label = "LS-SPI0";
status = "okay";
};
@@ -183,7 +182,6 @@ &blsp2_i2c1 {
&blsp2_spi6 {
/* On High speed expansion */
- label = "HS-SPI1";
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 05/11] arm64: dts: qcom: apq8096-db820c: drop SPI label
2023-03-05 12:59 ` [PATCH 05/11] arm64: dts: qcom: apq8096-db820c: " Krzysztof Kozlowski
@ 2023-03-06 10:57 ` Konrad Dybcio
0 siblings, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 10:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The SPI controller nodes do not use/allow label property:
>
> apq8096-db820c.dtb: spi@7575000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> index eb18811b2676..842836ed680a 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -146,7 +146,6 @@ &blsp1_i2c3 {
>
> &blsp1_spi1 {
> /* On Low speed expansion */
> - label = "LS-SPI0";
> status = "okay";
> };
>
> @@ -183,7 +182,6 @@ &blsp2_i2c1 {
>
> &blsp2_spi6 {
> /* On High speed expansion */
> - label = "HS-SPI1";
> status = "okay";
> };
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 06/11] arm64: dts: qcom: ipq6018-cp01-c1: drop SPI cs-select
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
` (3 preceding siblings ...)
2023-03-05 12:59 ` [PATCH 05/11] arm64: dts: qcom: apq8096-db820c: " Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 10:57 ` Konrad Dybcio
2023-03-05 12:59 ` [PATCH 07/11] arm64: dts: qcom: msm8953: correct RPMCC node name Krzysztof Kozlowski
` (5 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The SPI controller nodes do not use/allow cs-select property:
ipq6018-cp01-c1.dtb: spi@78b5000: Unevaluated properties are not allowed ('cs-select' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
index 2aee8594b280..f5f4827c0e17 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
+++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
@@ -35,7 +35,6 @@ &blsp1_i2c3 {
};
&blsp1_spi1 {
- cs-select = <0>;
pinctrl-0 = <&spi_0_pins>;
pinctrl-names = "default";
status = "okay";
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 06/11] arm64: dts: qcom: ipq6018-cp01-c1: drop SPI cs-select
2023-03-05 12:59 ` [PATCH 06/11] arm64: dts: qcom: ipq6018-cp01-c1: drop SPI cs-select Krzysztof Kozlowski
@ 2023-03-06 10:57 ` Konrad Dybcio
0 siblings, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 10:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The SPI controller nodes do not use/allow cs-select property:
>
> ipq6018-cp01-c1.dtb: spi@78b5000: Unevaluated properties are not allowed ('cs-select' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> index 2aee8594b280..f5f4827c0e17 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> @@ -35,7 +35,6 @@ &blsp1_i2c3 {
> };
>
> &blsp1_spi1 {
> - cs-select = <0>;
> pinctrl-0 = <&spi_0_pins>;
> pinctrl-names = "default";
> status = "okay";
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 07/11] arm64: dts: qcom: msm8953: correct RPMCC node name
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
` (4 preceding siblings ...)
2023-03-05 12:59 ` [PATCH 06/11] arm64: dts: qcom: ipq6018-cp01-c1: drop SPI cs-select Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 10:58 ` Konrad Dybcio
2023-03-05 12:59 ` [PATCH 08/11] arm64: dts: qcom: msm8953: drop clocks from RPMPD Krzysztof Kozlowski
` (4 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The bindings expect RPM clock controller subnode to be named
'clock-controller':
msm8953-motorola-potter.dtb: smd: rpm:rpm-requests: 'rpmcc' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index 610f3e3fc0c2..4e362b9012bd 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -269,7 +269,7 @@ rpm_requests: rpm-requests {
compatible = "qcom,rpm-msm8953";
qcom,smd-channels = "rpm_requests";
- rpmcc: rpmcc {
+ rpmcc: clock-controller {
compatible = "qcom,rpmcc-msm8953", "qcom,rpmcc";
clocks = <&xo_board>;
clock-names = "xo";
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 07/11] arm64: dts: qcom: msm8953: correct RPMCC node name
2023-03-05 12:59 ` [PATCH 07/11] arm64: dts: qcom: msm8953: correct RPMCC node name Krzysztof Kozlowski
@ 2023-03-06 10:58 ` Konrad Dybcio
0 siblings, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 10:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The bindings expect RPM clock controller subnode to be named
> 'clock-controller':
>
> msm8953-motorola-potter.dtb: smd: rpm:rpm-requests: 'rpmcc' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> index 610f3e3fc0c2..4e362b9012bd 100644
> --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> @@ -269,7 +269,7 @@ rpm_requests: rpm-requests {
> compatible = "qcom,rpm-msm8953";
> qcom,smd-channels = "rpm_requests";
>
> - rpmcc: rpmcc {
> + rpmcc: clock-controller {
> compatible = "qcom,rpmcc-msm8953", "qcom,rpmcc";
> clocks = <&xo_board>;
> clock-names = "xo";
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 08/11] arm64: dts: qcom: msm8953: drop clocks from RPMPD
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
` (5 preceding siblings ...)
2023-03-05 12:59 ` [PATCH 07/11] arm64: dts: qcom: msm8953: correct RPMCC node name Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 10:58 ` Konrad Dybcio
2023-03-05 12:59 ` [PATCH 09/11] arm64: dts: qcom: msm8994: correct RPMCC node name Krzysztof Kozlowski
` (3 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The RPM power domain controller does not take XO clock as input
(according to bindings and Linux driver):
msm8953-xiaomi-vince.dtb: rpm-requests: power-controller: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8953.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index 4e362b9012bd..da00c2f04cda 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -281,9 +281,6 @@ rpmpd: power-controller {
#power-domain-cells = <1>;
operating-points-v2 = <&rpmpd_opp_table>;
- clocks = <&xo_board>;
- clock-names = "ref";
-
rpmpd_opp_table: opp-table {
compatible = "operating-points-v2";
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 08/11] arm64: dts: qcom: msm8953: drop clocks from RPMPD
2023-03-05 12:59 ` [PATCH 08/11] arm64: dts: qcom: msm8953: drop clocks from RPMPD Krzysztof Kozlowski
@ 2023-03-06 10:58 ` Konrad Dybcio
0 siblings, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 10:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The RPM power domain controller does not take XO clock as input
> (according to bindings and Linux driver):
>
> msm8953-xiaomi-vince.dtb: rpm-requests: power-controller: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8953.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> index 4e362b9012bd..da00c2f04cda 100644
> --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> @@ -281,9 +281,6 @@ rpmpd: power-controller {
> #power-domain-cells = <1>;
> operating-points-v2 = <&rpmpd_opp_table>;
>
> - clocks = <&xo_board>;
> - clock-names = "ref";
> -
> rpmpd_opp_table: opp-table {
> compatible = "operating-points-v2";
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 09/11] arm64: dts: qcom: msm8994: correct RPMCC node name
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
` (6 preceding siblings ...)
2023-03-05 12:59 ` [PATCH 08/11] arm64: dts: qcom: msm8953: drop clocks from RPMPD Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 10:58 ` Konrad Dybcio
2023-03-07 19:49 ` Petr Vorel
2023-03-05 12:59 ` [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties Krzysztof Kozlowski
` (2 subsequent siblings)
10 siblings, 2 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The bindings expect RPM clock controller subnode to be named
'clock-controller':
apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests: 'rpmcc' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8994.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
index 9ff9d35496d2..768fe2326933 100644
--- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
@@ -242,7 +242,7 @@ rpm_requests: rpm-requests {
compatible = "qcom,rpm-msm8994";
qcom,smd-channels = "rpm_requests";
- rpmcc: rpmcc {
+ rpmcc: clock-controller {
compatible = "qcom,rpmcc-msm8994", "qcom,rpmcc";
#clock-cells = <1>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 09/11] arm64: dts: qcom: msm8994: correct RPMCC node name
2023-03-05 12:59 ` [PATCH 09/11] arm64: dts: qcom: msm8994: correct RPMCC node name Krzysztof Kozlowski
@ 2023-03-06 10:58 ` Konrad Dybcio
2023-03-07 19:49 ` Petr Vorel
1 sibling, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 10:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The bindings expect RPM clock controller subnode to be named
> 'clock-controller':
>
> apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests: 'rpmcc' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8994.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
> index 9ff9d35496d2..768fe2326933 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
> @@ -242,7 +242,7 @@ rpm_requests: rpm-requests {
> compatible = "qcom,rpm-msm8994";
> qcom,smd-channels = "rpm_requests";
>
> - rpmcc: rpmcc {
> + rpmcc: clock-controller {
> compatible = "qcom,rpmcc-msm8994", "qcom,rpmcc";
> #clock-cells = <1>;
> };
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 09/11] arm64: dts: qcom: msm8994: correct RPMCC node name
2023-03-05 12:59 ` [PATCH 09/11] arm64: dts: qcom: msm8994: correct RPMCC node name Krzysztof Kozlowski
2023-03-06 10:58 ` Konrad Dybcio
@ 2023-03-07 19:49 ` Petr Vorel
2023-03-08 8:39 ` Krzysztof Kozlowski
1 sibling, 1 reply; 25+ messages in thread
From: Petr Vorel @ 2023-03-07 19:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Hi all,
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 09/11] arm64: dts: qcom: msm8994: correct RPMCC node name
2023-03-07 19:49 ` Petr Vorel
@ 2023-03-08 8:39 ` Krzysztof Kozlowski
0 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-08 8:39 UTC (permalink / raw)
To: Petr Vorel
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 07/03/2023 20:49, Petr Vorel wrote:
> Hi all,
>
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
It's empty email with review tag. What did you review?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
` (7 preceding siblings ...)
2023-03-05 12:59 ` [PATCH 09/11] arm64: dts: qcom: msm8994: correct RPMCC node name Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 11:11 ` Konrad Dybcio
2023-03-08 11:39 ` Souradeep Chowdhury
2023-03-05 12:59 ` [PATCH 11/11] arm64: dts: qcom: msm8996-oneplus: do not enable incomplete nodes Krzysztof Kozlowski
2023-03-06 10:48 ` [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Konrad Dybcio
10 siblings, 2 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Nods with unit addresses must have also 'reg' property:
sc7280-herobrine-crd.dtb: eud@88e0000: ports:port@0: 'reg' is a required property
Fixes: 0b059979090d ("arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index bdcb74925313..71179182c3b8 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -3593,12 +3593,17 @@ eud: eud@88e0000 {
<0 0x088e2000 0 0x1000>;
interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
port@0 {
+ reg = <0>;
eud_ep: endpoint {
remote-endpoint = <&usb2_role_switch>;
};
};
port@1 {
+ reg = <1>;
eud_con: endpoint {
remote-endpoint = <&con_eud>;
};
@@ -3609,7 +3614,11 @@ eud_con: endpoint {
eud_typec: connector {
compatible = "usb-c-connector";
ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
port@0 {
+ reg = <0>;
con_eud: endpoint {
remote-endpoint = <&eud_con>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties
2023-03-05 12:59 ` [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties Krzysztof Kozlowski
@ 2023-03-06 11:11 ` Konrad Dybcio
2023-03-08 11:39 ` Souradeep Chowdhury
1 sibling, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 11:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> Nods with unit addresses must have also 'reg' property:
>
> sc7280-herobrine-crd.dtb: eud@88e0000: ports:port@0: 'reg' is a required property
>
> Fixes: 0b059979090d ("arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
This could use some newlines, but that's a different topic.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index bdcb74925313..71179182c3b8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -3593,12 +3593,17 @@ eud: eud@88e0000 {
> <0 0x088e2000 0 0x1000>;
> interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
> ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> port@0 {
> + reg = <0>;
> eud_ep: endpoint {
> remote-endpoint = <&usb2_role_switch>;
> };
> };
> port@1 {
> + reg = <1>;
> eud_con: endpoint {
> remote-endpoint = <&con_eud>;
> };
> @@ -3609,7 +3614,11 @@ eud_con: endpoint {
> eud_typec: connector {
> compatible = "usb-c-connector";
> ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> port@0 {
> + reg = <0>;
> con_eud: endpoint {
> remote-endpoint = <&eud_con>;
> };
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties
2023-03-05 12:59 ` [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties Krzysztof Kozlowski
2023-03-06 11:11 ` Konrad Dybcio
@ 2023-03-08 11:39 ` Souradeep Chowdhury
1 sibling, 0 replies; 25+ messages in thread
From: Souradeep Chowdhury @ 2023-03-08 11:39 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Melody Olvera,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 3/5/2023 6:29 PM, Krzysztof Kozlowski wrote:
> Nods with unit addresses must have also 'reg' property:
Nit: Should be "Nodes"
>
> sc7280-herobrine-crd.dtb: eud@88e0000: ports:port@0: 'reg' is a required property
>
> Fixes: 0b059979090d ("arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index bdcb74925313..71179182c3b8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -3593,12 +3593,17 @@ eud: eud@88e0000 {
> <0 0x088e2000 0 0x1000>;
> interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
> ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> port@0 {
> + reg = <0>;
> eud_ep: endpoint {
> remote-endpoint = <&usb2_role_switch>;
> };
> };
> port@1 {
> + reg = <1>;
> eud_con: endpoint {
> remote-endpoint = <&con_eud>;
> };
> @@ -3609,7 +3614,11 @@ eud_con: endpoint {
> eud_typec: connector {
> compatible = "usb-c-connector";
> ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> port@0 {
> + reg = <0>;
> con_eud: endpoint {
> remote-endpoint = <&eud_con>;
> };
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 11/11] arm64: dts: qcom: msm8996-oneplus: do not enable incomplete nodes
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
` (8 preceding siblings ...)
2023-03-05 12:59 ` [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties Krzysztof Kozlowski
@ 2023-03-05 12:59 ` Krzysztof Kozlowski
2023-03-06 13:55 ` Konrad Dybcio
2023-03-06 10:48 ` [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Konrad Dybcio
10 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
status=okay should appear in final place where all required properties
are provided, because that makes the code the easiest to read. Move the
status from common OnePlus DTSI to board DTS. No functional changes.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../boot/dts/qcom/msm8996-oneplus-common.dtsi | 17 -----------------
arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts | 6 ++++++
arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts | 6 ++++++
3 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
index 104deaee74e5..2adadc1e5b7c 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
@@ -85,10 +85,6 @@ wlan_en: wlan-en-regulator {
};
};
-&adsp_pil {
- status = "okay";
-};
-
&blsp1_i2c3 {
status = "okay";
@@ -183,10 +179,6 @@ &dsi0_phy {
status = "okay";
};
-&gpu {
- status = "okay";
-};
-
&hsusb_phy1 {
vdd-supply = <&vreg_l28a_0p925>;
vdda-pll-supply = <&vreg_l12a_1p8>;
@@ -215,7 +207,6 @@ &mmcc {
&mss_pil {
pll-supply = <&vreg_l12a_1p8>;
- status = "okay";
};
&pcie0 {
@@ -548,10 +539,6 @@ wcd9335: codec@1,0 {
};
};
-&slpi_pil {
- status = "okay";
-};
-
&sound {
compatible = "qcom,apq8096-sndcard";
model = "OnePlus3";
@@ -812,7 +799,3 @@ &usb3_dwc3 {
maximum-speed = "high-speed";
};
-
-&venus {
- status = "okay";
-};
diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts b/arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts
index 1bdc1b134305..dfe75119b8d2 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts
+++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts
@@ -17,6 +17,7 @@ / {
&adsp_pil {
firmware-name = "qcom/msm8996/oneplus3/adsp.mbn";
+ status = "okay";
};
&battery {
@@ -25,6 +26,8 @@ &battery {
};
&gpu {
+ status = "okay";
+
zap-shader {
firmware-name = "qcom/msm8996/oneplus3/a530_zap.mbn";
};
@@ -33,12 +36,15 @@ zap-shader {
&mss_pil {
firmware-name = "qcom/msm8996/oneplus3/mba.mbn",
"qcom/msm8996/oneplus3/modem.mbn";
+ status = "okay";
};
&slpi_pil {
firmware-name = "qcom/msm8996/oneplus3/slpi.mbn";
+ status = "okay";
};
&venus {
firmware-name = "qcom/msm8996/oneplus3/venus.mbn";
+ status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts b/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
index 34f837dd0c12..51fce65e89f1 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
+++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
@@ -18,6 +18,7 @@ / {
&adsp_pil {
firmware-name = "qcom/msm8996/oneplus3t/adsp.mbn";
+ status = "okay";
};
&battery {
@@ -26,6 +27,8 @@ &battery {
};
&gpu {
+ status = "okay";
+
zap-shader {
firmware-name = "qcom/msm8996/oneplus3t/a530_zap.mbn";
};
@@ -34,12 +37,15 @@ zap-shader {
&mss_pil {
firmware-name = "qcom/msm8996/oneplus3t/mba.mbn",
"qcom/msm8996/oneplus3t/modem.mbn";
+ status = "okay";
};
&slpi_pil {
firmware-name = "qcom/msm8996/oneplus3t/slpi.mbn";
+ status = "okay";
};
&venus {
firmware-name = "qcom/msm8996/oneplus3t/venus.mbn";
+ status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 11/11] arm64: dts: qcom: msm8996-oneplus: do not enable incomplete nodes
2023-03-05 12:59 ` [PATCH 11/11] arm64: dts: qcom: msm8996-oneplus: do not enable incomplete nodes Krzysztof Kozlowski
@ 2023-03-06 13:55 ` Konrad Dybcio
0 siblings, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 13:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel,
Harry Austen
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> status=okay should appear in final place where all required properties
> are provided, because that makes the code the easiest to read. Move the
> status from common OnePlus DTSI to board DTS. No functional changes.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
+CC Harry
Are all of these firmwares actually different on 3/3T?
My educated guess would be that at least ZAP and Venus could
be shared. Could you doublecheck?
For the patch, I suppose this does make sense and it looks like we're
already doing it, so:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> .../boot/dts/qcom/msm8996-oneplus-common.dtsi | 17 -----------------
> arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts | 6 ++++++
> arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts | 6 ++++++
> 3 files changed, 12 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> index 104deaee74e5..2adadc1e5b7c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> @@ -85,10 +85,6 @@ wlan_en: wlan-en-regulator {
> };
> };
>
> -&adsp_pil {
> - status = "okay";
> -};
> -
> &blsp1_i2c3 {
> status = "okay";
>
> @@ -183,10 +179,6 @@ &dsi0_phy {
> status = "okay";
> };
>
> -&gpu {
> - status = "okay";
> -};
> -
> &hsusb_phy1 {
> vdd-supply = <&vreg_l28a_0p925>;
> vdda-pll-supply = <&vreg_l12a_1p8>;
> @@ -215,7 +207,6 @@ &mmcc {
>
> &mss_pil {
> pll-supply = <&vreg_l12a_1p8>;
> - status = "okay";
> };
>
> &pcie0 {
> @@ -548,10 +539,6 @@ wcd9335: codec@1,0 {
> };
> };
>
> -&slpi_pil {
> - status = "okay";
> -};
> -
> &sound {
> compatible = "qcom,apq8096-sndcard";
> model = "OnePlus3";
> @@ -812,7 +799,3 @@ &usb3_dwc3 {
>
> maximum-speed = "high-speed";
> };
> -
> -&venus {
> - status = "okay";
> -};
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts b/arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts
> index 1bdc1b134305..dfe75119b8d2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts
> @@ -17,6 +17,7 @@ / {
>
> &adsp_pil {
> firmware-name = "qcom/msm8996/oneplus3/adsp.mbn";
> + status = "okay";
> };
>
> &battery {
> @@ -25,6 +26,8 @@ &battery {
> };
>
> &gpu {
> + status = "okay";
> +
> zap-shader {
> firmware-name = "qcom/msm8996/oneplus3/a530_zap.mbn";
> };
> @@ -33,12 +36,15 @@ zap-shader {
> &mss_pil {
> firmware-name = "qcom/msm8996/oneplus3/mba.mbn",
> "qcom/msm8996/oneplus3/modem.mbn";
> + status = "okay";
> };
>
> &slpi_pil {
> firmware-name = "qcom/msm8996/oneplus3/slpi.mbn";
> + status = "okay";
> };
>
> &venus {
> firmware-name = "qcom/msm8996/oneplus3/venus.mbn";
> + status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts b/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
> index 34f837dd0c12..51fce65e89f1 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts
> @@ -18,6 +18,7 @@ / {
>
> &adsp_pil {
> firmware-name = "qcom/msm8996/oneplus3t/adsp.mbn";
> + status = "okay";
> };
>
> &battery {
> @@ -26,6 +27,8 @@ &battery {
> };
>
> &gpu {
> + status = "okay";
> +
> zap-shader {
> firmware-name = "qcom/msm8996/oneplus3t/a530_zap.mbn";
> };
> @@ -34,12 +37,15 @@ zap-shader {
> &mss_pil {
> firmware-name = "qcom/msm8996/oneplus3t/mba.mbn",
> "qcom/msm8996/oneplus3t/modem.mbn";
> + status = "okay";
> };
>
> &slpi_pil {
> firmware-name = "qcom/msm8996/oneplus3t/slpi.mbn";
> + status = "okay";
> };
>
> &venus {
> firmware-name = "qcom/msm8996/oneplus3t/venus.mbn";
> + status = "okay";
> };
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI
2023-03-05 12:59 [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI Krzysztof Kozlowski
` (9 preceding siblings ...)
2023-03-05 12:59 ` [PATCH 11/11] arm64: dts: qcom: msm8996-oneplus: do not enable incomplete nodes Krzysztof Kozlowski
@ 2023-03-06 10:48 ` Konrad Dybcio
10 siblings, 0 replies; 25+ messages in thread
From: Konrad Dybcio @ 2023-03-06 10:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Melody Olvera, Souradeep Chowdhury,
Greg Kroah-Hartman, linux-arm-msm, devicetree, linux-kernel
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The SPMI controller (PMIC Arbiter)) does not use nor allow 'cell-index'
> property:
>
> sm8150-microsoft-surface-duo.dtb: spmi@c440000: Unevaluated properties are not allowed ('cell-index' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 -
> arch/arm64/boot/dts/qcom/msm8976.dtsi | 1 -
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 -
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 -
> arch/arm64/boot/dts/qcom/sdm630.dtsi | 1 -
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 1 -
> arch/arm64/boot/dts/qcom/sm6125.dtsi | 1 -
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 -
> 8 files changed, 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 62d05d740646..f769e63c955c 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -397,7 +397,6 @@ spmi_bus: spmi@200f000 {
> #size-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <4>;
> - cell-index = <0>;
> };
>
> sdhc_1: mmc@7824900 {
> diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi
> index 2d360d05aa5e..712f80fc865c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi
> @@ -809,7 +809,6 @@ spmi_bus: spmi@200f000 {
> #size-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <4>;
> - cell-index = <0>;
> };
>
> sdhc_1: mmc@7824000 {
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index adf7258b3269..d450fe69fe33 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -1993,7 +1993,6 @@ spmi_bus: spmi@800f000 {
> #size-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <4>;
> - cell-index = <0>;
> };
>
> usb3: usb@a8f8800 {
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index ebfa21e9ed8a..51bb0a2f25ef 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3280,7 +3280,6 @@ spmi_bus: spmi@c440000 {
> #size-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <4>;
> - cell-index = <0>;
> };
>
> sram@146aa000 {
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 5827cda270a0..72d9a12b5e9c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -1189,7 +1189,6 @@ spmi_bus: spmi@800f000 {
> #size-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <4>;
> - cell-index = <0>;
> };
>
> usb3: usb@a8f8800 {
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 479859bd8ab3..dc43e438b64a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4924,7 +4924,6 @@ spmi_bus: spmi@c440000 {
> #size-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <4>;
> - cell-index = <0>;
> };
>
> sram@146bf000 {
> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> index 65033227718a..fd577eb705f8 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> @@ -1134,7 +1134,6 @@ spmi_bus: spmi@1c40000 {
> #size-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <4>;
> - cell-index = <0>;
> };
>
> apps_smmu: iommu@c600000 {
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index fd20096cfc6e..f89abf131e01 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -3935,7 +3935,6 @@ spmi_bus: spmi@c440000 {
> #size-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <4>;
> - cell-index = <0>;
> };
>
> apps_smmu: iommu@15000000 {
^ permalink raw reply [flat|nested] 25+ messages in thread