[PATCH v3 0/3] Enable Watchdog on QCS8300

[PATCH v3 0/3] Enable Watchdog on QCS8300

[Xin Liu]

Add Watchdog support to the QCS8300 Ride platform. Include the relevant
binding documents accordingly. Additionally, configure Watchdog-related
clock and interrupt in the device tree.

This patch series depends on below patch series:
https://lore.kernel.org/linux-arm-msm/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
--- 
Changes in v3:
- PATCH 3/3：Add \n at the last line of the file.
- Link to v2: https://lore.kernel.org/linux-arm-msm/20241119102315.3167607-1-quic_liuxin@quicinc.com/
Changes in v2:
- PATCH 1/3：Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
- PATCH 2/3：Drop the Reviewed-by tag that received by v1. Assign a label to
  the wachdog node.
- Link to v1: https://lore.kernel.org/all/20241029031222.1653123-1-quic_liuxin@quicinc.com/

--- 

Xin Liu (3):
  dt-bindings: watchdog: Document Qualcomm QCS8300 watchdog
  arm64: dts: qcom: qcs8300: Add watchdog node
  arm64: dts: qcom: qcs8300-ride: Add watchdog node

 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts                | 4 ++++
 arch/arm64/boot/dts/qcom/qcs8300.dtsi                    | 6 ++++++
 3 files changed, 11 insertions(+)
---
base-commit: 4d0326b60bb753627437fff0f76bf1525bcda422

-- 
2.34.1

[PATCH v3 1/3] dt-bindings: watchdog: Document Qualcomm QCS8300 watchdog

[Xin Liu]

Add devicetree binding for watchdog present on Qualcomm
QCS8300 SoC.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
---
 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 932393f8c649..200071227d4f 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -26,6 +26,7 @@ properties:
               - qcom,apss-wdt-msm8994
               - qcom,apss-wdt-qcm2290
               - qcom,apss-wdt-qcs404
+              - qcom,apss-wdt-qcs8300
               - qcom,apss-wdt-sa8255p
               - qcom,apss-wdt-sa8775p
               - qcom,apss-wdt-sc7180
-- 
2.34.1

[PATCH v3 2/3] arm64: dts: qcom: qcs8300: Add watchdog node

[Xin Liu]

Add the watchdog node for QCS8300 SoC.

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
index 2c35f96c3f28..13321b1a8af6 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
@@ -1122,6 +1122,12 @@ intc: interrupt-controller@17a00000 {
 			redistributor-stride = <0x0 0x20000>;
 		};
 
+		watchdog: watchdog@17c10000 {
+			compatible = "qcom,apss-wdt-qcs8300", "qcom,kpss-wdt";
+			reg = <0x0 0x17c10000 0x0 0x1000>;
+			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
+		};
+
 		memtimer: timer@17c20000 {
 			compatible = "arm,armv7-timer-mem";
 			reg = <0x0 0x17c20000 0x0 0x1000>;
-- 
2.34.1

Re: [PATCH v3 2/3] arm64: dts: qcom: qcs8300: Add watchdog node

[Konrad Dybcio]

On 25.11.2024 10:35 AM, Xin Liu wrote:
> Add the watchdog node for QCS8300 SoC.
> 
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

[PATCH v3 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

[Xin Liu]

Add watchdog clock on the Qualcomm QCS8300 Ride platform.

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 7eed19a694c3..d4e4c7a8b453 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -265,3 +265,7 @@ &ufs_mem_phy {
 	vdda-pll-supply = <&vreg_l5a>;
 	status = "okay";
 };
+
+&watchdog {
+    clocks = <&sleep_clk>;
+};
-- 
2.34.1

Re: [PATCH v3 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

[Dmitry Baryshkov]

On Mon, Nov 25, 2024 at 05:35:03PM +0800, Xin Liu wrote:
> Add watchdog clock on the Qualcomm QCS8300 Ride platform.
> 
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 7eed19a694c3..d4e4c7a8b453 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -265,3 +265,7 @@ &ufs_mem_phy {
>  	vdda-pll-supply = <&vreg_l5a>;
>  	status = "okay";
>  };
> +
> +&watchdog {
> +    clocks = <&sleep_clk>;
> +};

I'd really prefer to have this in the SoC dtsi. It's not a part that can
change between boards.

-- 
With best wishes
Dmitry

Re: [PATCH v3 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

[Xin Liu]

在 2024/11/26 0:45, Dmitry Baryshkov 写道:
> I'd really prefer to have this in the SoC dtsi. It's not a part that can
> change between boards.

I think you're right, this clock won't change because of the board The 
reason for placing it on the board is that sleep_clk is defined on the 
board. The following link is the suggestion you once provided:
https://lore.kernel.org/all/4kopdkvbkrpcpzwteezm427ml5putqvzsnfkpmg76spsple7l5@mg7v3ihwxnit/