Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: glymur: Fix the sec and tert phy pipe clock halt check
@ 2025-09-28 13:14 Abel Vesa
  2025-10-01  9:21 ` Konrad Dybcio
  0 siblings, 1 reply; 2+ messages in thread
From: Abel Vesa @ 2025-09-28 13:14 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Konrad Dybcio,
	Dmitry Baryshkov, Taniya Das
  Cc: linux-arm-msm, linux-clk, linux-kernel, Abel Vesa

On Glymur platform, halt checking on gcc_usb3_sec_phy_pipe_clk and
gcc_usb3_tert_phy_pipe_clk on enable reports them as being stuck as off,
but since the gcc_usb3_prim_phy_pipe_clk clock halt check flag is marked
as delay, means it probably it should be the same for sec and tert as
well. So replace the voted flag with the delay one for these two clocks.

Fixes: efe504300a17 ("clk: qcom: gcc: Add support for Global Clock Controller")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 drivers/clk/qcom/gcc-glymur.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/gcc-glymur.c b/drivers/clk/qcom/gcc-glymur.c
index 62059120f9720bbac03852c0368f4de3038a559c..f00d72bb4ac4d60032e5332e6bcc439f890e5082 100644
--- a/drivers/clk/qcom/gcc-glymur.c
+++ b/drivers/clk/qcom/gcc-glymur.c
@@ -6816,7 +6816,7 @@ static struct clk_branch gcc_usb3_sec_phy_com_aux_clk = {
 
 static struct clk_branch gcc_usb3_sec_phy_pipe_clk = {
 	.halt_reg = 0xe2078,
-	.halt_check = BRANCH_HALT_VOTED,
+	.halt_check = BRANCH_HALT_DELAY,
 	.hwcg_reg = 0xe2078,
 	.hwcg_bit = 1,
 	.clkr = {
@@ -6872,7 +6872,7 @@ static struct clk_branch gcc_usb3_tert_phy_com_aux_clk = {
 
 static struct clk_branch gcc_usb3_tert_phy_pipe_clk = {
 	.halt_reg = 0xe1078,
-	.halt_check = BRANCH_HALT_VOTED,
+	.halt_check = BRANCH_HALT_DELAY,
 	.hwcg_reg = 0xe1078,
 	.hwcg_bit = 1,
 	.clkr = {

---
base-commit: 262858079afde6d367ce3db183c74d8a43a0e83f
change-id: 20250928-clk-qcom-glymur-gcc-fix-sec-tert-pipe-clk-6f48511333d0

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: qcom: glymur: Fix the sec and tert phy pipe clock halt check
  2025-09-28 13:14 [PATCH] clk: qcom: glymur: Fix the sec and tert phy pipe clock halt check Abel Vesa
@ 2025-10-01  9:21 ` Konrad Dybcio
  0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2025-10-01  9:21 UTC (permalink / raw)
  To: Abel Vesa, Bjorn Andersson, Michael Turquette, Stephen Boyd,
	Dmitry Baryshkov, Taniya Das
  Cc: linux-arm-msm, linux-clk, linux-kernel

On 9/28/25 3:14 PM, Abel Vesa wrote:
> On Glymur platform, halt checking on gcc_usb3_sec_phy_pipe_clk and
> gcc_usb3_tert_phy_pipe_clk on enable reports them as being stuck as off,
> but since the gcc_usb3_prim_phy_pipe_clk clock halt check flag is marked
> as delay, means it probably it should be the same for sec and tert as
> well. So replace the voted flag with the delay one for these two clocks.
> 
> Fixes: efe504300a17 ("clk: qcom: gcc: Add support for Global Clock Controller")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---

Taniya updates all three to _SKIP in:

https://lore.kernel.org/linux-arm-msm/20250925-glymur_gcc_usb_fixes-v2-1-ee4619571efe@oss.qualcomm.com/

among other fixes

Konrad

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-10-01  9:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-28 13:14 [PATCH] clk: qcom: glymur: Fix the sec and tert phy pipe clock halt check Abel Vesa
2025-10-01  9:21 ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox