Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
* [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency
@ 2024-11-10 14:00 Chukun Pan
  2024-11-10 14:00 ` [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz " Chukun Pan
                   ` (4 more replies)
  0 siblings, 5 replies; 20+ messages in thread
From: Chukun Pan @ 2024-11-10 14:00 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	linux-kernel, devicetree, Chukun Pan

Changes in v4:
  Modify the commit message to further explain CPU Frequency of IPQ6000
  Rename ipq6018-rdp.dtsi to ipq6018-mp5496.dtsi (inherit ipq6018.dtsi)

Changes in v3:
  Modify the commit message to further explain CPU Frequency of IPQ6000
  Rename ipq6018-mp5496.dtsi to ipq6018-rdp.dtsi (common for RDP board)

Changes in v2:
  Add more CPU Frequencies in ipq6018.dtsi
  Move mp5496 regulator to ipq6018-mp5496.dtsi
  Add LDOA2 regulator to support SDCC voltage scaling

Chukun Pan (4):
  arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
  arm64: dts: qcom: ipq6018: add 1.5GHz CPU Frequency
  arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi
  arm64: dts: qcom: ipq6018: add LDOA2 regulator

 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  2 +-
 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi | 44 ++++++++++++++++++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 28 ++++++-------
 3 files changed, 59 insertions(+), 15 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi

-- 
2.25.1


^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
  2024-11-10 14:00 [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
@ 2024-11-10 14:00 ` Chukun Pan
  2024-11-30 14:47   ` Konrad Dybcio
  2024-11-10 14:00 ` [PATCH v4 2/4] arm64: dts: qcom: ipq6018: add 1.5GHz " Chukun Pan
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 20+ messages in thread
From: Chukun Pan @ 2024-11-10 14:00 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	linux-kernel, devicetree, Chukun Pan

The final version of IPQ6000 (SoC id: IPQ6000, SBL version:
BOOT.XF.0.3-00086-IPQ60xxLZB-1) has a max design frequency
of 1.2GHz, so add this CPU frequency.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index dbf6716bcb59..57ad6f0e6e34 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -119,6 +119,13 @@ opp-1056000000 {
 			clock-latency-ns = <200000>;
 		};
 
+		opp-1200000000 {
+			opp-hz = /bits/ 64 <1200000000>;
+			opp-microvolt = <850000>;
+			opp-supported-hw = <0x4>;
+			clock-latency-ns = <200000>;
+		};
+
 		opp-1320000000 {
 			opp-hz = /bits/ 64 <1320000000>;
 			opp-microvolt = <862500>;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH v4 2/4] arm64: dts: qcom: ipq6018: add 1.5GHz CPU Frequency
  2024-11-10 14:00 [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
  2024-11-10 14:00 ` [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz " Chukun Pan
@ 2024-11-10 14:00 ` Chukun Pan
  2024-11-30 14:48   ` Konrad Dybcio
  2024-11-10 14:00 ` [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi Chukun Pan
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 20+ messages in thread
From: Chukun Pan @ 2024-11-10 14:00 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	linux-kernel, devicetree, Chukun Pan

The early version of IPQ6000 (SoC id: IPQ6018, SBL version:
BOOT.XF.0.3-00077-IPQ60xxLZB-2) and IPQ6005 SoCs can reach
a max frequency of 1.5GHz, so add this CPU frequency.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 57ad6f0e6e34..7514919132b6 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -140,6 +140,13 @@ opp-1440000000 {
 			clock-latency-ns = <200000>;
 		};
 
+		opp-1512000000 {
+			opp-hz = /bits/ 64 <1512000000>;
+			opp-microvolt = <937500>;
+			opp-supported-hw = <0x2>;
+			clock-latency-ns = <200000>;
+		};
+
 		opp-1608000000 {
 			opp-hz = /bits/ 64 <1608000000>;
 			opp-microvolt = <987500>;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi
  2024-11-10 14:00 [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
  2024-11-10 14:00 ` [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz " Chukun Pan
  2024-11-10 14:00 ` [PATCH v4 2/4] arm64: dts: qcom: ipq6018: add 1.5GHz " Chukun Pan
@ 2024-11-10 14:00 ` Chukun Pan
  2024-11-30 14:50   ` Konrad Dybcio
  2024-11-10 14:00 ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
  2024-11-10 15:30 ` [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
  4 siblings, 1 reply; 20+ messages in thread
From: Chukun Pan @ 2024-11-10 14:00 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	linux-kernel, devicetree, Chukun Pan

Some IPQ60xx SoCs don't come with the mp5496 pmic chip. The mp5496
pmic was never part of the IPQ60xx SoC, it's optional, so we moved
it out of the soc dtsi.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  2 +-
 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi | 35 ++++++++++++++++++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 14 --------
 3 files changed, 36 insertions(+), 15 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi

diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
index f5f4827c0e17..9c69d3027b43 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
+++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
@@ -7,7 +7,7 @@
 
 /dts-v1/;
 
-#include "ipq6018.dtsi"
+#include "ipq6018-mp5496.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
diff --git a/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
new file mode 100644
index 000000000000..fe2152df69f4
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * ipq6018-mp5496.dtsi describes common properties (e.g. regulators) that
+ * apply to most devices that make use of the IPQ6018 SoC and MP5496 PMIC.
+ */
+
+#include "ipq6018.dtsi"
+
+&cpu0 {
+	cpu-supply = <&ipq6018_s2>;
+};
+
+&cpu1 {
+	cpu-supply = <&ipq6018_s2>;
+};
+
+&cpu2 {
+	cpu-supply = <&ipq6018_s2>;
+};
+
+&cpu3 {
+	cpu-supply = <&ipq6018_s2>;
+};
+
+&rpm_requests {
+	regulators {
+		compatible = "qcom,rpm-mp5496-regulators";
+
+		ipq6018_s2: s2 {
+			regulator-min-microvolt = <725000>;
+			regulator-max-microvolt = <1062500>;
+			regulator-always-on;
+		};
+	};
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 7514919132b6..a02aa641cb90 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -43,7 +43,6 @@ cpu0: cpu@0 {
 			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
-			cpu-supply = <&ipq6018_s2>;
 			#cooling-cells = <2>;
 		};
 
@@ -56,7 +55,6 @@ cpu1: cpu@1 {
 			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
-			cpu-supply = <&ipq6018_s2>;
 			#cooling-cells = <2>;
 		};
 
@@ -69,7 +67,6 @@ cpu2: cpu@2 {
 			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
-			cpu-supply = <&ipq6018_s2>;
 			#cooling-cells = <2>;
 		};
 
@@ -82,7 +79,6 @@ cpu3: cpu@3 {
 			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
-			cpu-supply = <&ipq6018_s2>;
 			#cooling-cells = <2>;
 		};
 
@@ -184,16 +180,6 @@ glink-edge {
 			rpm_requests: rpm-requests {
 				compatible = "qcom,rpm-ipq6018", "qcom,glink-smd-rpm";
 				qcom,glink-channels = "rpm_requests";
-
-				regulators {
-					compatible = "qcom,rpm-mp5496-regulators";
-
-					ipq6018_s2: s2 {
-						regulator-min-microvolt = <725000>;
-						regulator-max-microvolt = <1062500>;
-						regulator-always-on;
-					};
-				};
 			};
 		};
 	};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator
  2024-11-10 14:00 [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
                   ` (2 preceding siblings ...)
  2024-11-10 14:00 ` [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi Chukun Pan
@ 2024-11-10 14:00 ` Chukun Pan
  2024-11-30 14:51   ` Konrad Dybcio
  2024-11-10 15:30 ` [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
  4 siblings, 1 reply; 20+ messages in thread
From: Chukun Pan @ 2024-11-10 14:00 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	linux-kernel, devicetree, Chukun Pan, Robert Marko

Add LDOA2 regulator from MP5496 to support SDCC voltage scaling.

Suggested-by: Robert Marko <robimarko@gmail.com>
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
index fe2152df69f4..0a57e1afe218 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
@@ -31,5 +31,14 @@ ipq6018_s2: s2 {
 			regulator-max-microvolt = <1062500>;
 			regulator-always-on;
 		};
+
+		ipq6018_l2: l2 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <3300000>;
+		};
 	};
 };
+
+&sdhc {
+	vqmmc-supply = <&ipq6018_l2>;
+};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency
  2024-11-10 14:00 [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
                   ` (3 preceding siblings ...)
  2024-11-10 14:00 ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
@ 2024-11-10 15:30 ` Chukun Pan
  2024-11-10 15:30   ` [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi Chukun Pan
  4 siblings, 1 reply; 20+ messages in thread
From: Chukun Pan @ 2024-11-10 15:30 UTC (permalink / raw)
  To: amadeus
  Cc: andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel

0003-arm64-dts-qcom-ipq6018-move-mp5496-regulator-out-of-.patch
missing, so I resent.

 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  2 +-
 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi | 44 ++++++++++++++++++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 28 ++++++-------
 3 files changed, 59 insertions(+), 15 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi

-- 
2.25.1


^ permalink raw reply	[flat|nested] 20+ messages in thread

* [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi
  2024-11-10 15:30 ` [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
@ 2024-11-10 15:30   ` Chukun Pan
  0 siblings, 0 replies; 20+ messages in thread
From: Chukun Pan @ 2024-11-10 15:30 UTC (permalink / raw)
  To: amadeus
  Cc: andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel

Some IPQ60xx SoCs don't come with the mp5496 pmic chip. The mp5496
pmic was never part of the IPQ60xx SoC, it's optional, so we moved
it out of the soc dtsi.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  2 +-
 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi | 35 ++++++++++++++++++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 14 --------
 3 files changed, 36 insertions(+), 15 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi

diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
index f5f4827c0e17..9c69d3027b43 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
+++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
@@ -7,7 +7,7 @@
 
 /dts-v1/;
 
-#include "ipq6018.dtsi"
+#include "ipq6018-mp5496.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
diff --git a/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
new file mode 100644
index 000000000000..fe2152df69f4
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * ipq6018-mp5496.dtsi describes common properties (e.g. regulators) that
+ * apply to most devices that make use of the IPQ6018 SoC and MP5496 PMIC.
+ */
+
+#include "ipq6018.dtsi"
+
+&cpu0 {
+	cpu-supply = <&ipq6018_s2>;
+};
+
+&cpu1 {
+	cpu-supply = <&ipq6018_s2>;
+};
+
+&cpu2 {
+	cpu-supply = <&ipq6018_s2>;
+};
+
+&cpu3 {
+	cpu-supply = <&ipq6018_s2>;
+};
+
+&rpm_requests {
+	regulators {
+		compatible = "qcom,rpm-mp5496-regulators";
+
+		ipq6018_s2: s2 {
+			regulator-min-microvolt = <725000>;
+			regulator-max-microvolt = <1062500>;
+			regulator-always-on;
+		};
+	};
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 7514919132b6..a02aa641cb90 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -43,7 +43,6 @@ cpu0: cpu@0 {
 			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
-			cpu-supply = <&ipq6018_s2>;
 			#cooling-cells = <2>;
 		};
 
@@ -56,7 +55,6 @@ cpu1: cpu@1 {
 			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
-			cpu-supply = <&ipq6018_s2>;
 			#cooling-cells = <2>;
 		};
 
@@ -69,7 +67,6 @@ cpu2: cpu@2 {
 			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
-			cpu-supply = <&ipq6018_s2>;
 			#cooling-cells = <2>;
 		};
 
@@ -82,7 +79,6 @@ cpu3: cpu@3 {
 			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
 			clock-names = "cpu";
 			operating-points-v2 = <&cpu_opp_table>;
-			cpu-supply = <&ipq6018_s2>;
 			#cooling-cells = <2>;
 		};
 
@@ -184,16 +180,6 @@ glink-edge {
 			rpm_requests: rpm-requests {
 				compatible = "qcom,rpm-ipq6018", "qcom,glink-smd-rpm";
 				qcom,glink-channels = "rpm_requests";
-
-				regulators {
-					compatible = "qcom,rpm-mp5496-regulators";
-
-					ipq6018_s2: s2 {
-						regulator-min-microvolt = <725000>;
-						regulator-max-microvolt = <1062500>;
-						regulator-always-on;
-					};
-				};
 			};
 		};
 	};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
  2024-11-10 14:00 ` [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz " Chukun Pan
@ 2024-11-30 14:47   ` Konrad Dybcio
  2024-12-22  5:20     ` Chukun Pan
  0 siblings, 1 reply; 20+ messages in thread
From: Konrad Dybcio @ 2024-11-30 14:47 UTC (permalink / raw)
  To: Chukun Pan, Bjorn Andersson
  Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	linux-kernel, devicetree, Sricharan Ramabadhran

On 10.11.2024 3:00 PM, Chukun Pan wrote:
> The final version of IPQ6000 (SoC id: IPQ6000, SBL version:
> BOOT.XF.0.3-00086-IPQ60xxLZB-1) has a max design frequency
> of 1.2GHz, so add this CPU frequency.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---

I can't find anything to support that.

Maybe Sricharan can help out here.

Konrad

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 2/4] arm64: dts: qcom: ipq6018: add 1.5GHz CPU Frequency
  2024-11-10 14:00 ` [PATCH v4 2/4] arm64: dts: qcom: ipq6018: add 1.5GHz " Chukun Pan
@ 2024-11-30 14:48   ` Konrad Dybcio
  0 siblings, 0 replies; 20+ messages in thread
From: Konrad Dybcio @ 2024-11-30 14:48 UTC (permalink / raw)
  To: Chukun Pan, Bjorn Andersson
  Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	linux-kernel, devicetree

On 10.11.2024 3:00 PM, Chukun Pan wrote:
> The early version of IPQ6000 (SoC id: IPQ6018, SBL version:
> BOOT.XF.0.3-00077-IPQ60xxLZB-2) and IPQ6005 SoCs can reach
> a max frequency of 1.5GHz, so add this CPU frequency.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---

Similarly, I can't seem to find anything to back this up

Konrad

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi
  2024-11-10 14:00 ` [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi Chukun Pan
@ 2024-11-30 14:50   ` Konrad Dybcio
  0 siblings, 0 replies; 20+ messages in thread
From: Konrad Dybcio @ 2024-11-30 14:50 UTC (permalink / raw)
  To: Chukun Pan, Bjorn Andersson
  Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	linux-kernel, devicetree

On 10.11.2024 3:00 PM, Chukun Pan wrote:
> Some IPQ60xx SoCs don't come with the mp5496 pmic chip. The mp5496
> pmic was never part of the IPQ60xx SoC, it's optional, so we moved
> it out of the soc dtsi.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts |  2 +-
>  arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi | 35 ++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi        | 14 --------
>  3 files changed, 36 insertions(+), 15 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> index f5f4827c0e17..9c69d3027b43 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> @@ -7,7 +7,7 @@
>  
>  /dts-v1/;
>  
> -#include "ipq6018.dtsi"
> +#include "ipq6018-mp5496.dtsi"
>  
>  / {
>  	model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
> new file mode 100644
> index 000000000000..fe2152df69f4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
> @@ -0,0 +1,35 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * ipq6018-mp5496.dtsi describes common properties (e.g. regulators) that
> + * apply to most devices that make use of the IPQ6018 SoC and MP5496 PMIC.
> + */

It's good to retain the copyright notices if you extract data out a file

lgtm otherwise

Konrad

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator
  2024-11-10 14:00 ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
@ 2024-11-30 14:51   ` Konrad Dybcio
  2024-12-22  4:38     ` [PATCH 1/1] arm64: dts: rockchip: default to host mode for USB on Radxa E25 Chukun Pan
  2024-12-22  4:40     ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
  0 siblings, 2 replies; 20+ messages in thread
From: Konrad Dybcio @ 2024-11-30 14:51 UTC (permalink / raw)
  To: Chukun Pan, Bjorn Andersson
  Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	linux-kernel, devicetree, Robert Marko

On 10.11.2024 3:00 PM, Chukun Pan wrote:
> Add LDOA2 regulator from MP5496 to support SDCC voltage scaling.
> 
> Suggested-by: Robert Marko <robimarko@gmail.com>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
> index fe2152df69f4..0a57e1afe218 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
> @@ -31,5 +31,14 @@ ipq6018_s2: s2 {
>  			regulator-max-microvolt = <1062500>;
>  			regulator-always-on;
>  		};
> +
> +		ipq6018_l2: l2 {

s/ipq6018/mp5496

Konrad

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH 1/1] arm64: dts: rockchip: default to host mode for USB on Radxa E25
  2024-11-30 14:51   ` Konrad Dybcio
@ 2024-12-22  4:38     ` Chukun Pan
  2024-12-22  4:40     ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
  1 sibling, 0 replies; 20+ messages in thread
From: Chukun Pan @ 2024-12-22  4:38 UTC (permalink / raw)
  To: konrad.dybcio
  Cc: amadeus, andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel, robimarko

Hi,
>> @@ -31,5 +31,14 @@ ipq6018_s2: s2 {
>>  			regulator-max-microvolt = <1062500>;
>>  			regulator-always-on;
>>  		};
>> +
>> +		ipq6018_l2: l2 {
>
> s/ipq6018/mp5496

Does ipq6018_s2 also need to be changed?

-- 
2.25.1


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator
  2024-11-30 14:51   ` Konrad Dybcio
  2024-12-22  4:38     ` [PATCH 1/1] arm64: dts: rockchip: default to host mode for USB on Radxa E25 Chukun Pan
@ 2024-12-22  4:40     ` Chukun Pan
  2024-12-22  5:08       ` Dmitry Baryshkov
  1 sibling, 1 reply; 20+ messages in thread
From: Chukun Pan @ 2024-12-22  4:40 UTC (permalink / raw)
  To: konrad.dybcio
  Cc: amadeus, andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel, robimarko

Hi,
>> @@ -31,5 +31,14 @@ ipq6018_s2: s2 {
>>  			regulator-max-microvolt = <1062500>;
>>  			regulator-always-on;
>>  		};
>> +
>> +		ipq6018_l2: l2 {
>
> s/ipq6018/mp5496

Does ipq6018_s2 also need to be changed?

-- 
2.25.1


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator
  2024-12-22  4:40     ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
@ 2024-12-22  5:08       ` Dmitry Baryshkov
  0 siblings, 0 replies; 20+ messages in thread
From: Dmitry Baryshkov @ 2024-12-22  5:08 UTC (permalink / raw)
  To: Chukun Pan
  Cc: konrad.dybcio, andersson, conor+dt, devicetree, konradybcio,
	krzk+dt, linux-arm-msm, linux-kernel, robimarko

On Sun, Dec 22, 2024 at 12:40:01PM +0800, Chukun Pan wrote:
> Hi,
> >> @@ -31,5 +31,14 @@ ipq6018_s2: s2 {
> >>  			regulator-max-microvolt = <1062500>;
> >>  			regulator-always-on;
> >>  		};
> >> +
> >> +		ipq6018_l2: l2 {
> >
> > s/ipq6018/mp5496
> 
> Does ipq6018_s2 also need to be changed?

Yes, in a separate commit, please.

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
  2024-11-30 14:47   ` Konrad Dybcio
@ 2024-12-22  5:20     ` Chukun Pan
  2024-12-23 10:58       ` Konrad Dybcio
  0 siblings, 1 reply; 20+ messages in thread
From: Chukun Pan @ 2024-12-22  5:20 UTC (permalink / raw)
  To: konrad.dybcio
  Cc: amadeus, andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel, quic_srichara

Hi,
> I can't find anything to support that.
>
> Maybe Sricharan can help out here.

https://lore.kernel.org/lkml/4a11d946-3c32-42fd-959b-32e61cc61ab5@quicinc.com/
Based on the instructions in the link above, is there anything else I need to do?

Thanks,
Chukun

-- 
2.25.1


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
  2024-12-22  5:20     ` Chukun Pan
@ 2024-12-23 10:58       ` Konrad Dybcio
  2024-12-24  7:00         ` Chukun Pan
  0 siblings, 1 reply; 20+ messages in thread
From: Konrad Dybcio @ 2024-12-23 10:58 UTC (permalink / raw)
  To: Chukun Pan, konrad.dybcio
  Cc: andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel, quic_srichara

On 22.12.2024 6:20 AM, Chukun Pan wrote:
> Hi,
>> I can't find anything to support that.
>>
>> Maybe Sricharan can help out here.
> 
> https://lore.kernel.org/lkml/4a11d946-3c32-42fd-959b-32e61cc61ab5@quicinc.com/
> Based on the instructions in the link above, is there anything else I need to do?

I think Kathiravan only wanted to make sure you have the latest bootloader.

Looking at the documentation, I don't see a 1.2 GHz frequency level for
this platform.

Konrad

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
  2024-12-23 10:58       ` Konrad Dybcio
@ 2024-12-24  7:00         ` Chukun Pan
  2024-12-30 14:15           ` Konrad Dybcio
  0 siblings, 1 reply; 20+ messages in thread
From: Chukun Pan @ 2024-12-24  7:00 UTC (permalink / raw)
  To: konrad.dybcio
  Cc: amadeus, andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel, quic_srichara

Hi,
> I think Kathiravan only wanted to make sure you have the latest bootloader.
>
> Looking at the documentation, I don't see a 1.2 GHz frequency level for
> this platform.

But from the merchant's publicity, ipq6000 is 1.2GHz:

https://wikidevi.wi-cat.ru/Qualcomm/IPQ6000
https://www.gl-inet.com/products/gl-ax1800 (CPU Part)
https://www.alldatasheet.com/datasheet-pdf/pdf/1246071/COMPEX/AP.CP03.html

Thanks,
Chukun

-- 
2.25.1


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
  2024-12-24  7:00         ` Chukun Pan
@ 2024-12-30 14:15           ` Konrad Dybcio
  2025-01-03  3:00             ` Chukun Pan
  0 siblings, 1 reply; 20+ messages in thread
From: Konrad Dybcio @ 2024-12-30 14:15 UTC (permalink / raw)
  To: Chukun Pan, konrad.dybcio
  Cc: andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel, quic_srichara

On 24.12.2024 8:00 AM, Chukun Pan wrote:
> Hi,
>> I think Kathiravan only wanted to make sure you have the latest bootloader.
>>
>> Looking at the documentation, I don't see a 1.2 GHz frequency level for
>> this platform.
> 
> But from the merchant's publicity, ipq6000 is 1.2GHz:
> 
> https://wikidevi.wi-cat.ru/Qualcomm/IPQ6000
> https://www.gl-inet.com/products/gl-ax1800 (CPU Part)
> https://www.alldatasheet.com/datasheet-pdf/pdf/1246071/COMPEX/AP.CP03.html

Could you try to boot the BSP software and read out the related
registers to determine the real CPU frequency?

Or perhaps, if there's a cpufreq driver (I don't know), check syfs

Konrad

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
  2024-12-30 14:15           ` Konrad Dybcio
@ 2025-01-03  3:00             ` Chukun Pan
  2025-01-03 11:52               ` Konrad Dybcio
  0 siblings, 1 reply; 20+ messages in thread
From: Chukun Pan @ 2025-01-03  3:00 UTC (permalink / raw)
  To: konrad.dybcio
  Cc: amadeus, andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel

Hi,
> Could you try to boot the BSP software and read out the related
> registers to determine the real CPU frequency?
>
> Or perhaps, if there's a cpufreq driver (I don't know), check syfs

1. The CPU frequency on OEM firmware is 1.2GHz.
2. The CPU frequency on the BSP kernel is 1.2GHz.

Related commit on the BSP kernel:
https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/commit/7336e62905941d8137176b911410d1cea25d6336

Thanks,
Chukun

-- 
2.25.1


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
  2025-01-03  3:00             ` Chukun Pan
@ 2025-01-03 11:52               ` Konrad Dybcio
  0 siblings, 0 replies; 20+ messages in thread
From: Konrad Dybcio @ 2025-01-03 11:52 UTC (permalink / raw)
  To: Chukun Pan, konrad.dybcio
  Cc: andersson, conor+dt, devicetree, konradybcio, krzk+dt,
	linux-arm-msm, linux-kernel

On 3.01.2025 4:00 AM, Chukun Pan wrote:
> Hi,
>> Could you try to boot the BSP software and read out the related
>> registers to determine the real CPU frequency?
>>
>> Or perhaps, if there's a cpufreq driver (I don't know), check syfs
> 
> 1. The CPU frequency on OEM firmware is 1.2GHz.
> 2. The CPU frequency on the BSP kernel is 1.2GHz.
> 
> Related commit on the BSP kernel:
> https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/commit/7336e62905941d8137176b911410d1cea25d6336

Ok, thank you for providing this

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2025-01-03 11:52 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-10 14:00 [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
2024-11-10 14:00 ` [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz " Chukun Pan
2024-11-30 14:47   ` Konrad Dybcio
2024-12-22  5:20     ` Chukun Pan
2024-12-23 10:58       ` Konrad Dybcio
2024-12-24  7:00         ` Chukun Pan
2024-12-30 14:15           ` Konrad Dybcio
2025-01-03  3:00             ` Chukun Pan
2025-01-03 11:52               ` Konrad Dybcio
2024-11-10 14:00 ` [PATCH v4 2/4] arm64: dts: qcom: ipq6018: add 1.5GHz " Chukun Pan
2024-11-30 14:48   ` Konrad Dybcio
2024-11-10 14:00 ` [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi Chukun Pan
2024-11-30 14:50   ` Konrad Dybcio
2024-11-10 14:00 ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
2024-11-30 14:51   ` Konrad Dybcio
2024-12-22  4:38     ` [PATCH 1/1] arm64: dts: rockchip: default to host mode for USB on Radxa E25 Chukun Pan
2024-12-22  4:40     ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
2024-12-22  5:08       ` Dmitry Baryshkov
2024-11-10 15:30 ` [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
2024-11-10 15:30   ` [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi Chukun Pan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox