* [PATCH 1/5] arm64: dts: qcom: msm8996: Drop redundant VSYNC pin state
2026-02-18 17:24 [PATCH 0/5] arm64: dts: qcom: Drop redundant VSYNC pin state Krzysztof Kozlowski
@ 2026-02-18 17:24 ` Krzysztof Kozlowski
2026-02-19 6:49 ` Dmitry Baryshkov
2026-02-19 9:18 ` Konrad Dybcio
2026-02-18 17:24 ` [PATCH 2/5] arm64: dts: qcom: msm8998: " Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 2 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-18 17:24 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
The active and suspend pin state of VSYNC is exactly the same, so just
use one node for both states.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 9 +--------
arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 11 ++---------
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +-
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts | 2 +-
4 files changed, 5 insertions(+), 19 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
index 63ab564655bc..a4dcc88bb01f 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
@@ -745,14 +745,7 @@ mdss_dsi_suspend: mdss-dsi-suspend-state {
bias-pull-down;
};
- mdss_te_active: mdss-te-active-state {
- pins = "gpio10";
- function = "mdp_vsync";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- mdss_te_suspend: mdss-te-suspend-state {
+ mdss_te: mdss-te-state {
pins = "gpio10";
function = "mdp_vsync";
drive-strength = <2>;
diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
index 0386636a29f0..77ad613590a3 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
@@ -247,7 +247,7 @@ &mdss_dsi0 {
pinctrl-names = "default", "sleep";
pinctrl-0 = <&mdss_dsi_default &mdss_te_default>;
- pinctrl-1 = <&mdss_dsi_sleep &mdss_te_sleep>;
+ pinctrl-1 = <&mdss_dsi_sleep &mdss_te_default>;
};
&mdss_dsi0_out {
@@ -730,14 +730,7 @@ mdss_dsi_sleep: mdss-dsi-sleep-state {
bias-pull-down;
};
- mdss_te_default: mdss-te-default-state {
- pins = "gpio10";
- function = "mdp_vsync";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- mdss_te_sleep: mdss-te-sleep-state {
+ mdss_te_default: mdss-te-state {
pins = "gpio10";
function = "mdp_vsync";
drive-strength = <2>;
diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts
index 3c6a40212a8d..fd3a2121465b 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts
@@ -104,7 +104,7 @@ &mdss_dsi0 {
pinctrl-names = "default", "sleep";
pinctrl-0 = <&mdss_dsi_default &mdss_te_default>;
- pinctrl-1 = <&mdss_dsi_sleep &mdss_te_sleep>;
+ pinctrl-1 = <&mdss_dsi_sleep &mdss_te_default>;
panel: panel@0 {
compatible = "jdi,fhd-r63452";
diff --git a/arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts b/arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts
index f8ab03f106a1..7e2ee9a4e9f0 100644
--- a/arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts
+++ b/arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts
@@ -51,7 +51,7 @@ &mdss_dsi0 {
pinctrl-names = "default", "sleep";
pinctrl-0 = <&mdss_dsi_default &mdss_te_default>;
- pinctrl-1 = <&mdss_dsi_sleep &mdss_te_sleep>;
+ pinctrl-1 = <&mdss_dsi_sleep &mdss_te_default>;
panel: panel@0 {
compatible = "jdi,fhd-r63452";
--
2.51.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 1/5] arm64: dts: qcom: msm8996: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 1/5] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
@ 2026-02-19 6:49 ` Dmitry Baryshkov
2026-02-19 7:23 ` Krzysztof Kozlowski
2026-02-19 9:18 ` Konrad Dybcio
1 sibling, 1 reply; 19+ messages in thread
From: Dmitry Baryshkov @ 2026-02-19 6:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Wed, Feb 18, 2026 at 06:24:23PM +0100, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 9 +--------
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 11 ++---------
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts | 2 +-
> 4 files changed, 5 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> index 63ab564655bc..a4dcc88bb01f 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> @@ -745,14 +745,7 @@ mdss_dsi_suspend: mdss-dsi-suspend-state {
> bias-pull-down;
> };
>
> - mdss_te_active: mdss-te-active-state {
> - pins = "gpio10";
> - function = "mdp_vsync";
> - drive-strength = <2>;
> - bias-pull-down;
> - };
> -
> - mdss_te_suspend: mdss-te-suspend-state {
> + mdss_te: mdss-te-state {
This is not used and probably can be dropped.
> pins = "gpio10";
> function = "mdp_vsync";
> drive-strength = <2>;
The rest LGTM.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 1/5] arm64: dts: qcom: msm8996: Drop redundant VSYNC pin state
2026-02-19 6:49 ` Dmitry Baryshkov
@ 2026-02-19 7:23 ` Krzysztof Kozlowski
2026-02-19 7:46 ` Dmitry Baryshkov
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-19 7:23 UTC (permalink / raw)
To: Dmitry Baryshkov, Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On 19/02/2026 07:49, Dmitry Baryshkov wrote:
> On Wed, Feb 18, 2026 at 06:24:23PM +0100, Krzysztof Kozlowski wrote:
>> The active and suspend pin state of VSYNC is exactly the same, so just
>> use one node for both states.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 9 +--------
>> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 11 ++---------
>> arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +-
>> arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts | 2 +-
>> 4 files changed, 5 insertions(+), 19 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
>> index 63ab564655bc..a4dcc88bb01f 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
>> @@ -745,14 +745,7 @@ mdss_dsi_suspend: mdss-dsi-suspend-state {
>> bias-pull-down;
>> };
>>
>> - mdss_te_active: mdss-te-active-state {
>> - pins = "gpio10";
>> - function = "mdp_vsync";
>> - drive-strength = <2>;
>> - bias-pull-down;
>> - };
>> -
>> - mdss_te_suspend: mdss-te-suspend-state {
>> + mdss_te: mdss-te-state {
>
> This is not used and probably can be dropped.
>
But I think it should be used - it's just incomplete. There DSI is
enabled so there should be a panel using the TE/VSYNC. This looks like
being added for future, just like many other pincfg states.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 1/5] arm64: dts: qcom: msm8996: Drop redundant VSYNC pin state
2026-02-19 7:23 ` Krzysztof Kozlowski
@ 2026-02-19 7:46 ` Dmitry Baryshkov
0 siblings, 0 replies; 19+ messages in thread
From: Dmitry Baryshkov @ 2026-02-19 7:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On Thu, Feb 19, 2026 at 08:23:45AM +0100, Krzysztof Kozlowski wrote:
> On 19/02/2026 07:49, Dmitry Baryshkov wrote:
> > On Wed, Feb 18, 2026 at 06:24:23PM +0100, Krzysztof Kozlowski wrote:
> >> The active and suspend pin state of VSYNC is exactly the same, so just
> >> use one node for both states.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >> ---
> >> arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 9 +--------
> >> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 11 ++---------
> >> arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +-
> >> arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts | 2 +-
> >> 4 files changed, 5 insertions(+), 19 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> >> index 63ab564655bc..a4dcc88bb01f 100644
> >> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> >> @@ -745,14 +745,7 @@ mdss_dsi_suspend: mdss-dsi-suspend-state {
> >> bias-pull-down;
> >> };
> >>
> >> - mdss_te_active: mdss-te-active-state {
> >> - pins = "gpio10";
> >> - function = "mdp_vsync";
> >> - drive-strength = <2>;
> >> - bias-pull-down;
> >> - };
> >> -
> >> - mdss_te_suspend: mdss-te-suspend-state {
> >> + mdss_te: mdss-te-state {
> >
> > This is not used and probably can be dropped.
> >
>
> But I think it should be used - it's just incomplete. There DSI is
> enabled so there should be a panel using the TE/VSYNC. This looks like
> being added for future, just like many other pincfg states.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/5] arm64: dts: qcom: msm8996: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 1/5] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2026-02-19 6:49 ` Dmitry Baryshkov
@ 2026-02-19 9:18 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2026-02-19 9:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 2/18/26 6:24 PM, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 2/5] arm64: dts: qcom: msm8998: Drop redundant VSYNC pin state
2026-02-18 17:24 [PATCH 0/5] arm64: dts: qcom: Drop redundant VSYNC pin state Krzysztof Kozlowski
2026-02-18 17:24 ` [PATCH 1/5] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
@ 2026-02-18 17:24 ` Krzysztof Kozlowski
2026-02-19 6:51 ` Dmitry Baryshkov
2026-02-19 9:19 ` Konrad Dybcio
2026-02-18 17:24 ` [PATCH 3/5] arm64: dts: qcom: sdm845-axolotl: " Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 2 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-18 17:24 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
The active and suspend pin state of VSYNC is exactly the same, so just
use one node for both states.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
index 0cac06f25a77..30222f6608da 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
+++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
@@ -543,14 +543,7 @@ mdss_dsi_suspend_state: mdss-dsi-suspend-state {
bias-pull-down;
};
- mdss_te_active_state: mdss-te-active-state {
- pins = "gpio10";
- function = "mdp_vsync_a";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- mdss_te_suspend_state: mdss-te-suspend-state {
+ mdss_te_state: mdss-te-state {
pins = "gpio10";
function = "mdp_vsync_a";
drive-strength = <2>;
--
2.51.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 2/5] arm64: dts: qcom: msm8998: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 2/5] arm64: dts: qcom: msm8998: " Krzysztof Kozlowski
@ 2026-02-19 6:51 ` Dmitry Baryshkov
2026-02-19 8:40 ` Dmitry Baryshkov
2026-02-19 9:19 ` Konrad Dybcio
1 sibling, 1 reply; 19+ messages in thread
From: Dmitry Baryshkov @ 2026-02-19 6:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Wed, Feb 18, 2026 at 06:24:24PM +0100, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> index 0cac06f25a77..30222f6608da 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> @@ -543,14 +543,7 @@ mdss_dsi_suspend_state: mdss-dsi-suspend-state {
> bias-pull-down;
> };
>
> - mdss_te_active_state: mdss-te-active-state {
> - pins = "gpio10";
> - function = "mdp_vsync_a";
> - drive-strength = <2>;
> - bias-pull-down;
> - };
> -
> - mdss_te_suspend_state: mdss-te-suspend-state {
> + mdss_te_state: mdss-te-state {
Seems also to be unused. Can we drop it?
> pins = "gpio10";
> function = "mdp_vsync_a";
> drive-strength = <2>;
>
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 2/5] arm64: dts: qcom: msm8998: Drop redundant VSYNC pin state
2026-02-19 6:51 ` Dmitry Baryshkov
@ 2026-02-19 8:40 ` Dmitry Baryshkov
0 siblings, 0 replies; 19+ messages in thread
From: Dmitry Baryshkov @ 2026-02-19 8:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Thu, Feb 19, 2026 at 08:51:38AM +0200, Dmitry Baryshkov wrote:
> On Wed, Feb 18, 2026 at 06:24:24PM +0100, Krzysztof Kozlowski wrote:
> > The active and suspend pin state of VSYNC is exactly the same, so just
> > use one node for both states.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> > index 0cac06f25a77..30222f6608da 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> > +++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> > @@ -543,14 +543,7 @@ mdss_dsi_suspend_state: mdss-dsi-suspend-state {
> > bias-pull-down;
> > };
> >
> > - mdss_te_active_state: mdss-te-active-state {
> > - pins = "gpio10";
> > - function = "mdp_vsync_a";
> > - drive-strength = <2>;
> > - bias-pull-down;
> > - };
> > -
> > - mdss_te_suspend_state: mdss-te-suspend-state {
> > + mdss_te_state: mdss-te-state {
>
> Seems also to be unused. Can we drop it?
With the same "can be used later" approach:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
> > pins = "gpio10";
> > function = "mdp_vsync_a";
> > drive-strength = <2>;
> >
> > --
> > 2.51.0
> >
>
> --
> With best wishes
> Dmitry
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/5] arm64: dts: qcom: msm8998: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 2/5] arm64: dts: qcom: msm8998: " Krzysztof Kozlowski
2026-02-19 6:51 ` Dmitry Baryshkov
@ 2026-02-19 9:19 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2026-02-19 9:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 2/18/26 6:24 PM, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/5] arm64: dts: qcom: sdm845-axolotl: Drop redundant VSYNC pin state
2026-02-18 17:24 [PATCH 0/5] arm64: dts: qcom: Drop redundant VSYNC pin state Krzysztof Kozlowski
2026-02-18 17:24 ` [PATCH 1/5] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2026-02-18 17:24 ` [PATCH 2/5] arm64: dts: qcom: msm8998: " Krzysztof Kozlowski
@ 2026-02-18 17:24 ` Krzysztof Kozlowski
2026-02-19 6:52 ` Dmitry Baryshkov
2026-02-19 9:19 ` Konrad Dybcio
2026-02-18 17:24 ` [PATCH 4/5] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2026-02-18 17:24 ` [PATCH 5/5] arm64: dts: qcom: sm8650: " Krzysztof Kozlowski
4 siblings, 2 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-18 17:24 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
The active and suspend pin state of VSYNC is exactly the same, so just
use one node for both states.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 51b041f91d3e..740eb2255072 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -483,8 +483,8 @@ panel@0 {
reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default", "sleep";
- pinctrl-0 = <&sde_dsi_active &sde_te_active>;
- pinctrl-1 = <&sde_dsi_suspend &sde_te_suspend>;
+ pinctrl-0 = <&sde_dsi_active &sde_te>;
+ pinctrl-1 = <&sde_dsi_suspend &sde_te>;
port {
panel_in_0: endpoint {
@@ -623,14 +623,7 @@ sde_dsi_suspend: sde-dsi-suspend-state {
bias-pull-down;
};
- sde_te_active: sde-te-active-state {
- pins = "gpio10";
- function = "mdp_vsync";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- sde_te_suspend: sde-te-suspend-state {
+ sde_te: sde-te-state {
pins = "gpio10";
function = "mdp_vsync";
drive-strength = <2>;
--
2.51.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 3/5] arm64: dts: qcom: sdm845-axolotl: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 3/5] arm64: dts: qcom: sdm845-axolotl: " Krzysztof Kozlowski
@ 2026-02-19 6:52 ` Dmitry Baryshkov
2026-02-19 9:19 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Dmitry Baryshkov @ 2026-02-19 6:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Wed, Feb 18, 2026 at 06:24:25PM +0100, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/5] arm64: dts: qcom: sdm845-axolotl: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 3/5] arm64: dts: qcom: sdm845-axolotl: " Krzysztof Kozlowski
2026-02-19 6:52 ` Dmitry Baryshkov
@ 2026-02-19 9:19 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2026-02-19 9:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 2/18/26 6:24 PM, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 4/5] arm64: dts: qcom: sm8550: Drop redundant VSYNC pin state
2026-02-18 17:24 [PATCH 0/5] arm64: dts: qcom: Drop redundant VSYNC pin state Krzysztof Kozlowski
` (2 preceding siblings ...)
2026-02-18 17:24 ` [PATCH 3/5] arm64: dts: qcom: sdm845-axolotl: " Krzysztof Kozlowski
@ 2026-02-18 17:24 ` Krzysztof Kozlowski
2026-02-19 6:57 ` Dmitry Baryshkov
2026-02-19 9:19 ` Konrad Dybcio
2026-02-18 17:24 ` [PATCH 5/5] arm64: dts: qcom: sm8650: " Krzysztof Kozlowski
4 siblings, 2 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-18 17:24 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
The active and suspend pin state of VSYNC is exactly the same, so just
use one node for both states.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 13 +++----------
arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 13 +++----------
2 files changed, 6 insertions(+), 20 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
index 94ed1c221856..5769be83cfbd 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
@@ -707,8 +707,8 @@ panel@0 {
reg = <0>;
pinctrl-names = "default", "sleep";
- pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>;
- pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>;
+ pinctrl-0 = <&sde_dsi_active>, <&sde_te>;
+ pinctrl-1 = <&sde_dsi_suspend>, <&sde_te>;
vddio-supply = <&vreg_l12b_1p8>;
vci-supply = <&vreg_l13b_3p0>;
@@ -915,14 +915,7 @@ sde_dsi_suspend: sde-dsi-suspend-state {
bias-pull-down;
};
- sde_te_active: sde-te-active-state {
- pins = "gpio86";
- function = "mdp_vsync";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- sde_te_suspend: sde-te-suspend-state {
+ sde_te: sde-te-state {
pins = "gpio86";
function = "mdp_vsync";
drive-strength = <2>;
diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
index c35d4737a412..2fb2e0be5e4c 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
@@ -870,8 +870,8 @@ panel@0 {
compatible = "visionox,vtdr6130";
reg = <0>;
- pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>;
- pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>;
+ pinctrl-0 = <&sde_dsi_active>, <&sde_te>;
+ pinctrl-1 = <&sde_dsi_suspend>, <&sde_te>;
pinctrl-names = "default", "sleep";
vci-supply = <&vreg_l13b_3p0>;
@@ -1179,14 +1179,7 @@ sde_dsi_suspend: sde-dsi-suspend-state {
bias-pull-down;
};
- sde_te_active: sde-te-active-state {
- pins = "gpio86";
- function = "mdp_vsync";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- sde_te_suspend: sde-te-suspend-state {
+ sde_te: sde-te-state {
pins = "gpio86";
function = "mdp_vsync";
drive-strength = <2>;
--
2.51.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 4/5] arm64: dts: qcom: sm8550: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 4/5] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
@ 2026-02-19 6:57 ` Dmitry Baryshkov
2026-02-19 9:19 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Dmitry Baryshkov @ 2026-02-19 6:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Wed, Feb 18, 2026 at 06:24:26PM +0100, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 13 +++----------
> arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 13 +++----------
> 2 files changed, 6 insertions(+), 20 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 4/5] arm64: dts: qcom: sm8550: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 4/5] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2026-02-19 6:57 ` Dmitry Baryshkov
@ 2026-02-19 9:19 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2026-02-19 9:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 2/18/26 6:24 PM, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 5/5] arm64: dts: qcom: sm8650: Drop redundant VSYNC pin state
2026-02-18 17:24 [PATCH 0/5] arm64: dts: qcom: Drop redundant VSYNC pin state Krzysztof Kozlowski
` (3 preceding siblings ...)
2026-02-18 17:24 ` [PATCH 4/5] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
@ 2026-02-18 17:24 ` Krzysztof Kozlowski
2026-02-19 6:58 ` Dmitry Baryshkov
2026-02-19 9:20 ` Konrad Dybcio
4 siblings, 2 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-18 17:24 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
The active and suspend pin state of VSYNC is exactly the same, so just
use one node for both states.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 13 +++----------
arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 13 +++----------
2 files changed, 6 insertions(+), 20 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
index bb688a5d21c2..dd6e33d2dc5d 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
@@ -618,8 +618,8 @@ panel@0 {
vci-supply = <&vreg_l13b_3p0>;
vdd-supply = <&vreg_l11b_1p2>;
- pinctrl-0 = <&disp0_reset_n_active>, <&mdp_vsync_active>;
- pinctrl-1 = <&disp0_reset_n_suspend>, <&mdp_vsync_suspend>;
+ pinctrl-0 = <&disp0_reset_n_active>, <&mdp_vsync>;
+ pinctrl-1 = <&disp0_reset_n_suspend>, <&mdp_vsync>;
pinctrl-names = "default", "sleep";
port {
@@ -821,14 +821,7 @@ disp0_reset_n_suspend: disp0-reset-n-suspend-state {
bias-pull-down;
};
- mdp_vsync_active: mdp-vsync-active-state {
- pins = "gpio86";
- function = "mdp_vsync";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- mdp_vsync_suspend: mdp-vsync-suspend-state {
+ mdp_vsync: mdp-vsync-state {
pins = "gpio86";
function = "mdp_vsync";
drive-strength = <2>;
diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
index 087828c60692..a3982ae22929 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
@@ -908,8 +908,8 @@ panel@0 {
vci-supply = <&vreg_l13b_3p0>;
vdd-supply = <&vreg_l11b_1p2>;
- pinctrl-0 = <&disp0_reset_n_active>, <&mdp_vsync_active>;
- pinctrl-1 = <&disp0_reset_n_suspend>, <&mdp_vsync_suspend>;
+ pinctrl-0 = <&disp0_reset_n_active>, <&mdp_vsync>;
+ pinctrl-1 = <&disp0_reset_n_suspend>, <&mdp_vsync>;
pinctrl-names = "default", "sleep";
port {
@@ -1244,14 +1244,7 @@ disp0_reset_n_suspend: disp0-reset-n-suspend-state {
bias-pull-down;
};
- mdp_vsync_active: mdp-vsync-active-state {
- pins = "gpio86";
- function = "mdp_vsync";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- mdp_vsync_suspend: mdp-vsync-suspend-state {
+ mdp_vsync: mdp-vsync-state {
pins = "gpio86";
function = "mdp_vsync";
drive-strength = <2>;
--
2.51.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 5/5] arm64: dts: qcom: sm8650: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 5/5] arm64: dts: qcom: sm8650: " Krzysztof Kozlowski
@ 2026-02-19 6:58 ` Dmitry Baryshkov
2026-02-19 9:20 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Dmitry Baryshkov @ 2026-02-19 6:58 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Wed, Feb 18, 2026 at 06:24:27PM +0100, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 13 +++----------
> arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 13 +++----------
> 2 files changed, 6 insertions(+), 20 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 5/5] arm64: dts: qcom: sm8650: Drop redundant VSYNC pin state
2026-02-18 17:24 ` [PATCH 5/5] arm64: dts: qcom: sm8650: " Krzysztof Kozlowski
2026-02-19 6:58 ` Dmitry Baryshkov
@ 2026-02-19 9:20 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2026-02-19 9:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 2/18/26 6:24 PM, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread