From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Dikshita Agarwal <quic_dikshita@quicinc.com>,
linux-media@vger.kernel.org, stanimir.k.varbanov@gmail.com,
quic_vgarodia@quicinc.com, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
mchehab@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Viswanath Boma <quic_vboma@quicinc.com>
Subject: Re: [PATCH v2 3/3] venus: fix EOS handling in decoder stop command
Date: Sun, 9 Apr 2023 20:10:01 +0300 [thread overview]
Message-ID: <ccbf905b-2c0b-e5e2-1ee2-485d3af52247@linaro.org> (raw)
In-Reply-To: <1680848758-3947-4-git-send-email-quic_dikshita@quicinc.com>
On 07/04/2023 09:25, Dikshita Agarwal wrote:
> Use firmware version based check to assign correct
> device address for EOS buffer to fix the EOS handling
> with different firmware version.
>
> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
> Signed-off-by: Viswanath Boma <quic_vboma@quicinc.com>
Order of sign-offs is incorrect. The SoB of the sender should be the
last one.
> Tested-by: Nathan Hebert <nhebert@chromium.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/media/platform/qcom/venus/vdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> index f0394b9..c59b34f 100644
> --- a/drivers/media/platform/qcom/venus/vdec.c
> +++ b/drivers/media/platform/qcom/venus/vdec.c
> @@ -545,7 +545,7 @@ vdec_decoder_cmd(struct file *file, void *fh, struct v4l2_decoder_cmd *cmd)
>
> fdata.buffer_type = HFI_BUFFER_INPUT;
> fdata.flags |= HFI_BUFFERFLAG_EOS;
> - if (IS_V6(inst->core))
> + if (IS_V6(inst->core) && is_fw_rev_or_older(inst->core, 1, 0, 87))
> fdata.device_addr = 0;
> else
> fdata.device_addr = 0xdeadb000;
--
With best wishes
Dmitry
prev parent reply other threads:[~2023-04-09 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 6:25 [PATCH v2 0/3] fix decoder issues with firmware version check Dikshita Agarwal
2023-04-07 6:25 ` [PATCH v2 1/3] venus: add firmware version based check Dikshita Agarwal
2023-04-08 7:15 ` Konrad Dybcio
2023-04-18 9:47 ` Dikshita Agarwal
2023-04-09 5:18 ` Stanimir Varbanov
2023-04-11 10:59 ` Konrad Dybcio
2023-04-13 23:01 ` Konrad Dybcio
2023-04-13 23:08 ` Konrad Dybcio
2023-04-18 9:51 ` Dikshita Agarwal
2023-04-07 6:25 ` [PATCH v2 2/3] venus: enable sufficient sequence change support for vp9 Dikshita Agarwal
2023-04-09 17:10 ` Dmitry Baryshkov
2023-04-07 6:25 ` [PATCH v2 3/3] venus: fix EOS handling in decoder stop command Dikshita Agarwal
2023-04-09 17:10 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccbf905b-2c0b-e5e2-1ee2-485d3af52247@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vboma@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox