Re: [PATCH v7 0/4] media: camss: sm8250: Virtual channels support for SM8250

["Milen Mitkov (Consultant)" <quic_mmitkov@quicinc.com>]

On 03/04/2023 12:16, Bryan O'Donoghue wrote:
> On 03/04/2023 09:38, Milen Mitkov (Consultant) wrote:
>> On 31/03/2023 11:07, Bryan O'Donoghue wrote:
>>> On 31/03/2023 07:20, Azam Sadiq Pasha Kapatrala Syed wrote:
>>>> + Nico (Linaro)
>>>> Hi Team
>>>>
>>>> Would like to know if anything is pending form our end as we want 
>>>> to get the patches mainlined?
>>>>
>>>> Thanks,
>>>> Azam
>>>
>>> I'd like to get a clearer picture on this
>>>
>>> [   90.535909] qcom-camss ac6a000.camss: VFE HW Version = 2.0.1
>>> [   90.545756] qcom-camss ac6a000.camss: CSIPHY 3PH HW Version = 
>>> 0x40010000
>>> [   90.546358] qcom-camss ac6a000.camss: CSID HW Version = 2.0.1
>>> [   90.546365] qcom-camss ac6a000.camss: csid_link_setup: Enabled 
>>> CSID virtual channels mask 0x1
>>> [   90.547675] qcom-camss ac6a000.camss: csid_link_setup: Enabled 
>>> CSID virtual channels mask 0x0
>>>
>>> Using the IMX577 sensor on the RB5 we get his pretty odd virtual 
>>> channels mask.
>>>
>>> If userspace is sending this in, the question I have is why. Surely 
>>> with a sensor that doesn't have a VC there should be no impact on 
>>> user-space.
>>>
>>> ---
>>> bod
>>
>> Hey Bryan,
>>
>> what media-ctl commands are you using? I can't recreate this on my 
>> side. I am using this set of commands to test (with the default 
>> imx577 driver without any multiple virtual channels outputs) and am 
>> getting only the first message (virtual channels mask 0x1):
>>
>> media-ctl --reset
>> media-ctl -v -d /dev/media0 -V '"imx577 
>> '22-001a'":0[fmt:SRGGB10/4056x3040 field:none]'
>> media-ctl -V '"msm_csiphy2":0[fmt:SRGGB10/4056x3040]'
>> media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
>> media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
>> media-ctl -l '"msm_csiphy2":1->"msm_csid0":0[1]'
>> media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
>>
>> yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F 
>> /dev/video0
>>
>>
>> Thanks,
>>
>> Milen
>
> Its a dev_dbg() so "#define DEBUG 1" in 
> drivers/media/platform/qcom/camss/camss-csid.c
>
> ---
> bod
>
Yes, I enabled the dev_dbg(). I just see only one message with regards 
to the channels mask. Just this one:

[   90.546365] qcom-camss ac6a000.camss: csid_link_setup: Enabled CSID 
virtual channels mask 0x1

so I wonder if you're testing with a different set of media-ctl/yavta 
commands.


Regards,

Milen