* [PATCH v2] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory overlaps with the SMEM and MPSS memory regions
@ 2023-02-02 5:48 Jamie Douglass
2023-02-02 11:19 ` Konrad Dybcio
2023-02-09 4:22 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Jamie Douglass @ 2023-02-02 5:48 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Petr Vorel, Dominik Kobinski, linux-arm-msm,
devicetree, linux-kernel
Cc: ~postmarketos/upstreaming, phone-devel, Jamie Douglass,
Petr Vorel
The memory region reserved by a previous commit (see fixes tag below)
overlaps with the SMEM and MPSS memory regions, causing error messages in
dmesg:
OF: reserved mem: OVERLAP DETECTED!
reserved@5000000 (0x0000000005000000--0x0000000007200000)
overlaps with smem_region@6a00000
(0x0000000006a00000--0x0000000006c00000)
OF: reserved mem: OVERLAP DETECTED!
reserved@6c00000 (0x0000000006c00000--0x0000000007200000)
overlaps with memory@7000000
(0x0000000007000000--0x000000000ca00000)
This patch resolves both of these by splitting the previously reserved
memory region into two sections either side of the SMEM region and by
cutting off the second memory region to 0x7000000.
Fixes: 22c7e1a0fa45 ("arm64: dts: msm8992-bullhead: add memory hole region")
Signed-off-by: Jamie Douglass <jamiemdouglass@gmail.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Tested-by: Petr Vorel <pvorel@suse.cz>
---
v1 -> v2: Added detail about second memory overlap and fixed commit to commit
message
---
arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
index 79de9cc395c4..5e375ea73c79 100644
--- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
@@ -53,8 +53,13 @@ cont_splash_mem: memory@3400000 {
no-map;
};
- removed_region: reserved@5000000 {
- reg = <0 0x05000000 0 0x2200000>;
+ reserved@5000000 {
+ reg = <0x0 0x05000000 0x0 0x1a00000>;
+ no-map;
+ };
+
+ reserved@6c00000 {
+ reg = <0x0 0x06c00000 0x0 0x400000>;
no-map;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory overlaps with the SMEM and MPSS memory regions
2023-02-02 5:48 [PATCH v2] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory overlaps with the SMEM and MPSS memory regions Jamie Douglass
@ 2023-02-02 11:19 ` Konrad Dybcio
2023-02-09 4:22 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-02-02 11:19 UTC (permalink / raw)
To: Jamie Douglass, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Petr Vorel, Dominik Kobinski, linux-arm-msm,
devicetree, linux-kernel
Cc: ~postmarketos/upstreaming, phone-devel, Petr Vorel
On 2.02.2023 06:48, Jamie Douglass wrote:
> The memory region reserved by a previous commit (see fixes tag below)
> overlaps with the SMEM and MPSS memory regions, causing error messages in
> dmesg:
> OF: reserved mem: OVERLAP DETECTED!
> reserved@5000000 (0x0000000005000000--0x0000000007200000)
> overlaps with smem_region@6a00000
> (0x0000000006a00000--0x0000000006c00000)
>
> OF: reserved mem: OVERLAP DETECTED!
> reserved@6c00000 (0x0000000006c00000--0x0000000007200000)
> overlaps with memory@7000000
> (0x0000000007000000--0x000000000ca00000)
>
> This patch resolves both of these by splitting the previously reserved
> memory region into two sections either side of the SMEM region and by
> cutting off the second memory region to 0x7000000.
>
> Fixes: 22c7e1a0fa45 ("arm64: dts: msm8992-bullhead: add memory hole region")
> Signed-off-by: Jamie Douglass <jamiemdouglass@gmail.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Tested-by: Petr Vorel <pvorel@suse.cz>
>
> ---
> v1 -> v2: Added detail about second memory overlap and fixed commit to commit
> message
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> index 79de9cc395c4..5e375ea73c79 100644
> --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> @@ -53,8 +53,13 @@ cont_splash_mem: memory@3400000 {
> no-map;
> };
>
> - removed_region: reserved@5000000 {
> - reg = <0 0x05000000 0 0x2200000>;
> + reserved@5000000 {
> + reg = <0x0 0x05000000 0x0 0x1a00000>;
> + no-map;
> + };
> +
> + reserved@6c00000 {
> + reg = <0x0 0x06c00000 0x0 0x400000>;
> no-map;
> };
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory overlaps with the SMEM and MPSS memory regions
2023-02-02 5:48 [PATCH v2] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory overlaps with the SMEM and MPSS memory regions Jamie Douglass
2023-02-02 11:19 ` Konrad Dybcio
@ 2023-02-09 4:22 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-02-09 4:22 UTC (permalink / raw)
To: Jamie Douglass, Andy Gross, Rob Herring, Konrad Dybcio,
Petr Vorel, devicetree, Dominik Kobinski, linux-kernel,
Krzysztof Kozlowski, linux-arm-msm
Cc: phone-devel, ~postmarketos/upstreaming, Petr Vorel
On Thu, 2 Feb 2023 16:48:19 +1100, Jamie Douglass wrote:
> The memory region reserved by a previous commit (see fixes tag below)
> overlaps with the SMEM and MPSS memory regions, causing error messages in
> dmesg:
> OF: reserved mem: OVERLAP DETECTED!
> reserved@5000000 (0x0000000005000000--0x0000000007200000)
> overlaps with smem_region@6a00000
> (0x0000000006a00000--0x0000000006c00000)
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory overlaps with the SMEM and MPSS memory regions
commit: d44106883d74992343710f18c4aaae937c7cefab
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-09 4:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-02 5:48 [PATCH v2] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory overlaps with the SMEM and MPSS memory regions Jamie Douglass
2023-02-02 11:19 ` Konrad Dybcio
2023-02-09 4:22 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox