* [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash
@ 2021-02-03 16:39 Loic Poulain
2021-02-03 17:13 ` Hemant Kumar
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Loic Poulain @ 2021-02-03 16:39 UTC (permalink / raw)
To: manivannan.sadhasivam, hemantk; +Cc: linux-arm-msm, Loic Poulain
Print warning when MHI detects sys error.
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
v2: remove useless fallthough & unused mhi_pdev variable
drivers/bus/mhi/pci_generic.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 444693e..2476041 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -217,7 +217,17 @@ static void mhi_pci_write_reg(struct mhi_controller *mhi_cntrl,
static void mhi_pci_status_cb(struct mhi_controller *mhi_cntrl,
enum mhi_callback cb)
{
+ struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
+
/* Nothing to do for now */
+ switch (cb) {
+ case MHI_CB_FATAL_ERROR:
+ case MHI_CB_SYS_ERROR:
+ dev_warn(&pdev->dev, "firmware crashed (%u)\n", cb);
+ break;
+ default:
+ break;
+ }
}
static bool mhi_pci_is_alive(struct mhi_controller *mhi_cntrl)
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash
2021-02-03 16:39 [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash Loic Poulain
@ 2021-02-03 17:13 ` Hemant Kumar
2021-02-05 12:26 ` Manivannan Sadhasivam
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Hemant Kumar @ 2021-02-03 17:13 UTC (permalink / raw)
To: Loic Poulain, manivannan.sadhasivam; +Cc: linux-arm-msm
On 2/3/21 8:39 AM, Loic Poulain wrote:
> Print warning when MHI detects sys error.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> v2: remove useless fallthough & unused mhi_pdev variable
>
> drivers/bus/mhi/pci_generic.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash
2021-02-03 16:39 [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash Loic Poulain
2021-02-03 17:13 ` Hemant Kumar
@ 2021-02-05 12:26 ` Manivannan Sadhasivam
2021-02-05 12:33 ` Manivannan Sadhasivam
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2021-02-05 12:26 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, linux-arm-msm
On Wed, Feb 03, 2021 at 05:39:42PM +0100, Loic Poulain wrote:
> Print warning when MHI detects sys error.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> v2: remove useless fallthough & unused mhi_pdev variable
>
> drivers/bus/mhi/pci_generic.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 444693e..2476041 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -217,7 +217,17 @@ static void mhi_pci_write_reg(struct mhi_controller *mhi_cntrl,
> static void mhi_pci_status_cb(struct mhi_controller *mhi_cntrl,
> enum mhi_callback cb)
> {
> + struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
> +
> /* Nothing to do for now */
> + switch (cb) {
> + case MHI_CB_FATAL_ERROR:
> + case MHI_CB_SYS_ERROR:
> + dev_warn(&pdev->dev, "firmware crashed (%u)\n", cb);
> + break;
> + default:
> + break;
> + }
> }
>
> static bool mhi_pci_is_alive(struct mhi_controller *mhi_cntrl)
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash
2021-02-03 16:39 [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash Loic Poulain
2021-02-03 17:13 ` Hemant Kumar
2021-02-05 12:26 ` Manivannan Sadhasivam
@ 2021-02-05 12:33 ` Manivannan Sadhasivam
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2021-02-05 12:33 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, linux-arm-msm
On Wed, Feb 03, 2021 at 05:39:42PM +0100, Loic Poulain wrote:
> Print warning when MHI detects sys error.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> v2: remove useless fallthough & unused mhi_pdev variable
>
> drivers/bus/mhi/pci_generic.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 444693e..2476041 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -217,7 +217,17 @@ static void mhi_pci_write_reg(struct mhi_controller *mhi_cntrl,
> static void mhi_pci_status_cb(struct mhi_controller *mhi_cntrl,
> enum mhi_callback cb)
> {
> + struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
> +
> /* Nothing to do for now */
> + switch (cb) {
> + case MHI_CB_FATAL_ERROR:
> + case MHI_CB_SYS_ERROR:
> + dev_warn(&pdev->dev, "firmware crashed (%u)\n", cb);
> + break;
> + default:
> + break;
> + }
> }
>
> static bool mhi_pci_is_alive(struct mhi_controller *mhi_cntrl)
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash
2021-02-03 16:39 [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash Loic Poulain
` (2 preceding siblings ...)
2021-02-05 12:33 ` Manivannan Sadhasivam
@ 2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-03-01 19:59 UTC (permalink / raw)
To: Loic Poulain; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Wed, 3 Feb 2021 17:39:42 +0100 you wrote:
> Print warning when MHI detects sys error.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> v2: remove useless fallthough & unused mhi_pdev variable
>
> drivers/bus/mhi/pci_generic.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Here is the summary with links:
- [v2] mhi: pci_generic: Print warning in case of firmware crash
https://git.kernel.org/qcom/c/1e2f29ba83c5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-01 20:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-03 16:39 [PATCH v2] mhi: pci_generic: Print warning in case of firmware crash Loic Poulain
2021-02-03 17:13 ` Hemant Kumar
2021-02-05 12:26 ` Manivannan Sadhasivam
2021-02-05 12:33 ` Manivannan Sadhasivam
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox