From: Paolo Abeni <pabeni@redhat.com>
To: Alex Elder <elder@linaro.org>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org
Cc: mka@chromium.org, evgreen@chromium.org, andersson@kernel.org,
quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com,
quic_jponduru@quicinc.com, quic_subashab@quicinc.com,
elder@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/6] net: ipa: move and redefine ipa_version_valid()
Date: Tue, 20 Sep 2022 10:29:39 +0200 [thread overview]
Message-ID: <d98d439ef5ee8a1744481bf1f076fbed918c3cef.camel@redhat.com> (raw)
In-Reply-To: <20220910011131.1431934-4-elder@linaro.org>
On Fri, 2022-09-09 at 20:11 -0500, Alex Elder wrote:
> Move the definition of ipa_version_valid(), making it a static
> inline function defined together with the enumerated type in
> "ipa_version.h". Define a new count value in the type.
>
> Rename the function to be ipa_version_supported(), and have it
> return true only if the IPA version supplied is explicitly supported
> by the driver.
I'm wondering if the above is going to cause regressions with some IPA
versions suddenly not probed anymore by the module?
Additionally there are a few places checking for the now unsupported
version[s], I guess that check could/should be removed? e.g.
ipa_reg_irq_suspend_en_ee_n_offset(),
ipa_reg_irq_suspend_info_ee_n_offset()
...
Thanks,
Paolo
next prev parent reply other threads:[~2022-09-20 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 1:11 [PATCH net-next 0/6] net: ipa: a mix of cleanups Alex Elder
2022-09-10 1:11 ` [PATCH net-next 1/6] net: ipa: don't define unneeded GSI register offsets Alex Elder
2022-09-10 1:11 ` [PATCH net-next 2/6] net: ipa: move the definition of gsi_ee_id Alex Elder
2022-09-10 1:11 ` [PATCH net-next 3/6] net: ipa: move and redefine ipa_version_valid() Alex Elder
2022-09-20 8:29 ` Paolo Abeni [this message]
2022-09-20 12:50 ` Alex Elder
2022-09-20 13:37 ` Paolo Abeni
2022-09-10 1:11 ` [PATCH net-next 4/6] net: ipa: don't reuse variable names Alex Elder
2022-09-10 1:11 ` [PATCH net-next 5/6] net: ipa: update sequencer definition constraints Alex Elder
2022-09-10 1:11 ` [PATCH net-next 6/6] net: ipa: fix two symbol names Alex Elder
2022-09-20 14:50 ` [PATCH net-next 0/6] net: ipa: a mix of cleanups patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d98d439ef5ee8a1744481bf1f076fbed918c3cef.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=quic_avuyyuru@quicinc.com \
--cc=quic_cpratapa@quicinc.com \
--cc=quic_jponduru@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox