* [PATCH] arm64: dts: qcom: x1e80100: Add orientation-switch to all USB+DP QMP PHYs
@ 2024-08-29 11:44 Abel Vesa
2024-08-29 21:34 ` Konrad Dybcio
2024-08-31 3:18 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Abel Vesa @ 2024-08-29 11:44 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Johan Hovold, linux-arm-msm, devicetree, linux-kernel, Abel Vesa
All three USB SS combo QMP PHYs need to power off, deinit, then init and
power on again on every plug in event. This is done by forwarding the
orientation from the retimer/mux to the PHY. All is needed is the
orientation-switch property in each such PHY devicetree node. So add
them.
Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 6abff8258674..8a577f29d4d4 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -2604,6 +2604,8 @@ usb_1_ss0_qmpphy: phy@fd5000 {
#clock-cells = <1>;
#phy-cells = <1>;
+ orientation-switch;
+
status = "disabled";
ports {
@@ -2672,6 +2674,8 @@ usb_1_ss1_qmpphy: phy@fda000 {
#clock-cells = <1>;
#phy-cells = <1>;
+ orientation-switch;
+
status = "disabled";
ports {
@@ -2740,6 +2744,8 @@ usb_1_ss2_qmpphy: phy@fdf000 {
#clock-cells = <1>;
#phy-cells = <1>;
+ orientation-switch;
+
status = "disabled";
ports {
---
base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e
change-id: 20240829-x1e80100-combo-qmpphys-add-orientation-switch-afc7f6f25137
Best regards,
--
Abel Vesa <abel.vesa@linaro.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: x1e80100: Add orientation-switch to all USB+DP QMP PHYs
2024-08-29 11:44 [PATCH] arm64: dts: qcom: x1e80100: Add orientation-switch to all USB+DP QMP PHYs Abel Vesa
@ 2024-08-29 21:34 ` Konrad Dybcio
2024-08-31 3:18 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-08-29 21:34 UTC (permalink / raw)
To: Abel Vesa, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Johan Hovold, linux-arm-msm, devicetree, linux-kernel
On 29.08.2024 1:44 PM, Abel Vesa wrote:
> All three USB SS combo QMP PHYs need to power off, deinit, then init and
> power on again on every plug in event. This is done by forwarding the
> orientation from the retimer/mux to the PHY. All is needed is the
> orientation-switch property in each such PHY devicetree node. So add
> them.
>
> Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: x1e80100: Add orientation-switch to all USB+DP QMP PHYs
2024-08-29 11:44 [PATCH] arm64: dts: qcom: x1e80100: Add orientation-switch to all USB+DP QMP PHYs Abel Vesa
2024-08-29 21:34 ` Konrad Dybcio
@ 2024-08-31 3:18 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-08-31 3:18 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa
Cc: Johan Hovold, linux-arm-msm, devicetree, linux-kernel
On Thu, 29 Aug 2024 14:44:47 +0300, Abel Vesa wrote:
> All three USB SS combo QMP PHYs need to power off, deinit, then init and
> power on again on every plug in event. This is done by forwarding the
> orientation from the retimer/mux to the PHY. All is needed is the
> orientation-switch property in each such PHY devicetree node. So add
> them.
>
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: x1e80100: Add orientation-switch to all USB+DP QMP PHYs
commit: 17c5909f53e01c151c91f66949a9c4f191756bae
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-31 3:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 11:44 [PATCH] arm64: dts: qcom: x1e80100: Add orientation-switch to all USB+DP QMP PHYs Abel Vesa
2024-08-29 21:34 ` Konrad Dybcio
2024-08-31 3:18 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox