* [PATCH v2] clk: Print an info line before disabling unused clocks
@ 2023-03-07 13:29 Konrad Dybcio
2023-03-29 18:49 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Konrad Dybcio @ 2023-03-07 13:29 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: marijn.suijten, Konrad Dybcio, Michael Turquette, Stephen Boyd,
linux-clk, linux-kernel
Currently, the regulator framework informs us before calling into
their unused cleanup paths, which eases at least some debugging. The
same could be beneficial for clocks, so that random shutdowns shortly
after most initcalls are done can be less of a guess.
Add a pr_info before disabling unused clocks to do so.
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:
- Don't add 'else' right before a return
- Add Marijn's r-b
drivers/clk/clk.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ae07685c7588..115a80fda3f9 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1406,6 +1406,8 @@ static int __init clk_disable_unused(void)
return 0;
}
+ pr_info("clk: Disabling unused clocks\n");
+
clk_prepare_lock();
hlist_for_each_entry(core, &clk_root_list, child_node)
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] clk: Print an info line before disabling unused clocks
2023-03-07 13:29 [PATCH v2] clk: Print an info line before disabling unused clocks Konrad Dybcio
@ 2023-03-29 18:49 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2023-03-29 18:49 UTC (permalink / raw)
To: Konrad Dybcio, agross, andersson, linux-arm-msm
Cc: marijn.suijten, Konrad Dybcio, Michael Turquette, linux-clk,
linux-kernel
Quoting Konrad Dybcio (2023-03-07 05:29:28)
> Currently, the regulator framework informs us before calling into
> their unused cleanup paths, which eases at least some debugging. The
> same could be beneficial for clocks, so that random shutdowns shortly
> after most initcalls are done can be less of a guess.
>
> Add a pr_info before disabling unused clocks to do so.
>
> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-29 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-07 13:29 [PATCH v2] clk: Print an info line before disabling unused clocks Konrad Dybcio
2023-03-29 18:49 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox