* [PATCH][V2] drm/msm/a5xx: remove null pointer check on pdev
@ 2024-11-12 18:22 Colin Ian King
2024-11-12 20:30 ` Akhil P Oommen
2024-11-14 13:57 ` Konrad Dybcio
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-11-12 18:22 UTC (permalink / raw)
To: Rob Clark, Sean Paul, Konrad Dybcio, Abhinav Kumar,
Dmitry Baryshkov, Marijn Suijten, David Airlie, Simona Vetter,
linux-arm-msm, dri-devel, freedreno
Cc: kernel-janitors, linux-kernel
The call chain on a5xx_gpu_init is such that pdev is not going to be
null, so the null check on pdev can be removed. This also cleans up
a static analysis warning where pdev is dereferenced before the null
check which cannot actually occur.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
V2: rewrite Subject, remove null check on pdev
---
drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
index ee89db72e36e..4edf9109d1d8 100644
--- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
@@ -1760,11 +1760,6 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev)
unsigned int nr_rings;
int ret;
- if (!pdev) {
- DRM_DEV_ERROR(dev->dev, "No A5XX device is defined\n");
- return ERR_PTR(-ENXIO);
- }
-
a5xx_gpu = kzalloc(sizeof(*a5xx_gpu), GFP_KERNEL);
if (!a5xx_gpu)
return ERR_PTR(-ENOMEM);
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][V2] drm/msm/a5xx: remove null pointer check on pdev
2024-11-12 18:22 [PATCH][V2] drm/msm/a5xx: remove null pointer check on pdev Colin Ian King
@ 2024-11-12 20:30 ` Akhil P Oommen
2024-11-14 13:57 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Akhil P Oommen @ 2024-11-12 20:30 UTC (permalink / raw)
To: Colin Ian King, Rob Clark, Sean Paul, Konrad Dybcio,
Abhinav Kumar, Dmitry Baryshkov, Marijn Suijten, David Airlie,
Simona Vetter, linux-arm-msm, dri-devel, freedreno
Cc: kernel-janitors, linux-kernel
On 11/12/2024 11:52 PM, Colin Ian King wrote:
> The call chain on a5xx_gpu_init is such that pdev is not going to be
> null, so the null check on pdev can be removed. This also cleans up
> a static analysis warning where pdev is dereferenced before the null
> check which cannot actually occur.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
-Akhil
> ---
>
> V2: rewrite Subject, remove null check on pdev
>
> ---
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> index ee89db72e36e..4edf9109d1d8 100644
> --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
> @@ -1760,11 +1760,6 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev)
> unsigned int nr_rings;
> int ret;
>
> - if (!pdev) {
> - DRM_DEV_ERROR(dev->dev, "No A5XX device is defined\n");
> - return ERR_PTR(-ENXIO);
> - }
> -
> a5xx_gpu = kzalloc(sizeof(*a5xx_gpu), GFP_KERNEL);
> if (!a5xx_gpu)
> return ERR_PTR(-ENOMEM);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][V2] drm/msm/a5xx: remove null pointer check on pdev
2024-11-12 18:22 [PATCH][V2] drm/msm/a5xx: remove null pointer check on pdev Colin Ian King
2024-11-12 20:30 ` Akhil P Oommen
@ 2024-11-14 13:57 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-11-14 13:57 UTC (permalink / raw)
To: Colin Ian King, Rob Clark, Sean Paul, Konrad Dybcio,
Abhinav Kumar, Dmitry Baryshkov, Marijn Suijten, David Airlie,
Simona Vetter, linux-arm-msm, dri-devel, freedreno
Cc: kernel-janitors, linux-kernel
On 12.11.2024 7:22 PM, Colin Ian King wrote:
> The call chain on a5xx_gpu_init is such that pdev is not going to be
> null, so the null check on pdev can be removed. This also cleans up
> a static analysis warning where pdev is dereferenced before the null
> check which cannot actually occur.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-14 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 18:22 [PATCH][V2] drm/msm/a5xx: remove null pointer check on pdev Colin Ian King
2024-11-12 20:30 ` Akhil P Oommen
2024-11-14 13:57 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox